[PATCH] selftests/filesystems: fix missing and stale TARGETS entries

[PATCH] selftests/filesystems: fix missing and stale TARGETS entries

[Disha Goel]

filesystems/eventfd, filesystems/open_tree_ns and filesystems/xattr
were never added to TARGETS when introduced. filesystems/openat2 was
moved from selftests/openat2/ but the TARGETS entry was never updated,
leaving a stale entry pointing at a directory that no longer exists.

Fix this by adding the four missing subdirectories to TARGETS and
removing the stale openat2 entry.

Fixes: 7c37857fc23a ("selftests: add eventfd selftests")
Fixes: b8f7622aa6e3 ("selftests/open_tree: add OPEN_TREE_NAMESPACE tests")
Fixes: 7e28fef5d4db ("selftests/xattr: path-based AF_UNIX socket xattr tests")
Fixes: fe087927046c ("selftests: move openat2 tests to selftests/filesystems/")
Signed-off-by: Disha Goel <disgoel@linux.ibm.com>
---
 tools/testing/selftests/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 8d4db2241cc2..4c4df65a6f91 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -33,7 +33,10 @@ TARGETS += fchmodat2
 TARGETS += filesystems
 TARGETS += filesystems/binderfs
 TARGETS += filesystems/epoll
+TARGETS += filesystems/eventfd
 TARGETS += filesystems/fat
+TARGETS += filesystems/openat2
+TARGETS += filesystems/open_tree_ns
 TARGETS += filesystems/overlayfs
 TARGETS += filesystems/statmount
 TARGETS += filesystems/mount-notify
@@ -42,6 +45,7 @@ TARGETS += filesystems/fuse
 TARGETS += filesystems/move_mount
 TARGETS += filesystems/empty_mntns
 TARGETS += filesystems/fsmount_ns
+TARGETS += filesystems/xattr
 TARGETS += firmware
 TARGETS += fpu
 TARGETS += ftrace
@@ -98,7 +102,6 @@ TARGETS += prctl
 TARGETS += proc
 TARGETS += pstore
 TARGETS += ptrace
-TARGETS += openat2
 TARGETS += rdma
 TARGETS += resctrl
 TARGETS += riscv
-- 
2.45.1

Re: [PATCH] selftests/filesystems: fix missing and stale TARGETS entries

[Christian Brauner]

> filesystems/eventfd, filesystems/open_tree_ns and filesystems/xattr
> were never added to TARGETS when introduced. filesystems/openat2 was
> moved from selftests/openat2/ but the TARGETS entry was never updated,
> leaving a stale entry pointing at a directory that no longer exists.
> 
> Fix this by adding the four missing subdirectories to TARGETS and
> removing the stale openat2 entry.
> 
> Fixes: 7c37857fc23a ("selftests: add eventfd selftests")
> Fixes: b8f7622aa6e3 ("selftests/open_tree: add OPEN_TREE_NAMESPACE tests")
> Fixes: 7e28fef5d4db ("selftests/xattr: path-based AF_UNIX socket xattr tests")
> Fixes: fe087927046c ("selftests: move openat2 tests to selftests/filesystems/")
> Signed-off-by: Disha Goel <disgoel@linux.ibm.com>

Seems fine,
Reviewed-by: Christian Brauner (Amutable) <brauner@kernel.org>

-- 
Christian Brauner <brauner@kernel.org>

Re: [PATCH] selftests/filesystems: fix missing and stale TARGETS entries

[Disha Goel]

Gentle ping — is this patch merged or queued for a future merge window.

On 06/07/26 6:40 pm, Christian Brauner wrote:
>> filesystems/eventfd, filesystems/open_tree_ns and filesystems/xattr
>> were never added to TARGETS when introduced. filesystems/openat2 was
>> moved from selftests/openat2/ but the TARGETS entry was never updated,
>> leaving a stale entry pointing at a directory that no longer exists.
>>
>> Fix this by adding the four missing subdirectories to TARGETS and
>> removing the stale openat2 entry.
>>
>> Fixes: 7c37857fc23a ("selftests: add eventfd selftests")
>> Fixes: b8f7622aa6e3 ("selftests/open_tree: add OPEN_TREE_NAMESPACE tests")
>> Fixes: 7e28fef5d4db ("selftests/xattr: path-based AF_UNIX socket xattr tests")
>> Fixes: fe087927046c ("selftests: move openat2 tests to selftests/filesystems/")
>> Signed-off-by: Disha Goel <disgoel@linux.ibm.com>
> 
> Seems fine,
> Reviewed-by: Christian Brauner (Amutable) <brauner@kernel.org>
> 

-- 
Regards,
Disha

Re: [PATCH] selftests/filesystems: fix missing and stale TARGETS entries

[Andrew Morton]

On Mon, 31 Aug 2026 15:16:45 +0530 Disha Goel <disgoel@linux.ibm.com> wrote:

> Gentle ping — is this patch merged or queued for a future merge window.
> 

I can help with that ;)

The four Fixes: targets are problematic.  How are backporters to figure
out what kernel version(s) need the patch?

I guess these things crept in over time and a four-patch series would be
too elaborate.

I'll just queue it for 7.3-rcX and will let others figure out the
fallout.

The underlying code has changed somewhat, but the fixups were simple.


From: Disha Goel <disgoel@linux.ibm.com>
Subject: selftests/filesystems: fix missing and stale TARGETS entries
Date: Fri, 3 Jul 2026 20:37:42 +0530

filesystems/eventfd, filesystems/open_tree_ns and filesystems/xattr were
never added to TARGETS when introduced.  filesystems/openat2 was moved
from selftests/openat2/ but the TARGETS entry was never updated, leaving a
stale entry pointing at a directory that no longer exists.

Fix this by adding the four missing subdirectories to TARGETS and
removing the stale openat2 entry.

Link: https://lore.kernel.org/20260703150742.58991-1-disgoel@linux.ibm.com
Fixes: 7c37857fc23a ("selftests: add eventfd selftests")
Fixes: b8f7622aa6e3 ("selftests/open_tree: add OPEN_TREE_NAMESPACE tests")
Fixes: 7e28fef5d4db ("selftests/xattr: path-based AF_UNIX socket xattr tests")
Fixes: fe087927046c ("selftests: move openat2 tests to selftests/filesystems/")
Signed-off-by: Disha Goel <disgoel@linux.ibm.com>
Reviewed-by: Christian Brauner (Amutable) <brauner@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Wen Yang <wenyang.linux@foxmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 tools/testing/selftests/Makefile |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- a/tools/testing/selftests/Makefile~selftests-filesystems-fix-missing-and-stale-targets-entries
+++ a/tools/testing/selftests/Makefile
@@ -35,8 +35,11 @@ TARGETS += fchmodat2
 TARGETS += filesystems
 TARGETS += filesystems/binderfs
 TARGETS += filesystems/epoll
+TARGETS += filesystems/eventfd
 TARGETS += filesystems/failfs
 TARGETS += filesystems/fat
+TARGETS += filesystems/openat2
+TARGETS += filesystems/open_tree_ns
 TARGETS += filesystems/overlayfs
 TARGETS += filesystems/statmount
 TARGETS += filesystems/mount-notify
@@ -47,6 +50,7 @@ TARGETS += filesystems/empty_mntns
 TARGETS += filesystems/fsmount_ns
 TARGETS += filesystems/fscontext_ns
 TARGETS += filesystems/mntns_cleanup
+TARGETS += filesystems/xattr
 TARGETS += firmware
 TARGETS += fpu
 TARGETS += ftrace
@@ -103,7 +107,6 @@ TARGETS += prctl
 TARGETS += proc
 TARGETS += pstore
 TARGETS += ptrace
-TARGETS += openat2
 TARGETS += rdma
 TARGETS += resctrl
 TARGETS += riscv
_

Re: [PATCH] selftests/filesystems: fix missing and stale TARGETS entries

[Christian Brauner]

On Wed, Sep 02, 2026 at 07:17:20PM -0700, Andrew Morton wrote:
> On Mon, 31 Aug 2026 15:16:45 +0530 Disha Goel <disgoel@linux.ibm.com> wrote:
> 
> > Gentle ping — is this patch merged or queued for a future merge window.
> > 
> 
> I can help with that ;)

No, that's already picked up in the vfs tree where it belongs.