From: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Shuah Khan <shuah@kernel.org>, Thomas Gleixner <tglx@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Subject: [PATCH v2 3/8] selftests: vDSO: vdso_test_abi: Use types from vdso_types.h
Date: Thu, 03 Sep 2026 09:38:15 +0200 [thread overview]
Message-ID: <20260903-vdso-test-types-v2-3-1eec04eb3658@linutronix.de> (raw)
In-Reply-To: <20260903-vdso-test-types-v2-0-1eec04eb3658@linutronix.de>
The libc types are not necessarily compatible with the vDSO functions.
Use the dedicated types from vdso_types.h instead.
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
tools/testing/selftests/vDSO/vdso_test_abi.c | 35 +++++++++-------------------
1 file changed, 11 insertions(+), 24 deletions(-)
diff --git a/tools/testing/selftests/vDSO/vdso_test_abi.c b/tools/testing/selftests/vDSO/vdso_test_abi.c
index b162a4ba9c4f..b7590a727f06 100644
--- a/tools/testing/selftests/vDSO/vdso_test_abi.c
+++ b/tools/testing/selftests/vDSO/vdso_test_abi.c
@@ -11,9 +11,7 @@
#include <stdint.h>
#include <elf.h>
#include <stdio.h>
-#include <time.h>
#include <sys/auxv.h>
-#include <sys/time.h>
#define _GNU_SOURCE
#include <unistd.h>
#include <sys/syscall.h>
@@ -21,24 +19,12 @@
#include "kselftest.h"
#include "vdso_config.h"
#include "vdso_call.h"
+#include "vdso_types.h"
#include "parse_vdso.h"
static const char *version;
static const char **name;
-/* The same as struct __kernel_timespec */
-struct vdso_timespec64 {
- uint64_t tv_sec;
- uint64_t tv_nsec;
-};
-
-typedef long (*vdso_gettimeofday_t)(struct timeval *tv, struct timezone *tz);
-typedef long (*vdso_clock_gettime_t)(clockid_t clk_id, struct timespec *ts);
-typedef long (*vdso_clock_gettime64_t)(clockid_t clk_id, struct vdso_timespec64 *ts);
-typedef long (*vdso_clock_getres_t)(clockid_t clk_id, struct timespec *ts);
-typedef long (*vdso_clock_getres_time64_t)(clockid_t clk_id, struct vdso_timespec64 *ts);
-typedef time_t (*vdso_time_t)(time_t *t);
-
static const char * const vdso_clock_name[] = {
[CLOCK_REALTIME] = "CLOCK_REALTIME",
[CLOCK_MONOTONIC] = "CLOCK_MONOTONIC",
@@ -66,7 +52,7 @@ static void vdso_test_gettimeofday(void)
return;
}
- struct timeval tv;
+ struct __kernel_old_timeval tv;
long ret = VDSO_CALL(vdso_gettimeofday, 2, &tv, 0);
if (ret == 0) {
@@ -78,7 +64,7 @@ static void vdso_test_gettimeofday(void)
}
}
-static void vdso_test_clock_gettime64(clockid_t clk_id)
+static void vdso_test_clock_gettime64(__kernel_clockid_t clk_id)
{
/* Find clock_gettime64. */
vdso_clock_gettime64_t vdso_clock_gettime64 =
@@ -91,7 +77,7 @@ static void vdso_test_clock_gettime64(clockid_t clk_id)
return;
}
- struct vdso_timespec64 ts;
+ struct __kernel_timespec ts;
long ret = VDSO_CALL(vdso_clock_gettime64, 2, clk_id, &ts);
if (ret == 0) {
@@ -105,7 +91,7 @@ static void vdso_test_clock_gettime64(clockid_t clk_id)
}
}
-static void vdso_test_clock_gettime(clockid_t clk_id)
+static void vdso_test_clock_gettime(__kernel_clockid_t clk_id)
{
/* Find clock_gettime. */
vdso_clock_gettime_t vdso_clock_gettime =
@@ -118,7 +104,7 @@ static void vdso_test_clock_gettime(clockid_t clk_id)
return;
}
- struct timespec ts;
+ struct __kernel_old_timespec ts;
long ret = VDSO_CALL(vdso_clock_gettime, 2, clk_id, &ts);
if (ret == 0) {
@@ -155,7 +141,7 @@ static void vdso_test_time(void)
}
}
-static void vdso_test_clock_getres(clockid_t clk_id)
+static void vdso_test_clock_getres(__kernel_clockid_t clk_id)
{
int clock_getres_fail = 0;
@@ -170,7 +156,8 @@ static void vdso_test_clock_getres(clockid_t clk_id)
return;
}
- struct timespec ts, sys_ts;
+ struct __kernel_old_timespec ts;
+ struct timespec sys_ts;
long ret = VDSO_CALL(vdso_clock_getres, 2, clk_id, &ts);
if (ret == 0) {
@@ -213,7 +200,7 @@ static void vdso_test_clock_getres_time64(clockid_t clk_id)
return;
}
- struct vdso_timespec64 ts, sys_ts;
+ struct __kernel_timespec ts, sys_ts;
long ret = VDSO_CALL(vdso_clock_getres_time64, 2, clk_id, &ts);
if (ret == 0) {
@@ -250,7 +237,7 @@ static void vdso_test_clock_getres_time64(clockid_t clk_id)
* This function calls vdso_test_clock_gettime and vdso_test_clock_getres
* with different values for clock_id.
*/
-static inline void vdso_test_clock(clockid_t clock_id)
+static inline void vdso_test_clock(__kernel_clockid_t clock_id)
{
ksft_print_msg("clock_id: %s\n", vdso_clock_name[clock_id]);
--
2.55.0
next prev parent reply other threads:[~2026-09-03 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 7:38 [PATCH v2 0/8] selftests: vDSO: Stop using libc types for vDSO calls Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 1/8] selftests: vDSO: Introduce vdso_types.h Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 2/8] selftests: vDSO: Introduce vdso_syscalls.h Thomas Weißschuh
2026-09-03 7:38 ` Thomas Weißschuh [this message]
2026-09-03 7:38 ` [PATCH v2 4/8] selftests: vDSO: vdso_test_abi: Use system call wrappers from vdso_syscalls.h Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 5/8] selftests: vDSO: vdso_test_gettimeofday: Use types from vdso_types.h Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 6/8] selftests: vDSO: vdso_test_correctness: Make ts_leq() and tv_leq() more generic Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 7/8] selftests: vDSO: vdso_test_correctness: Use types from vdso_types.h Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 8/8] selftests: vDSO: vdso_test_correctness: Use system call wrappers from vdso_syscalls.h Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903-vdso-test-types-v2-3-1eec04eb3658@linutronix.de \
--to=thomas.weissschuh@linutronix.de \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®