From: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Shuah Khan <shuah@kernel.org>, Thomas Gleixner <tglx@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Subject: [PATCH v2 7/8] selftests: vDSO: vdso_test_correctness: Use types from vdso_types.h
Date: Thu, 03 Sep 2026 09:38:19 +0200 [thread overview]
Message-ID: <20260903-vdso-test-types-v2-7-1eec04eb3658@linutronix.de> (raw)
In-Reply-To: <20260903-vdso-test-types-v2-0-1eec04eb3658@linutronix.de>
The libc types are not necessarily compatible with the vDSO functions.
Use the dedicated types from vdso_types.h instead.
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
.../testing/selftests/vDSO/vdso_test_correctness.c | 45 ++++++++--------------
1 file changed, 15 insertions(+), 30 deletions(-)
diff --git a/tools/testing/selftests/vDSO/vdso_test_correctness.c b/tools/testing/selftests/vDSO/vdso_test_correctness.c
index 537e0030aa16..83cb408c5947 100644
--- a/tools/testing/selftests/vDSO/vdso_test_correctness.c
+++ b/tools/testing/selftests/vDSO/vdso_test_correctness.c
@@ -7,7 +7,6 @@
#define _GNU_SOURCE
#include <stdio.h>
-#include <sys/time.h>
#include <time.h>
#include <stdlib.h>
#include <unistd.h>
@@ -22,6 +21,7 @@
#include "parse_vdso.h"
#include "vdso_config.h"
#include "vdso_call.h"
+#include "vdso_types.h"
#include "kselftest.h"
static const char *version;
@@ -31,33 +31,15 @@ static const char **name;
#define __NR_clock_gettime64 403
#endif
-#ifndef __kernel_timespec
-struct __kernel_timespec {
- long long tv_sec;
- long long tv_nsec;
-};
-#endif
-
/* max length of lines in /proc/self/maps - anything longer is skipped here */
#define MAPS_LINE_LEN 128
int nerrs = 0;
-typedef int (*vgettime_t)(clockid_t, struct timespec *);
-
-vgettime_t vdso_clock_gettime;
-
-typedef int (*vgettime64_t)(clockid_t, struct __kernel_timespec *);
-
-vgettime64_t vdso_clock_gettime64;
-
-typedef long (*vgtod_t)(struct timeval *tv, struct timezone *tz);
-
-vgtod_t vdso_gettimeofday;
-
-typedef time_t (*vtime_t)(__kernel_time_t *tloc);
-
-vtime_t vdso_time;
+vdso_clock_gettime_t vdso_clock_gettime;
+vdso_clock_gettime64_t vdso_clock_gettime64;
+vdso_gettimeofday_t vdso_gettimeofday;
+vdso_time_t vdso_time;
typedef long (*getcpu_t)(unsigned *, unsigned *, void *);
@@ -123,21 +105,21 @@ static void fill_function_pointers(void)
vgetcpu = (getcpu_t) vsyscall_getcpu();
- vdso_clock_gettime = (vgettime_t)vdso_sym(version, name[1]);
+ vdso_clock_gettime = (vdso_clock_gettime_t)vdso_sym(version, name[1]);
if (!vdso_clock_gettime)
printf("Warning: failed to find clock_gettime in vDSO\n");
#if defined(VDSO_32BIT)
- vdso_clock_gettime64 = (vgettime64_t)vdso_sym(version, name[5]);
+ vdso_clock_gettime64 = (vdso_clock_gettime64_t)vdso_sym(version, name[5]);
if (!vdso_clock_gettime64)
printf("Warning: failed to find clock_gettime64 in vDSO\n");
#endif
- vdso_gettimeofday = (vgtod_t)vdso_sym(version, name[0]);
+ vdso_gettimeofday = (vdso_gettimeofday_t)vdso_sym(version, name[0]);
if (!vdso_gettimeofday)
printf("Warning: failed to find gettimeofday in vDSO\n");
- vdso_time = (vtime_t)vdso_sym(version, name[2]);
+ vdso_time = (vdso_time_t)vdso_sym(version, name[2]);
if (!vdso_time)
printf("Warning: failed to find time in vDSO\n");
@@ -265,7 +247,8 @@ static char const * const clocknames[] = {
static void test_one_clock_gettime(int clock, const char *name)
{
- struct timespec start, vdso, end;
+ struct __kernel_old_timespec vdso;
+ struct timespec start, end;
int vdso_ret, end_ret;
printf("[RUN]\tTesting clock_gettime for clock %s (%d)...\n", name, clock);
@@ -389,8 +372,10 @@ static void test_clock_gettime64(void)
static void test_gettimeofday(void)
{
- struct timeval start, vdso, end;
- struct timezone sys_tz, vdso_tz;
+ struct __kernel_old_timeval vdso;
+ struct kernel_timezone vdso_tz;
+ struct timeval start, end;
+ struct timezone sys_tz;
int vdso_ret, end_ret;
if (!vdso_gettimeofday)
--
2.55.0
next prev parent reply other threads:[~2026-09-03 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 7:38 [PATCH v2 0/8] selftests: vDSO: Stop using libc types for vDSO calls Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 1/8] selftests: vDSO: Introduce vdso_types.h Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 2/8] selftests: vDSO: Introduce vdso_syscalls.h Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 3/8] selftests: vDSO: vdso_test_abi: Use types from vdso_types.h Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 4/8] selftests: vDSO: vdso_test_abi: Use system call wrappers from vdso_syscalls.h Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 5/8] selftests: vDSO: vdso_test_gettimeofday: Use types from vdso_types.h Thomas Weißschuh
2026-09-03 7:38 ` [PATCH v2 6/8] selftests: vDSO: vdso_test_correctness: Make ts_leq() and tv_leq() more generic Thomas Weißschuh
2026-09-03 7:38 ` Thomas Weißschuh [this message]
2026-09-03 7:38 ` [PATCH v2 8/8] selftests: vDSO: vdso_test_correctness: Use system call wrappers from vdso_syscalls.h Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903-vdso-test-types-v2-7-1eec04eb3658@linutronix.de \
--to=thomas.weissschuh@linutronix.de \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®