* [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
@ 2026-09-08 11:40 Joshua Crofts
2026-09-08 12:41 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Joshua Crofts @ 2026-09-08 11:40 UTC (permalink / raw)
To: Kim Seer Paller, Marilene Andrade Garcia, Jonathan Cameron,
David Lechner, Nuno Sá,
Andy Shevchenko
Cc: linux-iio, linux-kernel, stable
The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
macro.
Add the missing macro.
Fixes: 59795109fa67 ("iio: adc: max14001: New driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
drivers/iio/adc/max14001.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/max14001.c b/drivers/iio/adc/max14001.c
index 58adeac62dde..7694fbb6a9fd 100644
--- a/drivers/iio/adc/max14001.c
+++ b/drivers/iio/adc/max14001.c
@@ -366,6 +366,7 @@ static const struct spi_device_id max14001_id_table[] = {
{ .name = "max14002", .driver_data = (kernel_ulong_t)&max14002_chip_info },
{ }
};
+MODULE_DEVICE_TABLE(spi, max14001_id_table);
static const struct of_device_id max14001_of_match[] = {
{ .compatible = "adi,max14001", .data = &max14001_chip_info },
--
2.47.3
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
2026-09-08 11:40 [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro Joshua Crofts
@ 2026-09-08 12:41 ` Andy Shevchenko
2026-09-08 13:03 ` Joshua Crofts
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-09-08 12:41 UTC (permalink / raw)
To: Joshua Crofts
Cc: Kim Seer Paller, Marilene Andrade Garcia, Jonathan Cameron,
David Lechner, Nuno Sá,
Andy Shevchenko, linux-iio, linux-kernel, stable
On Tue, Sep 8, 2026 at 2:41 PM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
>
> The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
> macro.
Is this a problem?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
2026-09-08 12:41 ` Andy Shevchenko
@ 2026-09-08 13:03 ` Joshua Crofts
2026-09-08 15:08 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Joshua Crofts @ 2026-09-08 13:03 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Kim Seer Paller, Marilene Andrade Garcia, Jonathan Cameron,
David Lechner, Nuno Sá,
Andy Shevchenko, linux-iio, linux-kernel, stable
On Tue, 8 Sep 2026 15:41:23 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Tue, Sep 8, 2026 at 2:41 PM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> >
> > The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
> > macro.
>
> Is this a problem?
>
For systems using devicetree, no. For legacy systems using spi_board_info and
this stuff, yes.
If you're referring to the mark for stable then I'm fine with removing it.
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
2026-09-08 13:03 ` Joshua Crofts
@ 2026-09-08 15:08 ` Andy Shevchenko
2026-09-08 15:12 ` Joshua Crofts
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-09-08 15:08 UTC (permalink / raw)
To: Joshua Crofts
Cc: Andy Shevchenko, Kim Seer Paller, Marilene Andrade Garcia,
Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, linux-iio, linux-kernel, stable
On Tue, Sep 08, 2026 at 03:03:11PM +0200, Joshua Crofts wrote:
> On Tue, 8 Sep 2026 15:41:23 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Tue, Sep 8, 2026 at 2:41 PM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> > >
> > > The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
> > > macro.
> >
> > Is this a problem?
>
> For systems using devicetree, no. For legacy systems using spi_board_info and
> this stuff, yes.
>
> If you're referring to the mark for stable then I'm fine with removing it.
No, I'm trying to (implicitly) tell you that the commit message misses
the answer to "why?".
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro
2026-09-08 15:08 ` Andy Shevchenko
@ 2026-09-08 15:12 ` Joshua Crofts
0 siblings, 0 replies; 5+ messages in thread
From: Joshua Crofts @ 2026-09-08 15:12 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Andy Shevchenko, Kim Seer Paller, Marilene Andrade Garcia,
Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, linux-iio, linux-kernel, stable
On Tue, 8 Sep 2026 18:08:48 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Tue, Sep 08, 2026 at 03:03:11PM +0200, Joshua Crofts wrote:
> > On Tue, 8 Sep 2026 15:41:23 +0300
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > On Tue, Sep 8, 2026 at 2:41 PM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> > > >
> > > > The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
> > > > macro.
> > >
> > > Is this a problem?
> >
> > For systems using devicetree, no. For legacy systems using spi_board_info and
> > this stuff, yes.
> >
> > If you're referring to the mark for stable then I'm fine with removing it.
>
> No, I'm trying to (implicitly) tell you that the commit message misses
> the answer to "why?".
>
Oh right... Will update in v2.
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-09-08 15:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-08 11:40 [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro Joshua Crofts
2026-09-08 12:41 ` Andy Shevchenko
2026-09-08 13:03 ` Joshua Crofts
2026-09-08 15:08 ` Andy Shevchenko
2026-09-08 15:12 ` Joshua Crofts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®