[PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro

[PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro

[Joshua Crofts]

The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
macro.

Add the missing macro.

Fixes: 59795109fa67 ("iio: adc: max14001: New driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/adc/max14001.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/max14001.c b/drivers/iio/adc/max14001.c
index 58adeac62dde..7694fbb6a9fd 100644
--- a/drivers/iio/adc/max14001.c
+++ b/drivers/iio/adc/max14001.c
@@ -366,6 +366,7 @@ static const struct spi_device_id max14001_id_table[] = {
 	{ .name = "max14002", .driver_data = (kernel_ulong_t)&max14002_chip_info },
 	{ }
 };
+MODULE_DEVICE_TABLE(spi, max14001_id_table);
 
 static const struct of_device_id max14001_of_match[] = {
 	{ .compatible = "adi,max14001", .data = &max14001_chip_info },
-- 
2.47.3

Re: [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro

[Andy Shevchenko]

On Tue, Sep 8, 2026 at 2:41 PM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
>
> The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
> macro.

Is this a problem?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro

[Joshua Crofts]

On Tue, 8 Sep 2026 15:41:23 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Tue, Sep 8, 2026 at 2:41 PM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> >
> > The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
> > macro.  
> 
> Is this a problem?
> 

For systems using devicetree, no. For legacy systems using spi_board_info and
this stuff, yes.

If you're referring to the mark for stable then I'm fine with removing it.

-- 
Kind regards,
Joshua Crofts

Re: [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro

[Andy Shevchenko]

On Tue, Sep 08, 2026 at 03:03:11PM +0200, Joshua Crofts wrote:
> On Tue, 8 Sep 2026 15:41:23 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Tue, Sep 8, 2026 at 2:41 PM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> > >
> > > The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
> > > macro.  
> > 
> > Is this a problem?
> 
> For systems using devicetree, no. For legacy systems using spi_board_info and
> this stuff, yes.
> 
> If you're referring to the mark for stable then I'm fine with removing it.

No, I'm trying to (implicitly) tell you that the commit message misses
the answer to "why?".

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: adc: max14001: add missing MODULE_DEVICE_TABLE macro

[Joshua Crofts]

On Tue, 8 Sep 2026 18:08:48 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Tue, Sep 08, 2026 at 03:03:11PM +0200, Joshua Crofts wrote:
> > On Tue, 8 Sep 2026 15:41:23 +0300
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:  
> > > On Tue, Sep 8, 2026 at 2:41 PM Joshua Crofts <joshua.crofts1@gmail.com> wrote:  
> > > >
> > > > The MAX14001 has an SPI ID table, but is missing a MODULE_DEVICE_TABLE()
> > > > macro.    
> > > 
> > > Is this a problem?  
> > 
> > For systems using devicetree, no. For legacy systems using spi_board_info and
> > this stuff, yes.
> > 
> > If you're referring to the mark for stable then I'm fine with removing it.  
> 
> No, I'm trying to (implicitly) tell you that the commit message misses
> the answer to "why?".
> 

Oh right... Will update in v2.

-- 
Kind regards,
Joshua Crofts