* [PATCH RESEND] selftests/filesystems: include fcntl.h in fclog
@ 2026-09-10 9:14 Arthur Cassegrain
2026-09-10 9:39 ` Arthur Cassegrain
0 siblings, 1 reply; 2+ messages in thread
From: Arthur Cassegrain @ 2026-09-10 9:14 UTC (permalink / raw)
To: Shuah Khan; +Cc: linux-kselftest, linux-kernel, NeilBrown, Arthur Cassegrain
fclog.c uses open(), O_RDONLY, O_CLOEXEC and AT_FDCWD, but it does
not include <fcntl.h>, where they are declared or defined.
This was hidden while <sys/mount.h> pulled in <fcntl.h> indirectly.
glibc stopped providing that transitive include in [1], which exposes
the missing direct dependency.
Include <fcntl.h> explicitly so fclog.c builds with glibc 2.44
development headers.
[1] glibc -- change 419245719ccb ("include: isolate __O_CLOEXEC flag for
sys/mount.h and fcntl.h")
Link: https://sourceware.org/git/?p=glibc.git;a=commit;h=419245719ccb
Fixes: df579e471111 ("selftests/filesystems: add basic fscontext log tests")
Reported-by: NeilBrown <neilb@ownmail.net>
Closes: https://lore.kernel.org/all/178331747789.27465.4739600418387513587@noble.neil.brown.name/
Signed-off-by: Arthur Cassegrain <arthur.cassegrain@arm.com>
---
tools/testing/selftests/filesystems/fclog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/filesystems/fclog.c b/tools/testing/selftests/filesystems/fclog.c
index 551c4a0f395a..df0767a7e01d 100644
--- a/tools/testing/selftests/filesystems/fclog.c
+++ b/tools/testing/selftests/filesystems/fclog.c
@@ -6,6 +6,7 @@
#include <assert.h>
#include <errno.h>
+#include <fcntl.h>
#include <sched.h>
#include <stdio.h>
#include <stdlib.h>
---
base-commit: 0e35b9b6ec0ffcc5e23cbdec09f5c622ad532b53
change-id: 20260707-fclog-fix-include-ef30967e9359
Best regards,
--
Arthur Cassegrain <arthur.cassegrain@arm.com>
--
Arthur Cassegrain <arthur.cassegrain@arm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] selftests/filesystems: include fcntl.h in fclog
2026-09-10 9:14 [PATCH RESEND] selftests/filesystems: include fcntl.h in fclog Arthur Cassegrain
@ 2026-09-10 9:39 ` Arthur Cassegrain
0 siblings, 0 replies; 2+ messages in thread
From: Arthur Cassegrain @ 2026-09-10 9:39 UTC (permalink / raw)
To: Shuah Khan; +Cc: linux-kselftest, linux-kernel, NeilBrown, Vincent Mailhol
> fclog.c uses open(), O_RDONLY, O_CLOEXEC and AT_FDCWD, but it does
> not include <fcntl.h>, where they are declared or defined.
>
> This was hidden while <sys/mount.h> pulled in <fcntl.h> indirectly.
> glibc stopped providing that transitive include in [1], which exposes
> the missing direct dependency.
>
> Include <fcntl.h> explicitly so fclog.c builds with glibc 2.44
> development headers.
>
> [1] glibc -- change 419245719ccb ("include: isolate __O_CLOEXEC flag for
> sys/mount.h and fcntl.h")
> Link: https://sourceware.org/git/?p=glibc.git;a=commit;h=419245719ccb
>
> Fixes: df579e471111 ("selftests/filesystems: add basic fscontext log tests")
> Reported-by: NeilBrown <neilb@ownmail.net>
> Closes: https://lore.kernel.org/all/178331747789.27465.4739600418387513587@noble.neil.brown.name/
> Signed-off-by: Arthur Cassegrain <arthur.cassegrain@arm.com>
> ---
Sorry, I just realized that this fix has already been merged:
https://lore.kernel.org/all/20260710171741.837308-1-jkoolstra@xs4all.nl/
Please ignore this resend.
Thanks,
Arthur
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-10 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-10 9:14 [PATCH RESEND] selftests/filesystems: include fcntl.h in fclog Arthur Cassegrain
2026-09-10 9:39 ` Arthur Cassegrain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®