From: Zhi Wang <zhiw@nvidia.com>
To: <dakr@kernel.org>, <acourbot@nvidia.com>
Cc: <alex@shazbot.org>, <jgg@nvidia.com>, <yishaih@nvidia.com>,
<skolothumtho@nvidia.com>, <kevin.tian@intel.com>,
<airlied@gmail.com>, <simona@ffwll.ch>, <ojeda@kernel.org>,
<alex.gaynor@gmail.com>, <boqun.feng@gmail.com>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<lossin@kernel.org>, <a.hindborg@kernel.org>,
<aliceryhl@google.com>, <tmgross@umich.edu>,
<jhubbard@nvidia.com>, <ecourtney@nvidia.com>, <cjia@nvidia.com>,
<smitra@nvidia.com>, <kjaju@nvidia.com>, <alkumar@nvidia.com>,
<ankita@nvidia.com>, <aniketa@nvidia.com>, <kwankhede@nvidia.com>,
<targupta@nvidia.com>, <nova-gpu@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <zhiwang@kernel.org>,
Zhi Wang <zhiw@nvidia.com>
Subject: [PATCH v2 28/32] gpu: nova-core: vgpu: send GSP plugin configuration parameters
Date: Mon, 14 Sep 2026 10:49:03 +0300 [thread overview]
Message-ID: <20260914074907.1399629-29-zhiw@nvidia.com> (raw)
In-Reply-To: <20260914074907.1399629-1-zhiw@nvidia.com>
The GSP plugin needs the instance identity, channel allocation and host
parameters before it can serve guest requests.
Encode these parameters as an NVKV stream, prefix it with its word count
and send SETUP_CONFIG_PARAMS_AND_INIT after protocol negotiation.
Co-developed-by: Eliot Courtney <ecourtney@nvidia.com>
Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
Signed-off-by: Zhi Wang <zhiw@nvidia.com>
---
drivers/gpu/nova-core/vgpu/commands.rs | 17 +++
drivers/gpu/nova-core/vgpu/fw/commands.rs | 126 +++++++++++++++++++
drivers/gpu/nova-core/vgpu/gsp_plugin_rpc.rs | 18 +++
drivers/gpu/nova-core/vgpu/instance.rs | 20 ++-
4 files changed, 179 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/nova-core/vgpu/commands.rs b/drivers/gpu/nova-core/vgpu/commands.rs
index abc85b0365f2..2089c91b648e 100644
--- a/drivers/gpu/nova-core/vgpu/commands.rs
+++ b/drivers/gpu/nova-core/vgpu/commands.rs
@@ -160,3 +160,20 @@ pub(super) fn negotiate_plugin_version(
) -> Result {
rpc.rpc_call(dev, bar0, gfid, RpcMessage::VersionNegotiation, &[])
}
+
+/// Send an instance's encoded configuration to the GSP plugin.
+pub(super) fn send_plugin_config(
+ dev: &device::Device<device::Bound>,
+ bar0: Bar0<'_>,
+ gfid: Gfid,
+ rpc: &mut PluginRpc<'_, '_>,
+ config: &[u64],
+) -> Result {
+ rpc.rpc_call_nvkv(
+ dev,
+ bar0,
+ gfid,
+ RpcMessage::SetupConfigParamsAndInit,
+ config,
+ )
+}
diff --git a/drivers/gpu/nova-core/vgpu/fw/commands.rs b/drivers/gpu/nova-core/vgpu/fw/commands.rs
index b765d30a1d61..0386c8178962 100644
--- a/drivers/gpu/nova-core/vgpu/fw/commands.rs
+++ b/drivers/gpu/nova-core/vgpu/fw/commands.rs
@@ -32,6 +32,7 @@
#[repr(u32)]
pub(in crate::vgpu) enum RpcMessage {
VersionNegotiation = bindings::MESSAGE_NV_VGPU_CPU_RPC_MSG_VERSION_NEGOTIATION,
+ SetupConfigParamsAndInit = bindings::MESSAGE_NV_VGPU_CPU_RPC_MSG_SETUP_CONFIG_PARAMS_AND_INIT,
}
bitfield! {
@@ -259,3 +260,128 @@ pub(in crate::vgpu) struct VgpuProperties {
impl VgpuProperties {
const STRING_LEN: usize = 64;
}
+
+#[derive(Clone, Copy)]
+enum HypervisorType {
+ Unknown = 4,
+}
+
+impl From<HypervisorType> for u32 {
+ fn from(value: HypervisorType) -> Self {
+ value as u32
+ }
+}
+
+#[derive(Clone, Copy)]
+enum CpuArch {
+ Aarch64 = 1,
+ X86_64 = 2,
+}
+
+impl CpuArch {
+ fn host() -> Result<Self> {
+ if cfg!(target_arch = "x86_64") {
+ Ok(Self::X86_64)
+ } else if cfg!(target_arch = "aarch64") {
+ Ok(Self::Aarch64)
+ } else {
+ Err(EOPNOTSUPP)
+ }
+ }
+}
+
+impl From<CpuArch> for u32 {
+ fn from(value: CpuArch) -> Self {
+ value as u32
+ }
+}
+
+#[derive(Clone, Copy)]
+struct MigrationFeature(u32);
+
+impl MigrationFeature {
+ const PRESERVE_CTX_BUF: Self = Self(0x4000);
+}
+
+impl From<MigrationFeature> for u32 {
+ fn from(value: MigrationFeature) -> Self {
+ value.0
+ }
+}
+
+bitfield! {
+ struct FeatureFlags(u64) {
+ 3:3 enable_uvm => bool;
+ 5:5 vmm_migration => bool;
+ }
+}
+
+nvkv_encode! {
+ struct PluginConfigParamsRequest {
+ uuid: Key<[u8; 16], { Self::UUID_KEY }>,
+ dbdf: Key<Dbdf, { Self::DBDF_KEY }, u32>,
+ dev_inst: Key<u32, { Self::DEV_INST_KEY }>,
+ vgpu_type: Key<u32, { Self::VGPU_TYPE_KEY }>,
+ vm_pid: Key<u32, { Self::VM_PID_KEY }>,
+ swizz_id: Key<SwizzId, { Self::SWIZZ_ID_KEY }, u32>,
+ num_channels: Key<u32, { Self::NUM_CHANNELS_KEY }>,
+ num_plugin_channels: Key<u32, { Self::NUM_PLUGIN_CHANNELS_KEY }>,
+ vmm_cap: Key<u32, { Self::VMM_CAP_KEY }>,
+ migration_feature: Key<MigrationFeature, { Self::MIGRATION_FEATURE_KEY }, u32>,
+ hypervisor_type: Key<HypervisorType, { Self::HYPERVISOR_TYPE_KEY }, u32>,
+ cpu_arch: Key<CpuArch, { Self::CPU_ARCH_KEY }, u32>,
+ page_size: Key<u64, { Self::PAGE_SIZE_KEY }>,
+ feature_flags: Key<FeatureFlags, { Self::FEATURE_FLAGS_KEY }, u64>,
+ }
+}
+
+impl PluginConfigParamsRequest {
+ const UUID_KEY: KeyId = 0x0001;
+ const DBDF_KEY: KeyId = 0x0002;
+ const DEV_INST_KEY: KeyId = 0x0004;
+ const VGPU_TYPE_KEY: KeyId = 0x0005;
+ const VM_PID_KEY: KeyId = 0x0006;
+ const SWIZZ_ID_KEY: KeyId = 0x0010;
+ const NUM_CHANNELS_KEY: KeyId = 0x0011;
+ const NUM_PLUGIN_CHANNELS_KEY: KeyId = 0x0012;
+ const VMM_CAP_KEY: KeyId = 0x0020;
+ const MIGRATION_FEATURE_KEY: KeyId = 0x0021;
+ const HYPERVISOR_TYPE_KEY: KeyId = 0x0022;
+ const CPU_ARCH_KEY: KeyId = 0x0023;
+ const PAGE_SIZE_KEY: KeyId = 0x0024;
+ const FEATURE_FLAGS_KEY: KeyId = 0x0030;
+}
+
+/// Encodes plugin configuration parameters using the typed NVKV schema.
+pub(in crate::vgpu) fn encode_plugin_config_params(
+ uuid: [u8; 16],
+ dbdf: Dbdf,
+ vgpu_type: u32,
+ vm_pid: u32,
+ num_channels: u32,
+ num_plugin_channels: u32,
+) -> Result<EncodedStream> {
+ let request = PluginConfigParamsRequest {
+ uuid: uuid.into(),
+ dbdf: dbdf.into(),
+ dev_inst: 0.into(),
+ vgpu_type: vgpu_type.into(),
+ vm_pid: vm_pid.into(),
+ swizz_id: SwizzId::WHOLE_GPU.into(),
+ num_channels: num_channels.into(),
+ num_plugin_channels: num_plugin_channels.into(),
+ vmm_cap: 0.into(),
+ migration_feature: MigrationFeature::PRESERVE_CTX_BUF.into(),
+ hypervisor_type: HypervisorType::Unknown.into(),
+ cpu_arch: CpuArch::host()?.into(),
+ page_size: u64::try_from(kernel::page::PAGE_SIZE)?.into(),
+ feature_flags: FeatureFlags::zeroed()
+ .with_enable_uvm(false)
+ .with_vmm_migration(true)
+ .into(),
+ };
+
+ let mut encoder = Encoder::new();
+ request.encode(&mut encoder)?;
+ Ok(encoder.finish())
+}
diff --git a/drivers/gpu/nova-core/vgpu/gsp_plugin_rpc.rs b/drivers/gpu/nova-core/vgpu/gsp_plugin_rpc.rs
index ff009f241c32..2b9bccd8acb5 100644
--- a/drivers/gpu/nova-core/vgpu/gsp_plugin_rpc.rs
+++ b/drivers/gpu/nova-core/vgpu/gsp_plugin_rpc.rs
@@ -26,6 +26,7 @@
Instant,
Monotonic, //
},
+ transmute::AsBytes, //
};
use crate::{
@@ -103,6 +104,23 @@ pub(super) fn rpc_call(
self.wait_response(dev, sequence)
}
+ /// Send an NVKV stream prefixed by its word count.
+ pub(super) fn rpc_call_nvkv(
+ &mut self,
+ dev: &device::Device<device::Bound>,
+ bar0: Bar0<'_>,
+ gfid: Gfid,
+ message_type: RpcMessage,
+ encoded: &[u64],
+ ) -> Result {
+ let word_count = u64::try_from(encoded.len()).map_err(|_| EOVERFLOW)?;
+ let mut payload = KVec::new();
+ payload.extend_from_slice(&word_count.to_le_bytes(), GFP_KERNEL)?;
+ payload.extend_from_slice(AsBytes::as_bytes(encoded), GFP_KERNEL)?;
+
+ self.rpc_call(dev, bar0, gfid, message_type, &payload)
+ }
+
fn wait_response(&self, dev: &device::Device<device::Bound>, expected_sequence: u32) -> Result {
let start = Instant::<Monotonic>::now();
let timeout = Delta::from_secs(120);
diff --git a/drivers/gpu/nova-core/vgpu/instance.rs b/drivers/gpu/nova-core/vgpu/instance.rs
index a65b95d11f88..c3ec24f48682 100644
--- a/drivers/gpu/nova-core/vgpu/instance.rs
+++ b/drivers/gpu/nova-core/vgpu/instance.rs
@@ -46,12 +46,14 @@
query_vgpu_properties,
send_bootload,
send_cleanup,
+ send_plugin_config,
send_shutdown,
Dbdf,
VgpuProperties, //
};
use super::fw::commands::{
+ encode_plugin_config_params,
encode_vgpu_bootload,
ChannelMapEntry, //
};
@@ -195,6 +197,19 @@ fn bootload(
Ok(())
}
+ fn configure_plugin(&mut self, dev: &device::Device<device::Bound>, bar0: Bar0<'_>) -> Result {
+ let config = encode_plugin_config_params(
+ [0; 16],
+ self.dbdf,
+ self.vgpu_type.vgpu_type_id(),
+ self.vm_pid,
+ u32::try_from(self.chids.len()).map_err(|_| EOVERFLOW)?,
+ self.num_plugin_channels,
+ )?;
+
+ send_plugin_config(dev, bar0, self.gfid, &mut self.plugin_rpc, &config)
+ }
+
/// Stop the plugin when firmware may own instance resources.
fn shutdown(&mut self, dev: &device::Device<device::Bound>, cmdq: &Cmdq<'_>) -> Result {
if self.needs_teardown {
@@ -357,7 +372,7 @@ pub(super) fn allocate_instance(
}
}
- /// Boot the GSP plugin and negotiate its RPC version.
+ /// Boot and configure the GSP plugin for a registered instance.
pub(super) fn activate_instance(
&mut self,
dev: &device::Device<device::Bound>,
@@ -374,7 +389,8 @@ pub(super) fn activate_instance(
instance.bootload(dev, cmdq, fifo_engine_list)?;
instance.plugin_rpc.init_rpc()?;
- negotiate_plugin_version(dev, bar0, gfid, &mut instance.plugin_rpc)
+ negotiate_plugin_version(dev, bar0, gfid, &mut instance.plugin_rpc)?;
+ instance.configure_plugin(dev, bar0)
}
/// Stop the plugin and release the instance's firmware and host resources.
next prev parent reply other threads:[~2026-09-14 7:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 7:48 [PATCH v2 00/32] Introduce NVIDIA vGPU manager Zhi Wang
2026-09-14 7:48 ` [PATCH v2 01/32] gpu: nova-core: gsp: pass boot context through setup helpers Zhi Wang
2026-09-14 7:48 ` [PATCH v2 02/32] gpu: nova-core: gsp: decouple boot context from VgpuManager Zhi Wang
2026-09-14 7:48 ` [PATCH v2 03/32] gpu: nova-core: vgpu: detect boot state independently Zhi Wang
2026-09-14 7:48 ` [PATCH v2 04/32] gpu: nova-core: gpu: add a channel ID pool for vGPU Zhi Wang
2026-09-14 7:48 ` [PATCH v2 05/32] gpu: nova-core: gsp: expose the VMMU segment size Zhi Wang
2026-09-14 7:48 ` [PATCH v2 06/32] gpu: nova-core: gsp: decode the FIFO engine table Zhi Wang
2026-09-14 7:48 ` [PATCH v2 07/32] gpu: nova-core: vgpu: initialize runtime parameters after GSP boot Zhi Wang
2026-09-14 7:48 ` [PATCH v2 08/32] gpu: nova-core: vgpu: reserve the 48-VM WPR2 heap Zhi Wang
2026-09-14 7:48 ` [PATCH v2 09/32] gpu: nova-core: mm: borrow BarUser for temporary BAR1 access Zhi Wang
2026-09-14 7:48 ` [PATCH v2 10/32] gpu: nova-core: mm: add VramBlock Zhi Wang
2026-09-14 7:48 ` [PATCH v2 11/32] gpu: nova-core: mm: add VramRegion Zhi Wang
2026-09-14 7:48 ` [PATCH v2 12/32] gpu: nova-core: mm: add BarMapping Zhi Wang
2026-09-14 7:48 ` [PATCH v2 13/32] gpu: nova-core: gsp: dispatch RM RPC messages during GMC receive Zhi Wang
2026-09-14 7:48 ` [PATCH v2 14/32] gpu: nova-core: gsp: add synchronous GMC transactions Zhi Wang
2026-09-14 7:48 ` [PATCH v2 15/32] gpu: nova-core: gsp: add status-only " Zhi Wang
2026-09-14 7:48 ` [PATCH v2 16/32] gpu: nova-core: gsp: wait for GMC completion events Zhi Wang
2026-09-14 7:48 ` [PATCH v2 17/32] gpu: nova-core: vgpu: add r000 plugin bindings Zhi Wang
2026-09-14 7:48 ` [PATCH v2 18/32] gpu: nova-core: vgpu: add VRAM slot allocator Zhi Wang
2026-09-14 7:48 ` [PATCH v2 19/32] gpu: nova-core: gsp: factor out NVKV payload conversion Zhi Wang
2026-09-14 7:48 ` [PATCH v2 20/32] gpu: nova-core: vgpu: query VF assignments and properties Zhi Wang
2026-09-14 7:48 ` [PATCH v2 21/32] gpu: nova-core: vgpu: add instance create/destroy Zhi Wang
2026-09-14 7:48 ` [PATCH v2 22/32] gpu: nova-core: vgpu: encode vGPU boot requests Zhi Wang
2026-09-14 7:48 ` [PATCH v2 23/32] gpu: nova-core: vgpu: add GSP plugin communication buffers Zhi Wang
2026-09-14 7:48 ` [PATCH v2 24/32] gpu: nova-core: vgpu: add instance boot and shutdown Zhi Wang
2026-09-14 7:49 ` [PATCH v2 25/32] gpu: nova-core: vgpu: initialize GSP plugin RPC buffers Zhi Wang
2026-09-14 7:49 ` [PATCH v2 26/32] gpu: nova-core: vgpu: add GSP plugin RPC transactions Zhi Wang
2026-09-14 7:49 ` [PATCH v2 27/32] gpu: nova-core: vgpu: negotiate the GSP plugin RPC version Zhi Wang
2026-09-14 7:49 ` Zhi Wang [this message]
2026-09-14 7:49 ` [PATCH v2 29/32] gpu: nova-core: vgpu: update the GSP plugin BME state Zhi Wang
2026-09-14 7:49 ` [PATCH v2 30/32] gpu: nova-core: vgpu: scrub guest VRAM with CeUtils Zhi Wang
2026-09-14 7:49 ` [PATCH v2 31/32] gpu: nova-core: add build ID headers to debugfs log buffer dumps Zhi Wang
2026-09-14 7:49 ` [PATCH v2 32/32] gpu: nova-core: vgpu: export plugin log buffers via debugfs Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914074907.1399629-29-zhiw@nvidia.com \
--to=zhiw@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=alex@shazbot.org \
--cc=aliceryhl@google.com \
--cc=alkumar@nvidia.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=cjia@nvidia.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kjaju@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=simona@ffwll.ch \
--cc=skolothumtho@nvidia.com \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=tmgross@umich.edu \
--cc=yishaih@nvidia.com \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®