* [PATCH v7 1/4] mfd: intel-lpss: Remove redundant DebugFS error check
2026-09-16 16:23 [PATCH v7 0/4] mfd: intel-lpss: Clean up and modernize DebugFS usage Maria Lisina
@ 2026-09-16 16:23 ` Maria Lisina
2026-09-16 16:23 ` [PATCH v7 2/4] mfd: intel-lpss: Use plain octal values for file permissions Maria Lisina
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Maria Lisina @ 2026-09-16 16:23 UTC (permalink / raw)
To: Andy Shevchenko, Lee Jones; +Cc: mfd, linux-kernel, Maria Lisina
The DebugFS API is designed to handle errors gracefully.
Any explicit checking on return values is considered an anti-pattern.
This patch removes unnecessary error checking and converts
intel_lpss_debugfs_add() into a void function.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Maria Lisina <sekoohaka.sarisan@gmail.com>
---
drivers/mfd/intel-lpss.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 63d6694f71457b2e09d238af0a9bfb897a169a64..b6958e99cf54d3c8eeca1ba38055a9389678f6c3 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -142,13 +142,11 @@ static void intel_lpss_cache_ltr(struct intel_lpss *lpss)
lpss->idle_ltr = readl(lpss->priv + LPSS_PRIV_IDLELTR);
}
-static int intel_lpss_debugfs_add(struct intel_lpss *lpss)
+static void intel_lpss_debugfs_add(struct intel_lpss *lpss)
{
struct dentry *dir;
dir = debugfs_create_dir(dev_name(lpss->dev), intel_lpss_debugfs);
- if (IS_ERR(dir))
- return PTR_ERR(dir);
/* Cache the values into lpss structure */
intel_lpss_cache_ltr(lpss);
@@ -158,7 +156,6 @@ static int intel_lpss_debugfs_add(struct intel_lpss *lpss)
debugfs_create_x32("idle_ltr", S_IRUGO, dir, &lpss->idle_ltr);
lpss->debugfs = dir;
- return 0;
}
static void intel_lpss_debugfs_remove(struct intel_lpss *lpss)
@@ -432,10 +429,7 @@ int intel_lpss_probe(struct device *dev,
goto err_clk_register;
intel_lpss_ltr_expose(lpss);
-
- ret = intel_lpss_debugfs_add(lpss);
- if (ret)
- dev_warn(dev, "Failed to create debugfs entries\n");
+ intel_lpss_debugfs_add(lpss);
if (intel_lpss_has_idma(lpss)) {
ret = mfd_add_devices(dev, lpss->devid, &intel_lpss_idma64_cell,
--
2.47.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v7 2/4] mfd: intel-lpss: Use plain octal values for file permissions
2026-09-16 16:23 [PATCH v7 0/4] mfd: intel-lpss: Clean up and modernize DebugFS usage Maria Lisina
2026-09-16 16:23 ` [PATCH v7 1/4] mfd: intel-lpss: Remove redundant DebugFS error check Maria Lisina
@ 2026-09-16 16:23 ` Maria Lisina
2026-09-16 16:23 ` [PATCH v7 3/4] mfd: intel-lpss: Remove extra DebugFS dentry Maria Lisina
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Maria Lisina @ 2026-09-16 16:23 UTC (permalink / raw)
To: Andy Shevchenko, Lee Jones; +Cc: mfd, linux-kernel, Maria Lisina
S_IRUGO macro is obsoleted and not recommended to use,
therefore replace it with plain octal values.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Maria Lisina <sekoohaka.sarisan@gmail.com>
---
drivers/mfd/intel-lpss.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index b6958e99cf54d3c8eeca1ba38055a9389678f6c3..190de88d146aae9418566adf36a47d11afa90b2a 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -151,9 +151,9 @@ static void intel_lpss_debugfs_add(struct intel_lpss *lpss)
/* Cache the values into lpss structure */
intel_lpss_cache_ltr(lpss);
- debugfs_create_x32("capabilities", S_IRUGO, dir, &lpss->caps);
- debugfs_create_x32("active_ltr", S_IRUGO, dir, &lpss->active_ltr);
- debugfs_create_x32("idle_ltr", S_IRUGO, dir, &lpss->idle_ltr);
+ debugfs_create_x32("capabilities", 0444, dir, &lpss->caps);
+ debugfs_create_x32("active_ltr", 0444, dir, &lpss->active_ltr);
+ debugfs_create_x32("idle_ltr", 0444, dir, &lpss->idle_ltr);
lpss->debugfs = dir;
}
--
2.47.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v7 3/4] mfd: intel-lpss: Remove extra DebugFS dentry
2026-09-16 16:23 [PATCH v7 0/4] mfd: intel-lpss: Clean up and modernize DebugFS usage Maria Lisina
2026-09-16 16:23 ` [PATCH v7 1/4] mfd: intel-lpss: Remove redundant DebugFS error check Maria Lisina
2026-09-16 16:23 ` [PATCH v7 2/4] mfd: intel-lpss: Use plain octal values for file permissions Maria Lisina
@ 2026-09-16 16:23 ` Maria Lisina
2026-09-16 16:23 ` [PATCH v7 4/4] mfd: intel-lpss: Switch to debugfs_remove() Maria Lisina
2026-09-17 5:34 ` [PATCH v7 0/4] mfd: intel-lpss: Clean up and modernize DebugFS usage Andy Shevchenko
4 siblings, 0 replies; 6+ messages in thread
From: Maria Lisina @ 2026-09-16 16:23 UTC (permalink / raw)
To: Andy Shevchenko, Lee Jones; +Cc: mfd, linux-kernel, Maria Lisina
There is no point to keep the variable dir just to assing
lpss->debugfs to it later, just use lpss->debugfs directly.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Maria Lisina <sekoohaka.sarisan@gmail.com>
---
drivers/mfd/intel-lpss.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 190de88d146aae9418566adf36a47d11afa90b2a..170cc004a9449cb352e3e1ef22ceb35759368ff4 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -144,18 +144,14 @@ static void intel_lpss_cache_ltr(struct intel_lpss *lpss)
static void intel_lpss_debugfs_add(struct intel_lpss *lpss)
{
- struct dentry *dir;
-
- dir = debugfs_create_dir(dev_name(lpss->dev), intel_lpss_debugfs);
+ lpss->debugfs = debugfs_create_dir(dev_name(lpss->dev), intel_lpss_debugfs);
/* Cache the values into lpss structure */
intel_lpss_cache_ltr(lpss);
- debugfs_create_x32("capabilities", 0444, dir, &lpss->caps);
- debugfs_create_x32("active_ltr", 0444, dir, &lpss->active_ltr);
- debugfs_create_x32("idle_ltr", 0444, dir, &lpss->idle_ltr);
-
- lpss->debugfs = dir;
+ debugfs_create_x32("capabilities", 0444, lpss->debugfs, &lpss->caps);
+ debugfs_create_x32("active_ltr", 0444, lpss->debugfs, &lpss->active_ltr);
+ debugfs_create_x32("idle_ltr", 0444, lpss->debugfs, &lpss->idle_ltr);
}
static void intel_lpss_debugfs_remove(struct intel_lpss *lpss)
--
2.47.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v7 4/4] mfd: intel-lpss: Switch to debugfs_remove()
2026-09-16 16:23 [PATCH v7 0/4] mfd: intel-lpss: Clean up and modernize DebugFS usage Maria Lisina
` (2 preceding siblings ...)
2026-09-16 16:23 ` [PATCH v7 3/4] mfd: intel-lpss: Remove extra DebugFS dentry Maria Lisina
@ 2026-09-16 16:23 ` Maria Lisina
2026-09-17 5:34 ` [PATCH v7 0/4] mfd: intel-lpss: Clean up and modernize DebugFS usage Andy Shevchenko
4 siblings, 0 replies; 6+ messages in thread
From: Maria Lisina @ 2026-09-16 16:23 UTC (permalink / raw)
To: Andy Shevchenko, Lee Jones; +Cc: mfd, linux-kernel, Maria Lisina
debugfs_remove_recursive() is deprecated and has become
an alias to debugfs_remove(), replace it with the direct
debugfs_remove() call instead.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Maria Lisina <sekoohaka.sarisan@gmail.com>
---
drivers/mfd/intel-lpss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 170cc004a9449cb352e3e1ef22ceb35759368ff4..29f30ef0da9902a9353eb9c12f6121b4a7ed8c6e 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -156,7 +156,7 @@ static void intel_lpss_debugfs_add(struct intel_lpss *lpss)
static void intel_lpss_debugfs_remove(struct intel_lpss *lpss)
{
- debugfs_remove_recursive(lpss->debugfs);
+ debugfs_remove(lpss->debugfs);
}
static void intel_lpss_ltr_set(struct device *dev, s32 val)
--
2.47.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v7 0/4] mfd: intel-lpss: Clean up and modernize DebugFS usage
2026-09-16 16:23 [PATCH v7 0/4] mfd: intel-lpss: Clean up and modernize DebugFS usage Maria Lisina
` (3 preceding siblings ...)
2026-09-16 16:23 ` [PATCH v7 4/4] mfd: intel-lpss: Switch to debugfs_remove() Maria Lisina
@ 2026-09-17 5:34 ` Andy Shevchenko
4 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2026-09-17 5:34 UTC (permalink / raw)
To: Maria Lisina; +Cc: Lee Jones, mfd, linux-kernel
On Wed, Sep 16, 2026 at 09:23:46PM +0500, Maria Lisina wrote:
> This series cleans up DebugFS code, modernizes it by replacing
> obsoleted macros and removes redundant error checking.
> Signed-off-by: Maria Lisina <sekoohaka.sarisan@gmail.com>
> ---
> Changes in v7:
> - The final corrections after review.
> - Link to v6: https://lore.kernel.org/r/20260916-intel-lpss-debugfs-v6-0-5c118ac430ed@gmail.com
Great! Thanks for the clean up mini-series!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread