From: Krzysztof Kozlowski <krzk@kernel.org>
To: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"André Apitzsch" <git@apitzsch.eu>,
"Luca Weiss" <luca.weiss@fairphone.com>,
"Daniel Scally" <dan.scally@ideasonboard.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: media: i2c: dw9800: Redocument DW9800K
Date: Wed, 16 Sep 2026 11:06:08 +0200 [thread overview]
Message-ID: <20260916-meek-qualified-penguin-fd8cea@quoll> (raw)
In-Reply-To: <20260914-b4-dw9800k_cleanup-v2-1-6553273aaa33@fairphone.com>
On Mon, Sep 14, 2026 at 12:25:56PM +0200, Griffin Kroah-Hartman wrote:
> The DW9800K's properties are too different to justify sharing the same
> bindings file as the dw9719, Create a separate bindings documentation
> for the Dongwoon Anatech DW9800K with it's updated properties.
>
> More specifically:
>
> The DW9800K did not share the SAC1 and SAC6 modes
> that the DW9719 used.
>
> The DW9800K does not actually have a register that matches the property
> description of vcm-prescale, instead the description of the clock-presc
> in the DW9768 is much more applicable to the functionality required
> according to the DW9800K datasheet.
I don't get why it does not match. You have exactly the same first part
of the description, look:
dw9719:
Indication of VCM switching frequency dividing rate select
Your code:
Indication of VCM internal clock dividing rate select,
Both are dividing the VCM clock rate, no?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-16 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 10:25 [PATCH v2 0/3] Dongwoon DW9800K update patchset Griffin Kroah-Hartman
2026-09-14 10:25 ` [PATCH v2 1/3] dt-bindings: media: i2c: dw9800: Redocument DW9800K Griffin Kroah-Hartman
2026-09-16 9:06 ` Krzysztof Kozlowski [this message]
2026-10-01 13:17 ` Griffin Kroah-Hartman
2026-10-02 9:08 ` Krzysztof Kozlowski
2026-09-14 10:25 ` [PATCH v2 2/3] media: i2c: dw9719: Update DW9800K driver Griffin Kroah-Hartman
2026-09-14 10:25 ` [PATCH v2 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: Fix DW9800K support Griffin Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916-meek-qualified-penguin-fd8cea@quoll \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=git@apitzsch.eu \
--cc=griffin.kroah@fairphone.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®