* [PATCH] nvme: work around all -Wformat-security warnings
@ 2026-09-17 6:04 Arnd Bergmann
2026-09-17 8:14 ` Nilay Shroff
2026-09-17 19:53 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2026-09-17 6:04 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: Arnd Bergmann, Nilay Shroff, Hannes Reinecke, Maurizio Lombardi,
John Garry, Alistair Francis, Eric Biggers, linux-nvme,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The sysfs code passes two string variables into sysfs_emit(), which is safe
in this instance but causes the compiler to warn when -Wformat-security
is enabled:
host/sysfs.c: In function ‘cntrltype_show’:
host/sysfs.c:682:9: error: format not a string literal and no format arguments [-Werror=format-security]
682 | return sysfs_emit(buf, type[ctrl->cntrltype]);
Print these using a "%s" format like all other instances in the same file.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/nvme/host/sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
index 02a2490a9ed7..e1e3dcfd084b 100644
--- a/drivers/nvme/host/sysfs.c
+++ b/drivers/nvme/host/sysfs.c
@@ -679,7 +679,7 @@ static ssize_t cntrltype_show(struct device *dev,
if (ctrl->cntrltype > NVME_CTRL_ADMIN || !type[ctrl->cntrltype])
return sysfs_emit(buf, "reserved\n");
- return sysfs_emit(buf, type[ctrl->cntrltype]);
+ return sysfs_emit(buf, "%s", type[ctrl->cntrltype]);
}
static DEVICE_ATTR_RO(cntrltype);
@@ -696,7 +696,7 @@ static ssize_t dctype_show(struct device *dev,
if (ctrl->dctype > NVME_DCTYPE_CDC || !type[ctrl->dctype])
return sysfs_emit(buf, "reserved\n");
- return sysfs_emit(buf, type[ctrl->dctype]);
+ return sysfs_emit(buf, "%s", type[ctrl->dctype]);
}
static DEVICE_ATTR_RO(dctype);
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: work around all -Wformat-security warnings
2026-09-17 6:04 [PATCH] nvme: work around all -Wformat-security warnings Arnd Bergmann
@ 2026-09-17 8:14 ` Nilay Shroff
2026-09-17 19:53 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Nilay Shroff @ 2026-09-17 8:14 UTC (permalink / raw)
To: Arnd Bergmann, Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: Arnd Bergmann, Hannes Reinecke, Maurizio Lombardi, John Garry,
Alistair Francis, Eric Biggers, linux-nvme, linux-kernel
On 9/17/26 11:34 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann<arnd@arndb.de>
>
> The sysfs code passes two string variables into sysfs_emit(), which is safe
> in this instance but causes the compiler to warn when -Wformat-security
> is enabled:
>
> host/sysfs.c: In function ‘cntrltype_show’:
> host/sysfs.c:682:9: error: format not a string literal and no format arguments [-Werror=format-security]
> 682 | return sysfs_emit(buf, type[ctrl->cntrltype]);
>
> Print these using a "%s" format like all other instances in the same file.
>
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
Looks good to me.
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: work around all -Wformat-security warnings
2026-09-17 6:04 [PATCH] nvme: work around all -Wformat-security warnings Arnd Bergmann
2026-09-17 8:14 ` Nilay Shroff
@ 2026-09-17 19:53 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2026-09-17 19:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jens Axboe, Christoph Hellwig, Sagi Grimberg, Arnd Bergmann,
Nilay Shroff, Hannes Reinecke, Maurizio Lombardi, John Garry,
Alistair Francis, Eric Biggers, linux-nvme, linux-kernel
On Thu, Sep 17, 2026 at 08:04:03AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The sysfs code passes two string variables into sysfs_emit(), which is safe
> in this instance but causes the compiler to warn when -Wformat-security
> is enabled:
>
> host/sysfs.c: In function `cntrltype_show´:
> host/sysfs.c:682:9: error: format not a string literal and no format arguments [-Werror=format-security]
> 682 | return sysfs_emit(buf, type[ctrl->cntrltype]);
>
> Print these using a "%s" format like all other instances in the same file.
Thanks, applied to nvme-7.3.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-17 19:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 6:04 [PATCH] nvme: work around all -Wformat-security warnings Arnd Bergmann
2026-09-17 8:14 ` Nilay Shroff
2026-09-17 19:53 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®