mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wentao Liang <vulab@iscas.ac.cn>
To: lee@kernel.org
Cc: linusw@kernel.org, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org, pavel@kernel.org,
	Wentao Liang <vulab@iscas.ac.cn>,
	stable@vger.kernel.org
Subject: [PATCH] leds: netxbig: Fix platform device reference leak on successful probe
Date: Thu, 17 Sep 2026 09:36:41 +0000	[thread overview]
Message-ID: <20260917093641.2144866-1-vulab@iscas.ac.cn> (raw)

of_find_device_by_node() returns the GPIO extension device with an
elevated reference count.  The error paths release it through the
put_device label, but the success path returns directly, so the
reference is leaked whenever the LED driver probes successfully.

Let the success path fall through to the put_device label.

Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/leds/leds-netxbig.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
index 99df46f2d9f5..d79fee1d9143 100644
--- a/drivers/leds/leds-netxbig.c
+++ b/drivers/leds/leds-netxbig.c
@@ -597,8 +597,7 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
 	pdata->leds = leds;
 	pdata->num_leds = num_leds;
 
-	return 0;
-
+	ret = 0;
 put_device:
 	put_device(gpio_ext_dev);
 	return ret;
-- 
2.34.1


             reply	other threads:[~2026-09-17  9:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  9:36 Wentao Liang [this message]
2026-09-22 16:03 ` Lee Jones
2026-11-07  4:27   ` [PATCH v2] " Wentao Liang
2026-11-18 17:20     ` Lee Jones
2026-11-18 17:35     ` (subset) " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917093641.2144866-1-vulab@iscas.ac.cn \
    --to=vulab@iscas.ac.cn \
    --cc=lee@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®