From: Lee Jones <lee@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: linusw@kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, pavel@kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] leds: netxbig: Fix platform device reference leak on successful probe
Date: Wed, 18 Nov 2026 17:20:16 +0000 [thread overview]
Message-ID: <20261118172016.GE98456@joneslee-macbookpro.roam.internal> (raw)
In-Reply-To: <20261107042737.708109-1-vulab@iscas.ac.cn>
On Sat, 07 Nov 2026, Wentao Liang wrote:
> of_find_device_by_node() returns the GPIO extension device with an
> elevated reference count. The error paths release it through the
> put_device label, but the success path returns directly, so the
> reference is leaked whenever the LED driver probes successfully.
>
> Release the reference right after its last use and remove the put_device
> label and the gotos leading to it.
>
> Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
> Suggested-by: Lee Jones <lee@kernel.org>
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> Changes in v2:
> - Release the reference right after its last use and remove the put_device
> label and the gotos, as suggested.
> - Apologies for the very late reply.
> drivers/leds/leds-netxbig.c | 74 ++++++++++++++-----------------------
> 1 file changed, 27 insertions(+), 47 deletions(-)
Much nicer, thanks.
In future, please submit versions on their own.
Attaching them to previous submissions gets real confusing, real quick.
--
Lee Jones
next prev parent reply other threads:[~2026-11-18 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 9:36 [PATCH] " Wentao Liang
2026-09-22 16:03 ` Lee Jones
2026-11-07 4:27 ` [PATCH v2] " Wentao Liang
2026-11-18 17:20 ` Lee Jones [this message]
2026-11-18 17:35 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118172016.GE98456@joneslee-macbookpro.roam.internal \
--to=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®