From: Wentao Liang <vulab@iscas.ac.cn>
To: Lee Jones <lee@kernel.org>
Cc: linusw@kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, pavel@kernel.org, vulab@iscas.ac.cn,
stable@vger.kernel.org
Subject: [PATCH v2] leds: netxbig: Fix platform device reference leak on successful probe
Date: Sat, 7 Nov 2026 12:27:37 +0800 [thread overview]
Message-ID: <20261107042737.708109-1-vulab@iscas.ac.cn> (raw)
In-Reply-To: <20260922160323.GB3438784@google.com>
of_find_device_by_node() returns the GPIO extension device with an
elevated reference count. The error paths release it through the
put_device label, but the success path returns directly, so the
reference is leaked whenever the LED driver probes successfully.
Release the reference right after its last use and remove the put_device
label and the gotos leading to it.
Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
Suggested-by: Lee Jones <lee@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
Changes in v2:
- Release the reference right after its last use and remove the put_device
label and the gotos, as suggested.
- Apologies for the very late reply.
drivers/leds/leds-netxbig.c | 74 ++++++++++++++-----------------------
1 file changed, 27 insertions(+), 47 deletions(-)
diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
index 99df46f2d9f5..3a0456eae2c3 100644
--- a/drivers/leds/leds-netxbig.c
+++ b/drivers/leds/leds-netxbig.c
@@ -462,41 +462,36 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
gpio_ext_dev = &gpio_ext_pdev->dev;
gpio_ext = devm_kzalloc(dev, sizeof(*gpio_ext), GFP_KERNEL);
- if (!gpio_ext) {
- of_node_put(gpio_ext_np);
+ if (!gpio_ext)
ret = -ENOMEM;
- goto put_device;
- }
- ret = netxbig_gpio_ext_get(dev, gpio_ext_dev, gpio_ext);
+ else
+ ret = netxbig_gpio_ext_get(dev, gpio_ext_dev, gpio_ext);
+
of_node_put(gpio_ext_np);
+ put_device(gpio_ext_dev);
if (ret)
- goto put_device;
+ return ret;
+
pdata->gpio_ext = gpio_ext;
/* Timers (optional) */
ret = of_property_count_u32_elems(np, "timers");
if (ret > 0) {
- if (ret % 3) {
- ret = -EINVAL;
- goto put_device;
- }
+ if (ret % 3)
+ return -EINVAL;
num_timers = ret / 3;
timers = devm_kcalloc(dev, num_timers, sizeof(*timers),
GFP_KERNEL);
- if (!timers) {
- ret = -ENOMEM;
- goto put_device;
- }
+ if (!timers)
+ return -ENOMEM;
for (i = 0; i < num_timers; i++) {
u32 tmp;
of_property_read_u32_index(np, "timers", 3 * i,
&timers[i].mode);
- if (timers[i].mode >= NETXBIG_LED_MODE_NUM) {
- ret = -EINVAL;
- goto put_device;
- }
+ if (timers[i].mode >= NETXBIG_LED_MODE_NUM)
+ return -EINVAL;
of_property_read_u32_index(np, "timers",
3 * i + 1, &tmp);
timers[i].delay_on = tmp;
@@ -512,15 +507,12 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
num_leds = of_get_available_child_count(np);
if (!num_leds) {
dev_err(dev, "No LED subnodes found in DT\n");
- ret = -ENODEV;
- goto put_device;
+ return -ENODEV;
}
leds = devm_kcalloc(dev, num_leds, sizeof(*leds), GFP_KERNEL);
- if (!leds) {
- ret = -ENOMEM;
- goto put_device;
- }
+ if (!leds)
+ return -ENOMEM;
led = leds;
for_each_available_child_of_node_scoped(np, child) {
@@ -531,40 +523,34 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
ret = of_property_read_u32(child, "mode-addr",
&led->mode_addr);
if (ret)
- goto put_device;
+ return ret;
ret = of_property_read_u32(child, "bright-addr",
&led->bright_addr);
if (ret)
- goto put_device;
+ return ret;
ret = of_property_read_u32(child, "max-brightness",
&led->bright_max);
if (ret)
- goto put_device;
+ return ret;
mode_val =
devm_kcalloc(dev,
NETXBIG_LED_MODE_NUM, sizeof(*mode_val),
GFP_KERNEL);
- if (!mode_val) {
- ret = -ENOMEM;
- goto put_device;
- }
+ if (!mode_val)
+ return -ENOMEM;
for (i = 0; i < NETXBIG_LED_MODE_NUM; i++)
mode_val[i] = NETXBIG_LED_INVALID_MODE;
ret = of_property_count_u32_elems(child, "mode-val");
- if (ret < 0 || ret % 2) {
- ret = -EINVAL;
- goto put_device;
- }
+ if (ret < 0 || ret % 2)
+ return -EINVAL;
num_modes = ret / 2;
- if (num_modes > NETXBIG_LED_MODE_NUM) {
- ret = -EINVAL;
- goto put_device;
- }
+ if (num_modes > NETXBIG_LED_MODE_NUM)
+ return -EINVAL;
for (i = 0; i < num_modes; i++) {
int mode;
@@ -574,10 +560,8 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
"mode-val", 2 * i, &mode);
of_property_read_u32_index(child,
"mode-val", 2 * i + 1, &val);
- if (mode >= NETXBIG_LED_MODE_NUM) {
- ret = -EINVAL;
- goto put_device;
- }
+ if (mode >= NETXBIG_LED_MODE_NUM)
+ return -EINVAL;
mode_val[mode] = val;
}
led->mode_val = mode_val;
@@ -598,10 +582,6 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
pdata->num_leds = num_leds;
return 0;
-
-put_device:
- put_device(gpio_ext_dev);
- return ret;
}
static const struct of_device_id of_netxbig_leds_match[] = {
--
2.25.1
next prev parent reply other threads:[~2026-11-07 4:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 9:36 [PATCH] " Wentao Liang
2026-09-22 16:03 ` Lee Jones
2026-11-07 4:27 ` Wentao Liang [this message]
2026-11-18 17:20 ` [PATCH v2] " Lee Jones
2026-11-18 17:35 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107042737.708109-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®