mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Semih Baskan <strst.gs@gmail.com>
Cc: lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org,
	robh@kernel.org, bhelgaas@google.com, rjui@broadcom.com,
	sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
	rafal@milecki.pl, zajec5@gmail.com,
	florian.fainelli@broadcom.com, arnd@arndb.de,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, rosenp@gmail.com,
	rani.hod@gmail.com
Subject: Re: [PATCH] PCI: iproc: Use pci_alloc_host_bridge() on BCMA
Date: Thu, 17 Sep 2026 13:36:02 -0500	[thread overview]
Message-ID: <20260917183602.GA1036092@bhelgaas> (raw)
In-Reply-To: <CAAsRjRmmPanAjpquZ4VnDDw9jqRkxPkLsu+KjrpwsOMj8-TE-Q@mail.gmail.com>

On Thu, Sep 17, 2026 at 09:02:23PM +0300, Semih Baskan wrote:
> On Thu, Sep 17, 2026 at 10:59:29AM -0500, Bjorn Helgaas wrote:
> > And why do we need pcie-iproc-platform, since pcie-iproc-bcma.c will
> > claim them?
> 
> I do not see anything on Northstar that needs it. I think
> pcie-iproc-platform is the front end for the iProc SoCs that have no
> bcma bus.
> 
> > Is there a requirement that pcie-iproc-platform must be able to claim
> > the PCI host bridge if CONFIG_PCIE_IPROC_BCMA is not enabled?
> 
> None that I can find. Neither symbol depends on the other, no in-tree
> defconfig sets either one, and multi_v7_defconfig gets both from their
> defaults. OpenWrt builds only the BCMA one. The one use of the
> platform driver on Northstar I know of is Rafał's: 767012397976 says
> it was tested with it on BCM47094, and his test in the thread on the
> axi ranges ran both drivers on his board. The platform driver
> enumerated the two BCM4366 devices on its own:
> https://lore.kernel.org/all/93ee7456-4179-4d78-b980-1df0b7e0278a@gmail.com/
> I have not looked outside the tree.

Then it seems like we should remove the "brcm,iproc-pcie" compatible
from DTs for platforms where bcma can enumerate it via EROM.  Those
platforms can enable CONFIG_PCIE_IPROC_BCMA.  They still need the PCIe
controller node in DT so they can use the wifi nodes below it, but if
there's no "brcm,iproc-pcie" compatible, pcie-iproc-platform shouldn't
do anything.

Arnd, Rafał, jump in if I'm in the weeds here.

  reply	other threads:[~2026-09-17 18:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 16:05 [PATCH v3] PCI: iproc: Use the EROM outbound window " Semih Baskan
2026-09-10 11:14 ` Manivannan Sadhasivam
2026-09-11 19:14 ` Bjorn Helgaas
2026-09-12  4:32   ` Semih Baskan
2026-09-12  4:36     ` [PATCH] PCI: iproc: Use pci_alloc_host_bridge() " Semih Baskan
2026-09-14 17:46       ` Bjorn Helgaas
2026-09-16  8:12         ` Semih Baskan
2026-09-16 20:01           ` Bjorn Helgaas
2026-09-17  5:40             ` Semih Baskan
2026-09-17 15:59               ` Bjorn Helgaas
2026-09-17 18:02                 ` Semih Baskan
2026-09-17 18:36                   ` Bjorn Helgaas [this message]
2026-09-17 20:27                     ` Arnd Bergmann
2026-09-17 21:48                       ` Bjorn Helgaas
2026-09-18  5:46                         ` Arnd Bergmann
2026-09-18  8:29                       ` Semih Baskan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917183602.GA1036092@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=rafal@milecki.pl \
    --cc=rani.hod@gmail.com \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=rosenp@gmail.com \
    --cc=sbranden@broadcom.com \
    --cc=strst.gs@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®