Re: [PATCH] PCI: iproc: Use pci_alloc_host_bridge() on BCMA

["Arnd Bergmann" <arnd@arndb.de>]

On Thu, Sep 17, 2026, at 23:48, Bjorn Helgaas wrote:
> On Thu, Sep 17, 2026 at 10:27:54PM +0200, Arnd Bergmann wrote:
>> On Thu, Sep 17, 2026, at 20:36, Bjorn Helgaas wrote:
>> 
>> It feels wrong to me to change the devicetee file when that arguably
>> describes the device correctly, and we still need the node for the
>> bcma bus probe in the end.
>
> I don't think pcie-iproc-bcma.c needs anything from DT at all.
> Everything it needs is in EROM.
>
> Some PCI drivers, e.g., wifi, need DT nodes, and I think those need to
> be enclosed in a node for the PCI host controller, but
> pcie-iproc-bcma.c itself doesn't care.

I understand that it just works without that, my only concerns is
that having a DT node (which is required for adding child nodes)
without a compatible string is going to cause problems later,

From the DT perspective, it would be better to add a second
(or third) compatible string to identify the device better and
keep the existing generic string as a fallback. The
pcie-iproc-platform driver can then skip the device based
on the more specific string.

Simply replacing the existing compatible string with a new one
would solve the probe order problem and at least leave a
well-formed device node, but this would still count as an
incompatible binding update, which we try hard to avoid.

        Arnd