mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Semih Baskan" <strst.gs@gmail.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	bhelgaas@google.com, "Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, "Rosen Penev" <rosenp@gmail.com>,
	rani.hod@gmail.com
Subject: Re: [PATCH] PCI: iproc: Use pci_alloc_host_bridge() on BCMA
Date: Thu, 17 Sep 2026 16:48:01 -0500	[thread overview]
Message-ID: <20260917214801.GA1054958@bhelgaas> (raw)
In-Reply-To: <7c2a8582-280e-471a-b4b0-037b2cda6ad8@app.fastmail.com>

On Thu, Sep 17, 2026 at 10:27:54PM +0200, Arnd Bergmann wrote:
> On Thu, Sep 17, 2026, at 20:36, Bjorn Helgaas wrote:
> > On Thu, Sep 17, 2026 at 09:02:23PM +0300, Semih Baskan wrote:
> >> On Thu, Sep 17, 2026 at 10:59:29AM -0500, Bjorn Helgaas wrote:
> >
> > Then it seems like we should remove the "brcm,iproc-pcie" compatible
> > from DTs for platforms where bcma can enumerate it via EROM.  Those
> > platforms can enable CONFIG_PCIE_IPROC_BCMA.  They still need the PCIe
> > controller node in DT so they can use the wifi nodes below it, but if
> > there's no "brcm,iproc-pcie" compatible, pcie-iproc-platform shouldn't
> > do anything.
> >
> > Arnd, Rafał, jump in if I'm in the weeds here.
> 
> It feels wrong to me to change the devicetee file when that arguably
> describes the device correctly, and we still need the node for the
> bcma bus probe in the end.

I don't think pcie-iproc-bcma.c needs anything from DT at all.
Everything it needs is in EROM.

Some PCI drivers, e.g., wifi, need DT nodes, and I think those need to
be enclosed in a node for the PCI host controller, but
pcie-iproc-bcma.c itself doesn't care.

Bjorn

  reply	other threads:[~2026-09-17 21:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 16:05 [PATCH v3] PCI: iproc: Use the EROM outbound window " Semih Baskan
2026-09-10 11:14 ` Manivannan Sadhasivam
2026-09-11 19:14 ` Bjorn Helgaas
2026-09-12  4:32   ` Semih Baskan
2026-09-12  4:36     ` [PATCH] PCI: iproc: Use pci_alloc_host_bridge() " Semih Baskan
2026-09-14 17:46       ` Bjorn Helgaas
2026-09-16  8:12         ` Semih Baskan
2026-09-16 20:01           ` Bjorn Helgaas
2026-09-17  5:40             ` Semih Baskan
2026-09-17 15:59               ` Bjorn Helgaas
2026-09-17 18:02                 ` Semih Baskan
2026-09-17 18:36                   ` Bjorn Helgaas
2026-09-17 20:27                     ` Arnd Bergmann
2026-09-17 21:48                       ` Bjorn Helgaas [this message]
2026-09-18  5:46                         ` Arnd Bergmann
2026-09-18  8:29                       ` Semih Baskan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260917214801.GA1054958@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=rafal@milecki.pl \
    --cc=rani.hod@gmail.com \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=rosenp@gmail.com \
    --cc=sbranden@broadcom.com \
    --cc=strst.gs@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®