[PATCH] scsi: efct: clear MWI on remove

[PATCH] scsi: efct: clear MWI on remove

[Guangshuo Li]

efct_pci_probe() enables PCI Memory-Write-Invalidate with pci_set_mwi().
The probe failure path clears this state with pci_clear_mwi(), but the
normal remove path does not perform the corresponding cleanup.

pci_disable_device() only disables PCI bus mastering and does not clear
the PCI_COMMAND_INVALIDATE bit. As a result, the MWI configuration can
remain enabled after the driver is removed.

Call pci_clear_mwi() in efct_pci_remove(), matching the probe error
path.

This issue was found by manual code inspection.

Fixes: 4df84e8466242 ("scsi: elx: efct: Driver initialization routines")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
 drivers/scsi/elx/efct/efct_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/elx/efct/efct_driver.c b/drivers/scsi/elx/efct/efct_driver.c
index 07c2f453459e..720bad7b3517 100644
--- a/drivers/scsi/elx/efct/efct_driver.c
+++ b/drivers/scsi/elx/efct/efct_driver.c
@@ -613,6 +613,7 @@ efct_pci_remove(struct pci_dev *pdev)
 
 	pci_release_regions(pdev);
 
+	pci_clear_mwi(pdev);
 	pci_disable_device(pdev);
 }
 
-- 
2.43.0

Re: [PATCH] scsi: efct: clear MWI on remove

[Daniel Wagner]

On Sat, Sep 19, 2026 at 02:13:26AM +0800, Guangshuo Li wrote:
> efct_pci_probe() enables PCI Memory-Write-Invalidate with pci_set_mwi().
> The probe failure path clears this state with pci_clear_mwi(), but the
> normal remove path does not perform the corresponding cleanup.
> 
> pci_disable_device() only disables PCI bus mastering and does not clear
> the PCI_COMMAND_INVALIDATE bit. As a result, the MWI configuration can
> remain enabled after the driver is removed.
> 
> Call pci_clear_mwi() in efct_pci_remove(), matching the probe error
> path.
> 
> This issue was found by manual code inspection.
> 
> Fixes: 4df84e8466242 ("scsi: elx: efct: Driver initialization routines")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>

Reviewed-by: Daniel Wagner <dwagner@suse.de>

Re: [PATCH] scsi: efct: clear MWI on remove

[krzk]

On Sat, 19 Sep 2026 02:13:26 +0800, Guangshuo Li wrote:
> efct_pci_probe() enables PCI Memory-Write-Invalidate with pci_set_mwi().
> The probe failure path clears this state with pci_clear_mwi(), but the
> normal remove path does not perform the corresponding cleanup.
> 
> pci_disable_device() only disables PCI bus mastering and does not clear
> the PCI_COMMAND_INVALIDATE bit. As a result, the MWI configuration can
> remain enabled after the driver is removed.
> 
> Call pci_clear_mwi() in efct_pci_remove(), matching the probe error
> path.
> 
> This issue was found by manual code inspection.
> 
> Fixes: 4df84e8466242 ("scsi: elx: efct: Driver initialization routines")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> ---
>  drivers/scsi/elx/efct/efct_driver.c | 1 +
>  1 file changed, 1 insertion(+)
> 


You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem, how to document usage of LLM and how what you should not
do if this was posted in a good faith.

Best regards,
Krzysztof

Re: [PATCH] scsi: efct: clear MWI on remove

[Guangshuo Li]

Hi Krzysztof,

Thank you for your feedback.

On Mon, 21 Sept 2026 at 23:13, <krzk@kernel.org> wrote:
>
>
> On Sat, 19 Sep 2026 02:13:26 +0800, Guangshuo Li wrote:
> > efct_pci_probe() enables PCI Memory-Write-Invalidate with pci_set_mwi().
> > The probe failure path clears this state with pci_clear_mwi(), but the
> > normal remove path does not perform the corresponding cleanup.
> >
> > pci_disable_device() only disables PCI bus mastering and does not clear
> > the PCI_COMMAND_INVALIDATE bit. As a result, the MWI configuration can
> > remain enabled after the driver is removed.
> >
> > Call pci_clear_mwi() in efct_pci_remove(), matching the probe error
> > path.
> >
> > This issue was found by manual code inspection.
> >
> > Fixes: 4df84e8466242 ("scsi: elx: efct: Driver initialization routines")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> > ---
> >  drivers/scsi/elx/efct/efct_driver.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
>
>
> You sent multiple independent patches, to multiple independent
> subsystems. The amount of these patches clearly suggest this was
> AI generated and most likely not tested.
>
> More importantly, you sent all this work without properly organizing
> relevant patches into patchsets. This makes reviewing difficult
> and might cause multiple reviewers to address the same issue.
> Replying to the entire set is impossible and requires handling each
> patch independently, instead of applying or discarding the set.
> Maintainers also won't see the bigger picture of your work. Quite
> worrying.
>
> This is on the verge of hostile patch: bomb us with so many
> contributions, we won't be able to handle them in efficient manner,
> like responding ONCE to ask you to slow down.  Considering all this
> is untested and LLM generated, I have even more doubts whether this
> should be considered for review.
>
> Please read kernel documentation BEFORE posting more work. It will
> explain you how to identify subsystems, how to organize your work per
> subsystem, how to document usage of LLM and how what you should not
> do if this was posted in a good faith.
>
> Best regards,
> Krzysztof
>
>
>

I would like to clarify that these patches were manually reviewed and
audited by us; they were not simply generated and submitted by an LLM.
However, I understand why the recent submission pattern may have given
that impression. We sent too many patches in a short period of time,
and we also failed to respond to some discussions in a timely manner,
which made the situation look worse.

Many of the recent patches, especially the v2 revisions, are
corrections and improvements based on previous review feedback rather
than completely new untested changes. That said, we recognize that the
way we submitted them increased the burden on maintainers and
reviewers.

We apologize for the pressure this caused to the community. We will be
more careful about organizing patches by subsystem, preparing proper
patchsets, and following the kernel contribution guidelines before
sending future work.

Thank you again for pointing this out.

Best regards,
Guangshuo