From: Karl Mehltretter <kmehltretter@gmail.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v18 02/14] arm64: ptrace: Rework audit_syscall_entry()
Date: Sat, 19 Sep 2026 18:43:19 +0200 [thread overview]
Message-ID: <20260919164319.90193-1-kmehltretter@gmail.com> (raw)
In-Reply-To: <20260902095537.602517-3-ruanjinjie@huawei.com>
> + if (unlikely(audit_context()))
> + syscall_enter_audit(regs);
With arm64 defconfig and CONFIG_AUDIT=n on v7.3-rc1, building
arch/arm64/kernel/ptrace.o after this patch fails with GCC 15.2.0:
arch/arm64/kernel/ptrace.c: In function ‘syscall_trace_enter’:
arch/arm64/kernel/ptrace.c:2491:17: error: implicit declaration of function ‘syscall_enter_audit’ [-Wimplicit-function-declaration]
2491 | syscall_enter_audit(regs);
| ^~~~~~~~~~~~~~~~~~~
The helper is defined only under CONFIG_AUDITSYSCALL, but this call
remains when auditing is disabled. The audit_context() check does not
avoid the missing declaration.
Could the helper get an audit-disabled stub, or could this call be
guarded as well?
The same object builds after patches 1 and 13. Patch 12 still fails
with the missing declaration. Patch 13 removes the affected code, but
the intermediate commits should remain buildable.
Thanks,
Karl
next prev parent reply other threads:[~2026-09-19 16:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 9:55 [PATCH v18 00/14] arm64: entry: Convert to Generic Entry Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 01/14] arm64: ptrace: Fix redundant syscall exit stop for PTRACE_SYSEMU_SINGLESTEP Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 02/14] arm64: ptrace: Rework audit_syscall_entry() Jinjie Ruan
2026-09-19 16:43 ` Karl Mehltretter [this message]
2026-09-20 1:24 ` Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 03/14] arm64: ptrace: Open-code seccomp check in syscall_trace_enter() Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 04/14] arm64: ptrace: Rename and clean up syscall_trace_enter() Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 05/14] arm64: ptrace: Protect rseq_syscall() from tracer PC modifications Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 06/14] arm64: syscall: Rework the syscall exit path in el0_svc_common() Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 07/14] arm64: ptrace: Pass thread flags to trace enter/exit Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 08/14] arm64: ptrace: Extract arm64_syscall_exit_to_user_mode_work() helper Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 09/14] arm64: ptrace: Align syscall exit work semantics with generic entry Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 10/14] arm64: syscall: Use exit-specific flags check in el0_svc_common() Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 11/14] arm64: syscall: Simplify el0_svc_common() syscall exit path Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 12/14] arm64: ptrace: Make return type of arm64_syscall_trace_enter() bool Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 13/14] arm64: entry: Convert to generic entry Jinjie Ruan
2026-09-02 9:55 ` [PATCH v18 14/14] arm64: Inline el0_svc_common() Jinjie Ruan
2026-09-15 13:03 ` [PATCH v18 00/14] arm64: entry: Convert to Generic Entry Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919164319.90193-1-kmehltretter@gmail.com \
--to=kmehltretter@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ruanjinjie@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®