Re: [PATCH] dt-bindings: soc: hisilicon: Add HIP05 CPLD

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

On Mon, Sep 21, 2026 at 06:25:39PM -0500, Rob Herring (Arm) wrote:
> Add schema for the hisilicon,hip05-cpld node on the HIP05 D02 board. The
> node only contains the compatible string and one register window on the
> local bus.
> 
> Assisted-by: LLM

Guidance to the LLM should probably include including the reason that
this is being added to the commit message.

> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../soc/hisilicon/hisilicon,hip05-cpld.yaml   | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml b/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml
> new file mode 100644
> index 000000000000..f9d48b871a4b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/hisilicon/hisilicon,hip05-cpld.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HiSilicon HIP05 CPLD registers
> +
> +maintainers:
> +  - Wei Xu <xuwei5@hisilicon.com>
> +
> +properties:
> +  compatible:
> +    const: hisilicon,hip05-cpld
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    local-bus {
> +        #address-cells = <2>;
> +        #size-cells = <1>;
> +
> +        cpld@100000000 {
> +            compatible = "hisilicon,hip05-cpld";
> +            reg = <1 0x0 0x100>;

Also what's with this example? 1 0x0 0x100 should be 0x1 0x0 0x100?

> +        };
> +    };
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]