Re: [PATCH] dt-bindings: soc: hisilicon: Add HIP05 CPLD

[Wei Xu <xuwei5@hisilicon.com>]

Hi Rob,

On 2026/9/23 23:04, Rob Herring wrote:
> On Tue, Sep 22, 2026 at 07:06:02PM +0100, Conor Dooley wrote:
>> On Mon, Sep 21, 2026 at 06:25:39PM -0500, Rob Herring (Arm) wrote:
>>> Add schema for the hisilicon,hip05-cpld node on the HIP05 D02 board. The
>>> node only contains the compatible string and one register window on the
>>> local bus.
>>>
>>> Assisted-by: LLM
>>
>> Guidance to the LLM should probably include including the reason that
>> this is being added to the commit message.
> 
> Not sure what you are looking for... I told it to convert all the .txt 
> bindings to schema. Then I told it fix all the errors. Then I fixed some 
> things throughout the 900 commit branch upstreaming things bit by bit.  
> Then it mostly sat for a year and I told a new model to review them and 
> fix these common problems a, b and c. Then I said fix all the 
> dtbs_checks warnings on arm64. Then I said there's still warnings, do it 
> again. Repeated that ~10 times. Now I'm going thru to weed out all the 
> wrong and sometimes unnecessary changes.
> 
> So LLM did all the easy parts and I did everything that requires any 
> judgement. The hardest part is typically just figuring out the 
> correct maintainers...
> 
>>> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
>>> ---
>>>  .../soc/hisilicon/hisilicon,hip05-cpld.yaml   | 35 +++++++++++++++++++
>>>  1 file changed, 35 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml b/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml
>>> new file mode 100644
>>> index 000000000000..f9d48b871a4b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml
>>> @@ -0,0 +1,35 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/soc/hisilicon/hisilicon,hip05-cpld.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: HiSilicon HIP05 CPLD registers
>>> +
>>> +maintainers:
>>> +  - Wei Xu <xuwei5@hisilicon.com>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: hisilicon,hip05-cpld
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    local-bus {
>>> +        #address-cells = <2>;
>>> +        #size-cells = <1>;
>>> +
>>> +        cpld@100000000 {
>>> +            compatible = "hisilicon,hip05-cpld";
>>> +            reg = <1 0x0 0x100>;
>>
>> Also what's with this example? 1 0x0 0x100 should be 0x1 0x0 0x100?
> 
> Shrug. Sure. Honestly, I think the example can just be dropped.
> 
> I'm converting all the crap no one cares enough about to convert. That's 
> pretty much all of the HiSilicon stuff. Mediatek needs some renewed 
> public shaming too. I only care about getting arm64 down to no warnings.

My bad for the warnings!
Thanks for working on this schema cleanup!

Best Regards,
Wei

> 
> Rob
> .
>