Re: [PATCH] dt-bindings: soc: hisilicon: Add HIP05 CPLD

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1852 bytes --]

On Wed, Sep 23, 2026 at 10:04:09AM -0500, Rob Herring wrote:
> On Tue, Sep 22, 2026 at 07:06:02PM +0100, Conor Dooley wrote:
> > On Mon, Sep 21, 2026 at 06:25:39PM -0500, Rob Herring (Arm) wrote:
> > > Add schema for the hisilicon,hip05-cpld node on the HIP05 D02 board. The
> > > node only contains the compatible string and one register window on the
> > > local bus.
> > > 
> > > Assisted-by: LLM
> > 
> > Guidance to the LLM should probably include including the reason that
> > this is being added to the commit message.
> 
> Not sure what you are looking for... I told it to convert all the .txt 
> bindings to schema. Then I told it fix all the errors. Then I fixed some 

I meant that it should say something like "Add schema for ... node that
is undocumented but appears in the ... board dts".
Otherwise this seems like a completely random addition, other than the
submitter being you pointing towards it being cleanup for undocumented
stuff.

> things throughout the 900 commit branch upstreaming things bit by bit.  
> Then it mostly sat for a year and I told a new model to review them and 
> fix these common problems a, b and c. Then I said fix all the 
> dtbs_checks warnings on arm64. Then I said there's still warnings, do it 
> again. Repeated that ~10 times. Now I'm going thru to weed out all the 
> wrong and sometimes unnecessary changes.
> 
> So LLM did all the easy parts and I did everything that requires any 
> judgement. The hardest part is typically just figuring out the 
> correct maintainers...
> 
> > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > > ---
> > >  .../soc/hisilicon/hisilicon,hip05-cpld.yaml   | 35 +++++++++++++++++++
> > >  1 file changed, 35 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hip05-cpld.yaml

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]