From: Rick Edgecombe <rick.p.edgecombe@intel.com>
To: pbonzini@redhat.com, dave.hansen@intel.com, seanjc@google.com,
x86@kernel.org, kas@kernel.org, adrian.hunter@intel.com,
yan.y.zhao@intel.com, binbin.wu@intel.com, xiaoyao.li@intel.com,
chao.gao@intel.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: rick.p.edgecombe@intel.com
Subject: [PATCH 0/2] Drop unneeded cache flushing
Date: Tue, 22 Sep 2026 13:52:13 -0700 [thread overview]
Message-ID: <20260922205215.870563-1-rick.p.edgecombe@intel.com> (raw)
Hi TDX developers,
Can I get a round of review before we ask Dave and Sean to look at it?
In the early days of TDX it was assumed the HW would need some cache
flushing help around transitioning memory between KeyIDs, and so TDX arch
was designed to specify how the VMM needed to help the module perform
this. But it turned out the HW was able to handle these issues without SW
help. For some reason the TDX arch around performing the flushes remained.
Now the TDX arch is getting fixed and Linux can remove the code that was
helping perform this unneeded cache flushing. The changes will appear in
a future documentation update.
Especially, please consider if the explanation is clear enough for
maintainers and future git archaeologists.
As some more context, while this is nice cleanup as is, merging these
patches will let us drop 2 patches out of the TDX huge pages series. Then
that series doesn't need to modify these flushes to work with TDX huge
pages. It also addresses Kiryl's comment about the cache flushing in
tdh_mem_page_aug() not respecting the 'level' arg, or warning about that
non-4KB sizes are not supported.[0]
Based on v7.3-rc1.
Thanks,
Rick
[0] https://lore.kernel.org/lkml/20260825025533.25663-1-yan.y.zhao@intel.com/#t
Rick Edgecombe (2):
x86/virt/tdx: Drop tdx_clflush_*()
x86/virt/tdx: Drop tdh_phymem_page_wbinvd_*()
arch/x86/include/asm/tdx.h | 2 --
arch/x86/kvm/vmx/tdx.c | 14 -----------
arch/x86/virt/vmx/tdx/tdx.c | 49 -------------------------------------
arch/x86/virt/vmx/tdx/tdx.h | 1 -
4 files changed, 66 deletions(-)
--
2.55.0
next reply other threads:[~2026-09-22 20:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 20:52 Rick Edgecombe [this message]
2026-09-22 20:52 ` [PATCH 1/2] x86/virt/tdx: Drop tdx_clflush_*() Rick Edgecombe
2026-09-23 5:25 ` Yan Zhao
2026-09-23 7:30 ` Binbin Wu
2026-09-23 7:47 ` Tony Lindgren
2026-09-23 15:50 ` Edgecombe, Rick P
2026-09-23 11:58 ` Nikolay Borisov
2026-09-23 16:26 ` Edgecombe, Rick P
2026-09-23 18:07 ` Nikolay Borisov
2026-09-22 20:52 ` [PATCH 2/2] x86/virt/tdx: Drop tdh_phymem_page_wbinvd_*() Rick Edgecombe
2026-09-23 2:18 ` Xiaoyao Li
2026-09-23 16:31 ` Edgecombe, Rick P
2026-09-23 5:41 ` Yan Zhao
2026-09-23 7:09 ` Xu Yilun
2026-09-23 18:18 ` Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922205215.870563-1-rick.p.edgecombe@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=adrian.hunter@intel.com \
--cc=binbin.wu@intel.com \
--cc=chao.gao@intel.com \
--cc=dave.hansen@intel.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®