From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>
Cc: "Gao, Chao" <chao.gao@intel.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
"seanjc@google.com" <seanjc@google.com>,
"x86@kernel.org" <x86@kernel.org>,
"kas@kernel.org" <kas@kernel.org>,
"Wu, Binbin" <binbin.wu@intel.com>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86/virt/tdx: Drop tdx_clflush_*()
Date: Wed, 23 Sep 2026 15:50:10 +0000 [thread overview]
Message-ID: <9b5b78ff72d263e43e49b18b0035c0aea8846d51.camel@intel.com> (raw)
In-Reply-To: <arOEHVklXn3VGBQt@tlindgre-MOBL1>
On Wed, 2026-09-23 at 10:47 +0300, Tony Lindgren wrote:
> On Tue, Sep 22, 2026 at 01:52:14PM -0700, Rick Edgecombe wrote:
> > In practice this bit has never been set by any TDX module, so flushing
> > is unneeded. Going forward the TDX docs will be updated to clarify that
> > CLFLUSH_BEFORE_ALLOC will never be set in any future TDX module either.
>
> Should there be a separate patch first before these two patches to bail
> out if the TDX module TDX_FEATURES0 CLFLUSH_BEFORE_ALLOC bit is ever set?
>
> Then dropping the related code would be safe to do without having to
> ponder if it's safe to do.
Eh, I don't think we need it. If docs are updated to say TDX will never set it,
then we would really be sanity checking the TDX module specs. Doesn't seem worth
the code.
next prev parent reply other threads:[~2026-09-23 15:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 20:52 [PATCH 0/2] Drop unneeded cache flushing Rick Edgecombe
2026-09-22 20:52 ` [PATCH 1/2] x86/virt/tdx: Drop tdx_clflush_*() Rick Edgecombe
2026-09-23 5:25 ` Yan Zhao
2026-09-23 7:30 ` Binbin Wu
2026-09-23 7:47 ` Tony Lindgren
2026-09-23 15:50 ` Edgecombe, Rick P [this message]
2026-09-23 11:58 ` Nikolay Borisov
2026-09-23 16:26 ` Edgecombe, Rick P
2026-09-23 18:07 ` Nikolay Borisov
2026-09-22 20:52 ` [PATCH 2/2] x86/virt/tdx: Drop tdh_phymem_page_wbinvd_*() Rick Edgecombe
2026-09-23 2:18 ` Xiaoyao Li
2026-09-23 16:31 ` Edgecombe, Rick P
2026-09-23 5:41 ` Yan Zhao
2026-09-23 18:22 ` Edgecombe, Rick P
2026-09-23 7:09 ` Xu Yilun
2026-09-23 18:18 ` Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b5b78ff72d263e43e49b18b0035c0aea8846d51.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=adrian.hunter@intel.com \
--cc=binbin.wu@intel.com \
--cc=chao.gao@intel.com \
--cc=dave.hansen@intel.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tony.lindgren@linux.intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®