From: Zhan Xusheng <zhanxusheng1024@gmail.com>
To: Joel Granados <joel.granados@kernel.org>
Cc: Zhan Xusheng <zhanxusheng@xiaomi.com>,
Kees Cook <kees@kernel.org>, Shuah Khan <shuah@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Bradley Morgan <brads@mainlining.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: [PATCH 0/2] sysctl: Cover the jiffies converters in the selftests
Date: Wed, 23 Sep 2026 22:49:35 +0800 [thread overview]
Message-ID: <20260923144940.3712965-1-zhanxusheng@xiaomi.com> (raw)
Joel asked for a test for the negative read path fixed by
https://lore.kernel.org/r/20260922031229.2300283-2-zhanxusheng@xiaomi.com
These apply on sysctl-next and depend on that fix; without it 2/2 fails,
which is the point.
While writing the test I noticed that fix's changelog is incomplete: it
names proc_dointvec_jiffies() and proc_dointvec_ms_jiffies(), but
proc_dointvec_userhz_jiffies() goes through the same
proc_int_k2u_conv_kop() and is affected too. Measured on
net/ipv4/neigh/default/retrans_time at CONFIG_HZ=250, unpatched:
# echo -1 > /proc/sys/net/ipv4/neigh/default/retrans_time
# cat /proc/sys/net/ipv4/neigh/default/retrans_time
-18446742229035144246
I will correct that in the respin.
Tested in qemu at CONFIG_HZ=250 with CONFIG_TEST_SYSCTL=y, and built as
=m. 2/2 reports "not ok" without the fix and "ok" with it, and the
pass/fail counts of the other tests are unchanged either way.
Zhan Xusheng (2):
sysctl: Add jiffies converter entries to the test module
selftests: sysctl: Check the sign of a negative jiffies read
lib/test_sysctl.c | 31 ++++++++++++++++++++++++
tools/testing/selftests/sysctl/sysctl.sh | 23 ++++++++++++++++++
2 files changed, 54 insertions(+)
base-commit: c5c4ca25387e3cefd1af64edf9187546b6d06787
--
2.43.0
next reply other threads:[~2026-09-23 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 14:49 Zhan Xusheng [this message]
2026-09-23 14:49 ` [PATCH 1/2] sysctl: Add jiffies converter entries to the test module Zhan Xusheng
2026-09-23 15:53 ` Bradley Morgan
2026-09-23 14:49 ` [PATCH 2/2] selftests: sysctl: Check the sign of a negative jiffies read Zhan Xusheng
2026-09-23 15:53 ` Bradley Morgan
2026-09-25 11:45 ` Joel Granados
2026-09-25 15:03 ` Bradley Morgan
2026-09-25 11:41 ` [PATCH 0/2] sysctl: Cover the jiffies converters in the selftests Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923144940.3712965-1-zhanxusheng@xiaomi.com \
--to=zhanxusheng1024@gmail.com \
--cc=brads@mainlining.org \
--cc=joel.granados@kernel.org \
--cc=kees@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®