From: Bradley Morgan <brads@mainlining.org>
To: Zhan Xusheng <zhanxusheng1024@gmail.com>,
Joel Granados <joel.granados@kernel.org>
Cc: Zhan Xusheng <zhanxusheng@xiaomi.com>,
Kees Cook <kees@kernel.org>, Shuah Khan <shuah@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/2] sysctl: Add jiffies converter entries to the test module
Date: Wed, 23 Sep 2026 16:53:11 +0100 [thread overview]
Message-ID: <6A9B6ACC-6BFD-4F76-B721-8C1309115907@mainlining.org> (raw)
In-Reply-To: <20260923144940.3712965-2-zhanxusheng@xiaomi.com>
On 23 September 2026 15:49:36 BST, Zhan Xusheng <zhanxusheng1024@gmail.com>
wrote:
>lib/test_sysctl.c covers proc_dointvec(), proc_douintvec(),
>proc_dostring(), proc_do_large_bitmap() and proc_dou8vec_minmax(), but
>none of the jiffies converters. Their int paths report the sign
>separately from the magnitude, which is a shape the existing entries do
>not exercise at all.
>
>Add one entry per affected int converter: proc_dointvec_jiffies(),
>proc_dointvec_ms_jiffies() and proc_dointvec_userhz_jiffies(). Each is
>seeded with HZ jiffies, which is one second in every converter's own
>unit, so the three read back as 1, 1000 and 100 respectively.
LGTM, thanks (and I reviewed this properly)
Reviewed-by: Bradley Morgan <brads@mainlining.org>
All tests pass with your patch applied on my PowerPC box:
Tested-by: Bradley Morgan <brads@mainlining.org> # POWER10
>
>Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
>---
> lib/test_sysctl.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
>diff --git a/lib/test_sysctl.c b/lib/test_sysctl.c
>index 909cfcf76dbf..7718cf4ffd47 100644
>--- a/lib/test_sysctl.c
>+++ b/lib/test_sysctl.c
>@@ -15,6 +15,7 @@
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> #include <linux/init.h>
>+#include <linux/jiffies.h>
> #include <linux/list.h>
> #include <linux/module.h>
> #include <linux/printk.h>
>@@ -48,6 +49,10 @@ struct test_sysctl_data {
>
> int boot_int;
>
>+ int int_jiffies;
>+ int int_ms_jiffies;
>+ int int_userhz_jiffies;
>+
> unsigned int uint_0001;
>
> char string_0001[65];
>@@ -67,6 +72,11 @@ static struct test_sysctl_data test_data = {
>
> .boot_int = 0,
>
>+ /* One second in each converter's unit; all three store HZ jiffies. */
Nice comment!
>+ .int_jiffies = HZ,
>+ .int_ms_jiffies = HZ,
>+ .int_userhz_jiffies = HZ,
>+
> .uint_0001 = 314,
>
> .string_0001 = "(none)",
>@@ -113,6 +123,27 @@ static const struct ctl_table test_table[] = {
> .extra1 = SYSCTL_ZERO,
> .extra2 = SYSCTL_ONE,
> },
>+ {
>+ .procname = "int_jiffies",
>+ .data = &test_data.int_jiffies,
>+ .maxlen = sizeof(int),
>+ .mode = 0644,
>+ .proc_handler = proc_dointvec_jiffies,
>+ },
>+ {
>+ .procname = "int_ms_jiffies",
>+ .data = &test_data.int_ms_jiffies,
>+ .maxlen = sizeof(int),
>+ .mode = 0644,
>+ .proc_handler = proc_dointvec_ms_jiffies,
>+ },
>+ {
>+ .procname = "int_userhz_jiffies",
>+ .data = &test_data.int_userhz_jiffies,
>+ .maxlen = sizeof(int),
>+ .mode = 0644,
>+ .proc_handler = proc_dointvec_userhz_jiffies,
>+ },
This looks correct to me.
> {
> .procname = "uint_0001",
> .data = &test_data.uint_0001,
>
--- Thanks!
"I'm not a very positive person" - Linus torvalds
next prev parent reply other threads:[~2026-09-23 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 14:49 [PATCH 0/2] sysctl: Cover the jiffies converters in the selftests Zhan Xusheng
2026-09-23 14:49 ` [PATCH 1/2] sysctl: Add jiffies converter entries to the test module Zhan Xusheng
2026-09-23 15:53 ` Bradley Morgan [this message]
2026-09-23 14:49 ` [PATCH 2/2] selftests: sysctl: Check the sign of a negative jiffies read Zhan Xusheng
2026-09-23 15:53 ` Bradley Morgan
2026-09-25 11:45 ` Joel Granados
2026-09-25 15:03 ` Bradley Morgan
2026-09-25 11:41 ` [PATCH 0/2] sysctl: Cover the jiffies converters in the selftests Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A9B6ACC-6BFD-4F76-B721-8C1309115907@mainlining.org \
--to=brads@mainlining.org \
--cc=joel.granados@kernel.org \
--cc=kees@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=zhanxusheng1024@gmail.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®