From: Bradley Morgan <brads@mainlining.org>
To: Zhan Xusheng <zhanxusheng1024@gmail.com>,
Joel Granados <joel.granados@kernel.org>
Cc: Zhan Xusheng <zhanxusheng@xiaomi.com>,
Kees Cook <kees@kernel.org>, Shuah Khan <shuah@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests: sysctl: Check the sign of a negative jiffies read
Date: Wed, 23 Sep 2026 16:53:54 +0100 [thread overview]
Message-ID: <6DBE514E-E307-4E8E-999B-1B5592CE9AC5@mainlining.org> (raw)
In-Reply-To: <20260923144940.3712965-3-zhanxusheng@xiaomi.com>
On 23 September 2026 15:49:37 BST, Zhan Xusheng <zhanxusheng1024@gmail.com>
wrote:
>proc_int_k2u_conv_kop() returns the sign through *negp and the magnitude
>through *u_ptr. For a negative value it used to convert the
>sign-extended int and negate afterwards, so the magnitude came back as a
>wrapped 64-bit number. Nothing noticed, because no test wrote a
>negative value to a jiffies sysctl.
>
>Write one to each of the three int converters and require the value to
>read back unchanged. Each value is chosen to convert exactly at every
>CONFIG_HZ, so the test does not depend on it:
>
> converter write jiffies stored reads back
> jiffies -1 -HZ -1
> ms_jiffies -1000 -HZ -1000
> userhz_jiffies -100 -HZ -100
>
>On a kernel without the fix, at CONFIG_HZ=250:
>
> # int_jiffies: got '-18372957097414713411', want '-1'
> # int_ms_jiffies: got '-18446744069414585320', want '-1000'
> # int_userhz_jiffies: got '-18446742229035144346', want '-100'
> not ok 1 test_int_jiffies_negative
>
>(paths shortened; the runner prints them under
>/proc/sys/debug/test_sysctl)
>
>Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
>---
> tools/testing/selftests/sysctl/sysctl.sh | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
>diff --git a/tools/testing/selftests/sysctl/sysctl.sh b/tools/testing/selftests/sysctl/sysctl.sh
>index ceb5cfa0cfd4..ad1ee0fccd7c 100755
>--- a/tools/testing/selftests/sysctl/sysctl.sh
>+++ b/tools/testing/selftests/sysctl/sysctl.sh
>@@ -328,6 +328,29 @@ test_int_plain()
> assert_int_range "$t" "$baseline" || RET=$KSFT_FAIL
> }
>
>+# The jiffies converters report the sign separately from the magnitude, so a
>+# negative value must survive the round trip through the converter. Each
>+# value below is chosen to convert exactly at every CONFIG_HZ.
I have a feeling this could be decreased, but I don't care.
Reviewed-by: Bradley Morgan <brads@mainlining.org>
Tested on PowerPC:
Tested-by: Bradley Morgan <brads@mainlining.org> # POWER10
>+test_int_jiffies_negative()
>+{
>+ local t="${SYSCTL}/int_jiffies"
>+ local m="${SYSCTL}/int_ms_jiffies"
>+ local u="${SYSCTL}/int_userhz_jiffies"
>+
>+ [[ -f "$t" && -f "$m" && -f "$u" ]] || { RET=$KSFT_SKIP; return; }
>+
>+ printf '%s' "-1" > "$t"
>+ assert_content "$t" "-1" || RET=$KSFT_FAIL
>+ printf '%s' "-1000" > "$m"
>+ assert_content "$m" "-1000" || RET=$KSFT_FAIL
>+ printf '%s' "-100" > "$u"
>+ assert_content "$u" "-100" || RET=$KSFT_FAIL
>+
>+ # The positive path was never broken; keep it covered.
>+ printf '%s' "1" > "$t"
>+ assert_content "$t" "1" || RET=$KSFT_FAIL
>+}
>+
> test_uint_plain()
> {
> local t="${SYSCTL}/uint_0001"
>
--- Thanks!
"I'm not a very positive person" - Linus torvalds
next prev parent reply other threads:[~2026-09-23 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 14:49 [PATCH 0/2] sysctl: Cover the jiffies converters in the selftests Zhan Xusheng
2026-09-23 14:49 ` [PATCH 1/2] sysctl: Add jiffies converter entries to the test module Zhan Xusheng
2026-09-23 15:53 ` Bradley Morgan
2026-09-23 14:49 ` [PATCH 2/2] selftests: sysctl: Check the sign of a negative jiffies read Zhan Xusheng
2026-09-23 15:53 ` Bradley Morgan [this message]
2026-09-25 11:45 ` Joel Granados
2026-09-25 15:03 ` Bradley Morgan
2026-09-25 11:41 ` [PATCH 0/2] sysctl: Cover the jiffies converters in the selftests Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6DBE514E-E307-4E8E-999B-1B5592CE9AC5@mainlining.org \
--to=brads@mainlining.org \
--cc=joel.granados@kernel.org \
--cc=kees@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=zhanxusheng1024@gmail.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®