From: Leo Yan <leo.yan@arm.com>
To: Yeoreum Yun <yeoreum.yun@arm.com>
Cc: Mike Leach <mike.leach@arm.com>,
James Clark <james.clark@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v11 0/9] fix several inconsistencies with sysfs configuration in etmX
Date: Thu, 24 Sep 2026 16:25:43 +0100 [thread overview]
Message-ID: <20260924152543.GL200420@e132581.arm.com> (raw)
In-Reply-To: <20260915-separate_etm_cfg_v2-v11-0-d2b258d51747@arm.com>
On Tue, Sep 15, 2026 at 12:34:35PM +0100, Yeoreum Yun wrote:
> To resolve these inconsistencies, the configuration should be separated into:
>
> - active_config, which is applied configuration for the current session
> - config, which stores the settings configured via sysfs.
>
> and apply configuration from configfs after taking a mode.
I did the following tests on this series:
1) Perf test on Orion6 board:
# ./perf test coresight
142: CoreSight synthesized callchain : Ok
143: CoreSight concurrent threads : Ok
144: CoreSight context switch thread attribution : Ok
145: CoreSight deterministic workload decode : Ok
146: CoreSight raw dump stress : Ok
147: Check Arm CoreSight trace data recording and synthesized samples : FAILED!
148: Check Arm CoreSight disassembly script completes without errors : Ok
Test 147 has a known issue with per-thread mode. The failure was already
observed before this series.
2) Strobe mode test:
# echo 5000 > /sys/kernel/config/cs-syscfg/features/strobing/params/window/value
# echo 0 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value
# perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 36.301 MB perf.data ]
# echo 1 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value
# perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 18.361 MB perf.data ]
# echo 2 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value
# perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 12.246 MB perf.data ]
# echo 3 > /sys/kernel/config/cs-syscfg/features/strobing/params/period/value
# perf record -e cs_etm/autofdo,timestamp=0/u -m,128M -- perf test -w brstack 3000000
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 9.197 MB perf.data ]
The captured trace sizes maintain the expected proportional relationship
with the period values.
3) I verified the series on Juno-r2 baord with insmod and rmmod, and
CPU PM, and did not see any regression.
Maybe it'd be good to send a new version addressing Mike's comments.
Based on the test results, you can add my test tags:
Tested-by: Leo Yan <leo.yan@arm.com>
next prev parent reply other threads:[~2026-09-24 15:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 11:34 Yeoreum Yun
2026-09-15 11:34 ` [PATCH v11 1/9] coresight: etm4x: prohibit modifying ss_status and cntr_val while session is enabled Yeoreum Yun
2026-09-15 11:51 ` sashiko-bot
2026-09-15 13:26 ` Yeoreum Yun
2026-09-18 11:14 ` Mike Leach
2026-09-18 17:08 ` Yeoreum Yun
2026-09-15 11:34 ` [PATCH v11 2/9] coresight: etm3x: prohibit modifying cntr_val and reset " Yeoreum Yun
2026-09-15 11:48 ` sashiko-bot
2026-09-15 13:30 ` Yeoreum Yun
2026-09-15 13:55 ` Yeoreum Yun
2026-09-18 11:15 ` Mike Leach
2026-09-15 11:34 ` [PATCH v11 3/9] coresight: etm4x: fix inconsistencies with sysfs configuration Yeoreum Yun
2026-09-15 11:53 ` sashiko-bot
2026-09-15 12:36 ` Yeoreum Yun
2026-09-18 13:49 ` Mike Leach
2026-09-18 17:00 ` Yeoreum Yun
2026-09-15 11:34 ` [PATCH v11 4/9] coresight: etm3x: " Yeoreum Yun
2026-09-15 11:47 ` sashiko-bot
2026-09-15 13:42 ` Yeoreum Yun
2026-09-18 13:57 ` Mike Leach
2026-09-18 17:09 ` Yeoreum Yun
2026-09-15 11:34 ` [PATCH v11 5/9] coresight: etm3x: remove redundant cpu online check on etm_enable_sysfs() Yeoreum Yun
2026-09-18 13:58 ` Mike Leach
2026-09-15 11:34 ` [PATCH v11 6/9] coresight: etm4x: introduce struct etm4_caps Yeoreum Yun
2026-09-18 14:01 ` Mike Leach
2026-09-15 11:34 ` [PATCH v11 7/9] coresight: etm4x: exclude ss_status from drvdata->config Yeoreum Yun
2026-09-15 11:49 ` sashiko-bot
2026-09-15 13:35 ` Yeoreum Yun
2026-09-18 14:04 ` Mike Leach
2026-09-18 17:13 ` Yeoreum Yun
2026-09-15 11:34 ` [PATCH v11 8/9] coresight: etm4x: remove s_ex_level from config Yeoreum Yun
2026-09-18 14:05 ` Mike Leach
2026-09-15 11:34 ` [PATCH v11 9/9] coresight: etm3x: introduce struct etm_caps Yeoreum Yun
2026-09-18 14:57 ` Mike Leach
2026-09-24 15:25 ` Leo Yan [this message]
2026-09-24 17:28 ` [PATCH v11 0/9] fix several inconsistencies with sysfs configuration in etmX Yeoreum Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924152543.GL200420@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@arm.com \
--cc=rostedt@goodmis.org \
--cc=suzuki.poulose@arm.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®