From: Conor Dooley <conor@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Andi Shyti <andi.shyti@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>, Lee Jones <lee@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-i3c@lists.infradead.org, mfd@lists.linux.dev,
linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/20] arm64: add Synaptics SL261X SoCs and RDK boards
Date: Tue, 29 Sep 2026 20:38:52 +0100 [thread overview]
Message-ID: <20260929-smoked-laurel-087d5a3523a3@spud> (raw)
In-Reply-To: <20260929061417.20733-1-jszhang@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 6774 bytes --]
On Tue, Sep 29, 2026 at 02:13:57PM +0800, Jisheng Zhang wrote:
> Add initial support for the Synaptics SL261X SoCs and corresponding
> RDK boards.
>
> The SL261X SoCs include five pin-to-pin compatible SoCs: SL2611, SL2613,
> SL2615, SL2617, and SL2619.
>
> Only reset, pinctrl, clk/pll, uart, gpio, i2c, spi, i3c are included in
> this series. The support for Ethernet, USB, SDHCI, CAN, DMAC, XSPI will
> be submitted after this series is merged.
This series is filled with wildcard compatibles, which we don't permit
typically. The only case for SoCs that I've seen them accepted is when
the devices covered are actually just different binnings of the same
device. I took a look at the docs for this device, but it wasn't clear
to me if these are actually binnings or if there are different
integrations here. If they're binnings, I'd rather you used 0 as the
final digit, rather than x, since that matches the synaptics
documentation for the family. If they're not binnings, there's no
guarantee that they share the same errata etc, and must have different
compatibles.
Cheers,
Conor.
>
>
> Jisheng Zhang (20):
> dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl261x uart
> dt-bindings: i2c: dw: Add Synaptics sl261x i2c
> spi: dt-bindings: snps,dw-apb-ssi: Add Synaptics sl261x spi
> dt-bindings: i3c: dw: support up to two reset lines
> i3c: dw: switch to array-based exclusive reset control
> dt-bindings: i3c: Add Synaptics sl261x i3c
> arm64: kconfig: let ARCH_BERLIN cover Synaptics arm64 SoCs
> dt-bindings: reset: add Synaptics SL261X SoCs
> reset: add Synaptics SL261x reset support
> pinctrl: berlin: use u16 instead of u8 for the offset
> pinctrl: berlin: enable module build support
> pinctrl: berlin: add optional pinconf support
> dt-bindings: pinctrl: berlin: Support Synaptics SL261X SoCs
> pinctrl: berlin: support Synaptics SL261X SoCs
> dt-bindings: clock: add Synaptics SL261X clock
> clk: berlin: add Synaptics SL261X SoC clocks and plls
> dt-bindings: mfd: Add Synaptics SL261x global block binding
> regulator: dt-bindings: sy8827n: support standard properties
> dt-bindings: arm: berlin: Add Synaptics SL261X SoC and RDK board
> arm64: dts: synaptics: Add Synaptics SL261X SoC and RDK board
>
> .../bindings/arm/marvell,berlin.yaml | 20 +
> .../bindings/clock/syna,sl261x-clk.yaml | 92 +++
> .../bindings/i2c/snps,designware-i2c.yaml | 1 +
> .../bindings/i3c/snps,dw-i3c-master.yaml | 6 +-
> .../bindings/mfd/syna,sl261x-gbl.yaml | 208 +++++
> .../pinctrl/marvell,berlin2-soc-pinctrl.yaml | 10 +-
> .../bindings/regulator/silergy,sy8827n.yaml | 5 +-
> .../bindings/reset/syna,sl261x-reset.yaml | 40 +
> .../bindings/serial/snps-dw-apb-uart.yaml | 12 +-
> .../bindings/spi/snps,dw-apb-ssi.yaml | 1 +
> arch/arm64/Kconfig.platforms | 4 +-
> arch/arm64/boot/dts/synaptics/Makefile | 5 +
> arch/arm64/boot/dts/synaptics/sl2611-rdk.dts | 16 +
> arch/arm64/boot/dts/synaptics/sl2611.dtsi | 490 ++++++++++++
> arch/arm64/boot/dts/synaptics/sl2613-rdk.dts | 16 +
> arch/arm64/boot/dts/synaptics/sl2613.dtsi | 12 +
> arch/arm64/boot/dts/synaptics/sl2615-rdk.dts | 16 +
> arch/arm64/boot/dts/synaptics/sl2615.dtsi | 46 ++
> arch/arm64/boot/dts/synaptics/sl2617-rdk.dts | 16 +
> arch/arm64/boot/dts/synaptics/sl2617.dtsi | 46 ++
> arch/arm64/boot/dts/synaptics/sl2619-rdk.dts | 16 +
> arch/arm64/boot/dts/synaptics/sl2619.dtsi | 44 ++
> .../boot/dts/synaptics/sl261x-rdk-common.dtsi | 135 ++++
> drivers/clk/Kconfig | 1 +
> drivers/clk/berlin/Kconfig | 25 +
> drivers/clk/berlin/Makefile | 4 +
> drivers/clk/berlin/sl-clk.c | 279 +++++++
> drivers/clk/berlin/sl-clk.h | 31 +
> drivers/clk/berlin/sl-sysmgr-clk.c | 250 ++++++
> drivers/clk/berlin/sl-sysmgr-clk.h | 44 ++
> drivers/clk/berlin/sl261x-clks.c | 385 +++++++++
> drivers/clk/berlin/sl261x-pll.c | 145 ++++
> drivers/clk/berlin/sl261x-pll.h | 14 +
> drivers/i3c/master/dw-i3c-master.c | 24 +-
> drivers/i3c/master/dw-i3c-master.h | 2 +-
> drivers/pinctrl/berlin/Kconfig | 7 +
> drivers/pinctrl/berlin/Makefile | 1 +
> drivers/pinctrl/berlin/berlin.c | 259 +++++-
> drivers/pinctrl/berlin/berlin.h | 17 +-
> drivers/pinctrl/berlin/pinctrl-sl261x.c | 745 ++++++++++++++++++
> drivers/reset/Kconfig | 6 +
> drivers/reset/Makefile | 1 +
> drivers/reset/reset-sl261x.c | 224 ++++++
> include/dt-bindings/clock/syna,sl261x.h | 131 +++
> include/dt-bindings/reset/syna,sl261x-reset.h | 80 ++
> 45 files changed, 3899 insertions(+), 33 deletions(-)
> create mode 100755 Documentation/devicetree/bindings/clock/syna,sl261x-clk.yaml
> create mode 100644 Documentation/devicetree/bindings/mfd/syna,sl261x-gbl.yaml
> create mode 100644 Documentation/devicetree/bindings/reset/syna,sl261x-reset.yaml
> create mode 100644 arch/arm64/boot/dts/synaptics/sl2611-rdk.dts
> create mode 100644 arch/arm64/boot/dts/synaptics/sl2611.dtsi
> create mode 100644 arch/arm64/boot/dts/synaptics/sl2613-rdk.dts
> create mode 100644 arch/arm64/boot/dts/synaptics/sl2613.dtsi
> create mode 100644 arch/arm64/boot/dts/synaptics/sl2615-rdk.dts
> create mode 100644 arch/arm64/boot/dts/synaptics/sl2615.dtsi
> create mode 100644 arch/arm64/boot/dts/synaptics/sl2617-rdk.dts
> create mode 100644 arch/arm64/boot/dts/synaptics/sl2617.dtsi
> create mode 100644 arch/arm64/boot/dts/synaptics/sl2619-rdk.dts
> create mode 100644 arch/arm64/boot/dts/synaptics/sl2619.dtsi
> create mode 100644 arch/arm64/boot/dts/synaptics/sl261x-rdk-common.dtsi
> create mode 100644 drivers/clk/berlin/Kconfig
> create mode 100644 drivers/clk/berlin/sl-clk.c
> create mode 100644 drivers/clk/berlin/sl-clk.h
> create mode 100644 drivers/clk/berlin/sl-sysmgr-clk.c
> create mode 100644 drivers/clk/berlin/sl-sysmgr-clk.h
> create mode 100644 drivers/clk/berlin/sl261x-clks.c
> create mode 100644 drivers/clk/berlin/sl261x-pll.c
> create mode 100644 drivers/clk/berlin/sl261x-pll.h
> create mode 100644 drivers/pinctrl/berlin/pinctrl-sl261x.c
> create mode 100644 drivers/reset/reset-sl261x.c
> create mode 100644 include/dt-bindings/clock/syna,sl261x.h
> create mode 100644 include/dt-bindings/reset/syna,sl261x-reset.h
>
> --
> 2.53.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-09-29 19:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 6:13 Jisheng Zhang
2026-09-29 6:13 ` [PATCH 01/20] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl261x uart Jisheng Zhang
2026-09-29 6:13 ` [PATCH 02/20] dt-bindings: i2c: dw: Add Synaptics sl261x i2c Jisheng Zhang
2026-09-29 20:57 ` Andi Shyti
2026-09-29 6:14 ` [PATCH 03/20] spi: dt-bindings: snps,dw-apb-ssi: Add Synaptics sl261x spi Jisheng Zhang
2026-09-29 6:14 ` [PATCH 04/20] dt-bindings: i3c: dw: support up to two reset lines Jisheng Zhang
2026-09-29 19:40 ` Conor Dooley
2026-09-29 6:14 ` [PATCH 05/20] i3c: dw: switch to array-based exclusive reset control Jisheng Zhang
2026-09-29 15:01 ` Frank Li
2026-09-29 6:14 ` [PATCH 06/20] dt-bindings: i3c: Add Synaptics sl261x i3c Jisheng Zhang
2026-09-29 6:14 ` [PATCH 07/20] arm64: kconfig: let ARCH_BERLIN cover Synaptics arm64 SoCs Jisheng Zhang
2026-09-29 6:14 ` [PATCH 08/20] dt-bindings: reset: add Synaptics SL261X SoCs Jisheng Zhang
2026-09-29 19:44 ` Conor Dooley
2026-09-29 6:14 ` [PATCH 09/20] reset: add Synaptics SL261x reset support Jisheng Zhang
2026-09-29 6:14 ` [PATCH 10/20] pinctrl: berlin: use u16 instead of u8 for the offset Jisheng Zhang
2026-09-29 6:14 ` [PATCH 11/20] pinctrl: berlin: enable module build support Jisheng Zhang
2026-09-29 6:14 ` [PATCH 12/20] pinctrl: berlin: add optional pinconf support Jisheng Zhang
2026-09-29 6:14 ` [PATCH 13/20] dt-bindings: pinctrl: berlin: Support Synaptics SL261X SoCs Jisheng Zhang
2026-09-29 6:14 ` [PATCH 14/20] pinctrl: berlin: support " Jisheng Zhang
2026-09-29 15:34 ` Uwe Kleine-König
2026-09-29 6:14 ` [PATCH 15/20] dt-bindings: clock: add Synaptics SL261X clock Jisheng Zhang
2026-09-29 19:46 ` Conor Dooley
2026-09-29 20:49 ` Rob Herring (Arm)
2026-09-29 6:14 ` [PATCH 16/20] clk: berlin: add Synaptics SL261X SoC clocks and plls Jisheng Zhang
2026-09-29 6:14 ` [PATCH 17/20] dt-bindings: mfd: Add Synaptics SL261x global block binding Jisheng Zhang
2026-09-29 19:55 ` Conor Dooley
2026-09-29 6:14 ` [PATCH 18/20] regulator: dt-bindings: sy8827n: support standard properties Jisheng Zhang
2026-09-29 19:40 ` Conor Dooley
2026-09-29 6:14 ` [PATCH 19/20] dt-bindings: arm: berlin: Add Synaptics SL261X SoC and RDK board Jisheng Zhang
2026-09-29 6:14 ` [PATCH 20/20] arm64: dts: synaptics: " Jisheng Zhang
2026-09-29 19:38 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929-smoked-laurel-087d5a3523a3@spud \
--to=conor@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet+clk@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®