mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuba Piecuch <jpiecuch@google.com>
To: Andrea Righi <arighi@nvidia.com>
Cc: Kuba Piecuch <jpiecuch@google.com>, Tejun Heo <tj@kernel.org>,
	 David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>,
	 Emil Tsalapatis <emil@etsalapatis.com>,
	sched-ext@lists.linux.dev,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] sched_ext: Call ops.dequeue() when a task arrives on a remote local DSQ
Date: Wed, 30 Sep 2026 11:50:40 +0000	[thread overview]
Message-ID: <20260930115044.337291-2-jpiecuch@google.com> (raw)
In-Reply-To: <arwEiZVRNlrOosFi@gpd4>

Hi Andrea,

On Tue, Sep 29, 2026 at 08:33:45PM +0200, Andrea Righi wrote:
> Nit: nothing between the top of enqueue_task_scx() and scx_do_enqueue_task()
> looks at p->scx.sticky_cpu, so p->scx.sticky_cpu = -1 could go right after
> reading it into the local variable, as it was before b75aaea24c9f. Same
> behavior, but it also covers the SCX_TASK_QUEUED early exit, which currently
> leaves p->scx.sticky_cpu set and essentially makes the fix a revert of the
> enqueue side of b75aaea24c9f.

Makes sense, done in v2. The clear is right after the local copy is taken,
guarded by "if (sticky_cpu >= 0)" as before b75aaea24c9f.

> Either way:
> 
> Reviewed-by: Andrea Righi <arighi@nvidia.com>

Thanks! I kept your tag in v2. The only other changes to this patch are
the comment and description rewording that Tejun asked for, plus the
7.1.y prerequisite note.

Thanks,
Kuba

  reply	other threads:[~2026-09-30 11:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 16:17 [PATCHSET sched_ext/for-7.3-fixes] sched_ext: Fix missing ops.dequeue() on remote local DSQ moves Kuba Piecuch
2026-09-29 16:17 ` [PATCH 1/3] selftests/sched_ext: Add a test for " Kuba Piecuch
2026-09-29 18:42   ` Andrea Righi
2026-09-30 11:50     ` Kuba Piecuch
2026-09-29 16:17 ` [PATCH 2/3] sched_ext: Call ops.dequeue() when a task arrives on a remote local DSQ Kuba Piecuch
2026-09-29 18:33   ` Andrea Righi
2026-09-30 11:50     ` Kuba Piecuch [this message]
2026-09-29 16:17 ` [PATCH 3/3] selftests/sched_ext: Enable the dequeue_remote test Kuba Piecuch
2026-09-29 17:13 ` [PATCHSET sched_ext/for-7.3-fixes] sched_ext: Fix missing ops.dequeue() on remote local DSQ moves Tejun Heo
2026-09-29 18:30   ` Andrea Righi
2026-09-30 11:50   ` Kuba Piecuch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930115044.337291-2-jpiecuch@google.com \
    --to=jpiecuch@google.com \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=emil@etsalapatis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®