[PATCH] drm/verisilicon: use ERR_CAST instead of ERR_PTR(PTR_ERR())

[PATCH] drm/verisilicon: use ERR_CAST instead of ERR_PTR(PTR_ERR())

[Aryan Sinha]

ERR_CAST says the same thing without the round trip through an error
code.

Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
---
 drivers/gpu/drm/verisilicon/vs_bridge.c | 2 +-
 drivers/gpu/drm/verisilicon/vs_crtc.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/verisilicon/vs_bridge.c b/drivers/gpu/drm/verisilicon/vs_bridge.c
index dc7c85b07..32f9984d8 100644
--- a/drivers/gpu/drm/verisilicon/vs_bridge.c
+++ b/drivers/gpu/drm/verisilicon/vs_bridge.c
@@ -322,7 +322,7 @@ struct vs_bridge *vs_bridge_init(struct drm_device *drm_dev,
 	bridge = devm_drm_bridge_alloc(drm_dev->dev, struct vs_bridge, base,
 				       bridge_funcs);
 	if (IS_ERR(bridge))
-		return ERR_PTR(PTR_ERR(bridge));
+		return ERR_CAST(bridge);
 
 	bridge->crtc = crtc;
 	bridge->intf = intf;
diff --git a/drivers/gpu/drm/verisilicon/vs_crtc.c b/drivers/gpu/drm/verisilicon/vs_crtc.c
index 0b8a35d09..af8e33c96 100644
--- a/drivers/gpu/drm/verisilicon/vs_crtc.c
+++ b/drivers/gpu/drm/verisilicon/vs_crtc.c
@@ -172,7 +172,7 @@ struct vs_crtc *vs_crtc_init(struct drm_device *drm_dev, struct vs_dc *dc,
 	primary = vs_primary_plane_init(drm_dev, dc);
 	if (IS_ERR(primary)) {
 		drm_err(drm_dev, "Couldn't create the primary plane\n");
-		return ERR_PTR(PTR_ERR(primary));
+		return ERR_CAST(primary);
 	}
 
 	/* Create our cursor plane */
-- 
2.46.0

Re: [PATCH] drm/verisilicon: use ERR_CAST instead of ERR_PTR(PTR_ERR())

[Icenowy Zheng]

在 2026-10-01四的 22:00 +0530，Aryan Sinha写道：
> ERR_CAST says the same thing without the round trip through an error
> code.

Yes, I didn't know this thing yet when I was creating this driver.

```
Reviewed-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
```

Thanks for this patch!

Icenowy

> 
> Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
> ---
>  drivers/gpu/drm/verisilicon/vs_bridge.c | 2 +-
>  drivers/gpu/drm/verisilicon/vs_crtc.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/verisilicon/vs_bridge.c
> b/drivers/gpu/drm/verisilicon/vs_bridge.c
> index dc7c85b07..32f9984d8 100644
> --- a/drivers/gpu/drm/verisilicon/vs_bridge.c
> +++ b/drivers/gpu/drm/verisilicon/vs_bridge.c
> @@ -322,7 +322,7 @@ struct vs_bridge *vs_bridge_init(struct
> drm_device *drm_dev,
>  	bridge = devm_drm_bridge_alloc(drm_dev->dev, struct
> vs_bridge, base,
>  				       bridge_funcs);
>  	if (IS_ERR(bridge))
> -		return ERR_PTR(PTR_ERR(bridge));
> +		return ERR_CAST(bridge);
>  
>  	bridge->crtc = crtc;
>  	bridge->intf = intf;
> diff --git a/drivers/gpu/drm/verisilicon/vs_crtc.c
> b/drivers/gpu/drm/verisilicon/vs_crtc.c
> index 0b8a35d09..af8e33c96 100644
> --- a/drivers/gpu/drm/verisilicon/vs_crtc.c
> +++ b/drivers/gpu/drm/verisilicon/vs_crtc.c
> @@ -172,7 +172,7 @@ struct vs_crtc *vs_crtc_init(struct drm_device
> *drm_dev, struct vs_dc *dc,
>  	primary = vs_primary_plane_init(drm_dev, dc);
>  	if (IS_ERR(primary)) {
>  		drm_err(drm_dev, "Couldn't create the primary
> plane\n");
> -		return ERR_PTR(PTR_ERR(primary));
> +		return ERR_CAST(primary);
>  	}
>  
>  	/* Create our cursor plane */