[PATCH] staging: rtl8723bs: make rtl8723_dequeue_writeport() return bool

[PATCH] staging: rtl8723bs: make rtl8723_dequeue_writeport() return bool

[Hungyu Lin]

rtl8723_dequeue_writeport() returns boolean state and its caller uses the
return value as a boolean.

Change the return type to bool and replace _FAIL with false. Also use bool
for the caller's queue_empty variable.

No functional change.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index 0441e84ea87d..482dd1baf3ca 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -33,7 +33,7 @@ static u8 rtw_sdio_wait_enough_TxOQT_space(struct adapter *padapter, u8 agg_num)
 	return true;
 }
 
-static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
+static bool rtl8723_dequeue_writeport(struct adapter *padapter)
 {
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 	struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
@@ -107,7 +107,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
 	/* pxmitbuf->priv_data = NULL; */
 	rtw_free_xmitbuf(pxmitpriv, pxmitbuf);
 
-	return _FAIL;
+	return false;
 }
 
 /*
@@ -121,7 +121,8 @@ static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
 s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter)
 {
 	struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
-	u8 queue_empty, queue_pending;
+	bool queue_empty;
+	u8 queue_pending;
 	s32 ret;
 
 	if (wait_for_completion_interruptible(&pxmitpriv->xmit_comp)) {
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: make rtl8723_dequeue_writeport() return bool

[Greg Kroah-Hartman]

On Sat, Sep 26, 2026 at 10:58:27AM +0000, Hungyu Lin wrote:
> rtl8723_dequeue_writeport() returns boolean state and its caller uses the
> return value as a boolean.
> 
> Change the return type to bool and replace _FAIL with false. Also use bool
> for the caller's queue_empty variable.
> 
> No functional change.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index 0441e84ea87d..482dd1baf3ca 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -33,7 +33,7 @@ static u8 rtw_sdio_wait_enough_TxOQT_space(struct adapter *padapter, u8 agg_num)
>  	return true;
>  }
>  
> -static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
> +static bool rtl8723_dequeue_writeport(struct adapter *padapter)

Please change the variable that is assigned to the output of this
function as well.

thanks,

greg k-h

Re: [PATCH] staging: rtl8723bs: make rtl8723_dequeue_writeport() return bool

[Hungyu Lin]

> Please change the variable that is assigned to the output of this
> function as well.

I changed queue_empty, which receives the return value of
rtl8723_dequeue_writeport(), from u8 to bool later in the patch:

> -       u8 queue_empty, queue_pending;
> +       bool queue_empty;
> +       u8 queue_pending;

Were you referring to a different variable?

Thanks,
Hungyu Lin

Re: [PATCH] staging: rtl8723bs: make rtl8723_dequeue_writeport() return bool

[Greg Kroah-Hartman]

On Thu, Oct 01, 2026 at 02:42:47AM -0700, Hungyu Lin wrote:
> > Please change the variable that is assigned to the output of this
> > function as well.
> 
> I changed queue_empty, which receives the return value of
> rtl8723_dequeue_writeport(), from u8 to bool later in the patch:
> 
> > -       u8 queue_empty, queue_pending;
> > +       bool queue_empty;
> > +       u8 queue_pending;
> 
> Were you referring to a different variable?

Ah, missed that, can you please resend?

thanks.

greg k-h