mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney@redhat.com>, Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Chen Wang <unicorn_wang@outlook.com>,
	Inochi Amaoto <inochiama@gmail.com>,
	Alexey Charkov <alchark@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Keguang Zhang <keguang.zhang@gmail.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	Hal Feng <hal.feng@starfivetech.com>
Subject: Re: [PATCH v5 0/8] Add StarFive JHB100 syscon modules
Date: Fri, 2 Oct 2026 21:29:54 +0100	[thread overview]
Message-ID: <20261002-causal-handbrake-d5e1331fcfde@spud> (raw)
In-Reply-To: <20260828095608.19955-1-changhuang.liang@starfivetech.com>

[-- Attachment #1: Type: text/plain, Size: 3122 bytes --]

On Fri, Aug 28, 2026 at 02:56:00AM -0700, Changhuang Liang wrote:
> StarFive JHB100 has many syscon modules, as listed below:
> - pcieep0_ecsr_syscon	(PCIe endpoint 0 externel syscon)
> - pcieep1_ecsr_syscon
> - host0_syscon		(Host0 syscon)
> - host1_syscon
> - husb0_syscon		(Host USB 0 syscon)
> - husb1_syscon
> - husbd0_syscon		(Host USB device 0 syscon)
> - husbd1_syscon
> - husbcmn_syscon	(Host USB common syscon)
> - gpu0_syscon		(GPU0 syscon)
> - gpu1_syscon
> - b2h_syscon		(BMC to Host syscon)
> - h2b_syscon		(Host to BMC syscon)
> - vout_syscon		(Video output syscon)
> - pcierp_ecsr_syscon	(PCIe root port externel syscon)
> - pcierp_syscon		(PCIe root port syscon)
> - usb_syscon
> - npu_syscon
> - per0_syscon		(Peripheral 0 syscon)
> - per1_syscon
> - per2_syscon
> - per3_syscon
> - sys0_syscon		(System 0 syscon)
> - sys1_syscon
> - sys2_syscon
> - strap_syscon
> - sfc0_filter_syscon	(SFC0 filter syscon)
> - sfc1_filter_syscon
> - sfc2_filter_syscon
> 
> Some syscon modules contain PLL, reset, and socinfo nodes
> 
> This series depends on the series:
> https://lore.kernel.org/all/20260807112923.191627-1-changhuang.liang@starfivetech.com/
> 
> changes since v4:
> PATCH 2:
> - Constify name pointer
> - flag ==> flags
> - Use FIELD_GET() and FIELD_PREP()
> - Use DEFINE_SHOW_ATTRIBUTE()
> - Replace of_device_get_match_data() with device_get_match_data().
> - Make the driver compatible with both MFD cell instantiation and
>   direct device tree node probing.
> - select STARFIVE_JHB100_SOCINFO and select MFD_SYSCON
> 
> PATCH 3:
> - The changes in PATCH 2 introduced a conflict with PATCH 3, requiring
>   modifications.
> 
> PATCH 7:
> - Binds directly to the "starfive,jhb100-sys0-syscon" node.
> - Instantiates the sys0 PLL clock driver as an MFD child cell,
>   since the syscon region contains both the revision register
>   and PLL controls.
> - Uses devm_* APIs for automatic resource cleanup.
> 
> v4: https://lore.kernel.org/all/20260809015054.210577-1-changhuang.liang@starfivetech.com/
> v3: https://lore.kernel.org/all/20260521012932.24163-1-changhuang.liang@starfivetech.com/
> v2: https://lore.kernel.org/all/20260512083521.3448-1-changhuang.liang@starfivetech.com/
> V1: https://lore.kernel.org/all/20260403054945.467700-1-changhuang.liang@starfivetech.com/
> 
> Changhuang Liang (8):
>   dt-bindings: soc: starfive: Add StarFive JHB100 syscon modules
>   clk: starfive: Add system-0 domain PLL clock driver
>   clk: starfive: Add peripheral-0 domain PLL clock driver
>   clk: starfive: Add Peripheral-1 domain PLL clock driver
>   reset: starfive: Introduce active_low
>   reset: starfive: Add syscon reset driver support
>   soc: starfive: Add socinfo driver for JHB100 SoC
>   riscv: dts: starfive: jhb100: Add syscon nodes

I've applied patches 1 & 7 of this, and included the former in a PR sent
to Brian a few minutes ago. I'll queue patch 8 in my pending content
branch for the jhb100, when you resubmit to resolve the recent driver
feedback, please drop those three patches.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      parent reply	other threads:[~2026-10-02 20:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28  9:56 Changhuang Liang
2026-08-28  9:56 ` [PATCH v5 1/8] dt-bindings: soc: starfive: " Changhuang Liang
2026-08-28  9:56 ` [PATCH v5 2/8] clk: starfive: Add system-0 domain PLL clock driver Changhuang Liang
2026-09-30  8:56   ` Jerome Brunet
2026-10-03 11:02     ` Changhuang Liang
2026-08-28  9:56 ` [PATCH v5 3/8] clk: starfive: Add peripheral-0 " Changhuang Liang
2026-09-30  9:45   ` Jerome Brunet
2026-10-03 11:29     ` Changhuang Liang
2026-08-28  9:56 ` [PATCH v5 4/8] clk: starfive: Add Peripheral-1 " Changhuang Liang
2026-08-28  9:56 ` [PATCH v5 5/8] reset: starfive: Introduce active_low Changhuang Liang
2026-08-28  9:56 ` [PATCH v5 6/8] reset: starfive: Add syscon reset driver support Changhuang Liang
2026-08-28  9:56 ` [PATCH v5 7/8] soc: starfive: Add socinfo driver for JHB100 SoC Changhuang Liang
2026-08-28  9:56 ` [PATCH v5 8/8] riscv: dts: starfive: jhb100: Add syscon nodes Changhuang Liang
2026-09-08 20:06 ` [PATCH v5 0/8] Add StarFive JHB100 syscon modules Conor Dooley
2026-09-09  1:06   ` Changhuang Liang
2026-10-02 20:29 ` Conor Dooley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002-causal-handbrake-d5e1331fcfde@spud \
    --to=conor@kernel.org \
    --cc=alchark@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bmasney@redhat.com \
    --cc=changhuang.liang@starfivetech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hal.feng@starfivetech.com \
    --cc=inochiama@gmail.com \
    --cc=keguang.zhang@gmail.com \
    --cc=kernel@esmil.dk \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=unicorn_wang@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®