* Re: [PATCH net v2] idpf: Fix vport IRQ name leak on request failure
2026-10-04 18:08 [PATCH net v2] idpf: Fix vport IRQ name leak on request failure Yuho Choi
@ 2026-10-04 18:13 ` netdev-bot+sinfo
2026-10-05 10:22 ` Loktionov, Aleksandr
1 sibling, 0 replies; 3+ messages in thread
From: netdev-bot+sinfo @ 2026-10-04 18:13 UTC (permalink / raw)
To: Yuho Choi
Cc: Tony Nguyen, Przemek Kitszel, Simon Horman, Alexander Lobakin,
Joshua Hay, Alan Brady, Sridhar Samudrala, Phani Burra,
Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-wired-lan, netdev, linux-kernel
Hi!
This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:
- How the issue was discovered, e.g. hit in production, hit during
development, syzbot report, manual code inspection, LLM or static
analysis tool scan.
Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account. If the series needs another revision for
other reasons, please include the information in the commit messages
then.
The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH net v2] idpf: Fix vport IRQ name leak on request failure
2026-10-04 18:08 [PATCH net v2] idpf: Fix vport IRQ name leak on request failure Yuho Choi
2026-10-04 18:13 ` netdev-bot+sinfo
@ 2026-10-05 10:22 ` Loktionov, Aleksandr
1 sibling, 0 replies; 3+ messages in thread
From: Loktionov, Aleksandr @ 2026-10-05 10:22 UTC (permalink / raw)
To: Yuho Choi, Nguyen, Anthony L, Kitszel, Przemyslaw
Cc: Simon Horman, Lobakin, Aleksander, Hay, Joshua A, Alan Brady,
Samudrala, Sridhar, Burra, Phani R, Andrew Lunn,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
intel-wired-lan, netdev, linux-kernel
> -----Original Message-----
> From: Yuho Choi <oss.patchbox@gmail.com>
> Sent: Sunday, October 4, 2026 8:09 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>
> Cc: Simon Horman <horms@kernel.org>; Lobakin, Aleksander
> <aleksander.lobakin@intel.com>; Hay, Joshua A
> <joshua.a.hay@intel.com>; Alan Brady <alan.brady@intel.com>;
> Samudrala, Sridhar <sridhar.samudrala@intel.com>; Burra, Phani R
> <phani.r.burra@intel.com>; Andrew Lunn <andrew+netdev@lunn.ch>; David
> S . Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>;
> intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Yuho Choi <oss.patchbox@gmail.com>
> Subject: [PATCH net v2] idpf: Fix vport IRQ name leak on request
> failure
>
> idpf_vport_intr_req_irq() allocates a name for each vector IRQ before
> calling request_irq(). On success, the name is released later through
> kfree(free_irq()), but when request_irq() fails, the error path only
> unwinds the previous vectors and the name for the failed one is
> leaked.
>
> Free the allocated name on the request_irq() failure path, as done for
> the mailbox IRQ in commit 9bff30482c10 ("idpf: Fix mailbox IRQ name
> leak on request failure"). While at it, fail with -ENOMEM when the
> name cannot be allocated instead of requesting the IRQ without a name.
>
> Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
> Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
> ---
> Changes in v2:
> - Correct the Fixes: tag (Simon Horman)
> - Handle kasprintf() failure (Simon Horman)
>
> v1: https://lore.kernel.org/all/20260923234819.702327-1-
> oss.patchbox@gmail.com/
>
> Compile-tested only (x86_64 defconfig + CONFIG_IDPF=m, W=1).
>
> drivers/net/ethernet/intel/idpf/idpf_txrx.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> index 4311ffa30bb1..af3213eae393 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> @@ -4067,12 +4067,17 @@ static int idpf_vport_intr_req_irq(struct
> idpf_vport *vport,
>
> name = kasprintf(GFP_KERNEL, "%s-%s-%s-%d", drv_name,
> if_name,
> vec_name, vector);
> + if (!name) {
> + err = -ENOMEM;
> + goto free_q_irqs;
> + }
>
> err = request_irq(irq_num, idpf_vport_intr_clean_queues,
> 0,
> name, q_vector);
> if (err) {
> netdev_err(vport->netdev,
> "Request_irq failed, error: %d\n", err);
> + kfree(name);
> goto free_q_irqs;
> }
>
>
> base-commit: 551c722f40809618230001baccf219193e22fc5a
> --
> 2.43.0
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread