* [PATCH v1] Revert "drm/virtio: Add pixel blend mode property to cursor plane"
@ 2026-10-07 22:22 Dmitry Osipenko
2026-10-08 9:35 ` Dmitry Osipenko
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Osipenko @ 2026-10-07 22:22 UTC (permalink / raw)
To: David Airlie, Gerd Hoffmann, Gurchetan Singh, Chia-I Wu,
Marek Szyprowski
Cc: dri-devel, virtualization, linux-kernel
The cursor blending mode was added twice because the same change was
applied by accident from different patches. Revert the second patch.
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/dri-devel/ce84d3d2-e78b-4939-aecf-9ef7267bd42a@samsung.com/
Fixes: 6947b78df4d2 ("drm/virtio: Add pixel blend mode property to cursor plane")
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
drivers/gpu/drm/virtio/virtgpu_plane.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
index b422eba42a5f..640815af4098 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -589,7 +589,6 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev,
struct drm_plane *plane;
const uint32_t *formats;
int nformats;
- int ret;
if (type == DRM_PLANE_TYPE_CURSOR) {
formats = virtio_gpu_cursor_formats;
@@ -615,17 +614,5 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev,
drm_plane_create_blend_mode_property(plane,
BIT(DRM_MODE_BLEND_PREMULTI));
- if (type == DRM_PLANE_TYPE_CURSOR) {
- /*
- * The cursor plane exposes a format with an alpha channel,
- * which requires a blend mode property. The host blends
- * premultiplied alpha, matching the property's default.
- */
- ret = drm_plane_create_blend_mode_property(plane,
- BIT(DRM_MODE_BLEND_PREMULTI));
- if (ret)
- return ERR_PTR(ret);
- }
-
return plane;
}
--
2.55.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] Revert "drm/virtio: Add pixel blend mode property to cursor plane"
2026-10-07 22:22 [PATCH v1] Revert "drm/virtio: Add pixel blend mode property to cursor plane" Dmitry Osipenko
@ 2026-10-08 9:35 ` Dmitry Osipenko
2026-10-08 9:40 ` Marek Szyprowski
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Osipenko @ 2026-10-08 9:35 UTC (permalink / raw)
To: David Airlie, Gerd Hoffmann, Gurchetan Singh, Chia-I Wu,
Marek Szyprowski
Cc: dri-devel, virtualization, linux-kernel
On 10/8/26 01:22, Dmitry Osipenko wrote:
> The cursor blending mode was added twice because the same change was
> applied by accident from different patches. Revert the second patch.
>
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Link: https://lore.kernel.org/dri-devel/ce84d3d2-e78b-4939-aecf-9ef7267bd42a@samsung.com/
> Fixes: 6947b78df4d2 ("drm/virtio: Add pixel blend mode property to cursor plane")
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_plane.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
> index b422eba42a5f..640815af4098 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
> @@ -589,7 +589,6 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev,
> struct drm_plane *plane;
> const uint32_t *formats;
> int nformats;
> - int ret;
>
> if (type == DRM_PLANE_TYPE_CURSOR) {
> formats = virtio_gpu_cursor_formats;
> @@ -615,17 +614,5 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev,
> drm_plane_create_blend_mode_property(plane,
> BIT(DRM_MODE_BLEND_PREMULTI));
>
> - if (type == DRM_PLANE_TYPE_CURSOR) {
> - /*
> - * The cursor plane exposes a format with an alpha channel,
> - * which requires a blend mode property. The host blends
> - * premultiplied alpha, matching the property's default.
> - */
> - ret = drm_plane_create_blend_mode_property(plane,
> - BIT(DRM_MODE_BLEND_PREMULTI));
> - if (ret)
> - return ERR_PTR(ret);
> - }
> -
> return plane;
> }
Marek, could you please give your r-b?
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] Revert "drm/virtio: Add pixel blend mode property to cursor plane"
2026-10-08 9:35 ` Dmitry Osipenko
@ 2026-10-08 9:40 ` Marek Szyprowski
0 siblings, 0 replies; 3+ messages in thread
From: Marek Szyprowski @ 2026-10-08 9:40 UTC (permalink / raw)
To: Dmitry Osipenko, David Airlie, Gerd Hoffmann, Gurchetan Singh, Chia-I Wu
Cc: dri-devel, virtualization, linux-kernel
On 08.10.2026 11:35, Dmitry Osipenko wrote:
> On 10/8/26 01:22, Dmitry Osipenko wrote:
>> The cursor blending mode was added twice because the same change was
>> applied by accident from different patches. Revert the second patch.
>>
>> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Link: https://lore.kernel.org/dri-devel/ce84d3d2-e78b-4939-aecf-9ef7267bd42a@samsung.com/
>> Fixes: 6947b78df4d2 ("drm/virtio: Add pixel blend mode property to cursor plane")
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> ---
>> drivers/gpu/drm/virtio/virtgpu_plane.c | 13 -------------
>> 1 file changed, 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
>> index b422eba42a5f..640815af4098 100644
>> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
>> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
>> @@ -589,7 +589,6 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev,
>> struct drm_plane *plane;
>> const uint32_t *formats;
>> int nformats;
>> - int ret;
>>
>> if (type == DRM_PLANE_TYPE_CURSOR) {
>> formats = virtio_gpu_cursor_formats;
>> @@ -615,17 +614,5 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev,
>> drm_plane_create_blend_mode_property(plane,
>> BIT(DRM_MODE_BLEND_PREMULTI));
>>
>> - if (type == DRM_PLANE_TYPE_CURSOR) {
>> - /*
>> - * The cursor plane exposes a format with an alpha channel,
>> - * which requires a blend mode property. The host blends
>> - * premultiplied alpha, matching the property's default.
>> - */
>> - ret = drm_plane_create_blend_mode_property(plane,
>> - BIT(DRM_MODE_BLEND_PREMULTI));
>> - if (ret)
>> - return ERR_PTR(ret);
>> - }
>> -
>> return plane;
>> }
> Marek, could you please give your r-b?
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-08 9:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-07 22:22 [PATCH v1] Revert "drm/virtio: Add pixel blend mode property to cursor plane" Dmitry Osipenko
2026-10-08 9:35 ` Dmitry Osipenko
2026-10-08 9:40 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®