* [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice
@ 2026-10-10 18:36 Hungyu Lin
2026-10-10 18:48 ` Luka Gejak
2026-10-10 18:50 ` Luka Gejak
0 siblings, 2 replies; 4+ messages in thread
From: Hungyu Lin @ 2026-10-10 18:36 UTC (permalink / raw)
To: pkshih
Cc: linux-wireless, linux-kernel, luka.gejak, fiona.klute, kvalo, Hungyu Lin
query_phy_status_ofdm() divides the SNR report by two when filling
pkt_stat->rx_snr, then shifts it again when updating dm_info->rx_snr.
This halves the SNR used for diagnostics and average statistics.
Store the raw report in pkt_stat->rx_snr and convert it only when
updating dm_info->rx_snr, as the other chip drivers do.
Fixes: 61a486bcd782 ("wifi: rtw88: Add rtw8703b.c")
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/net/wireless/realtek/rtw88/rtw8703b.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8703b.c b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
index 25456f0367b2..1920277d626f 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8703b.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
@@ -959,7 +959,7 @@ static void query_phy_status_ofdm(struct rtw_dev *rtwdev, u8 *phy_raw,
val_s8 = phy_status->path_agc[RF_PATH_A].gain & 0x3F;
pkt_stat->rx_power[RF_PATH_A] = (val_s8 * 2) - 110;
pkt_stat->rssi = rtw_phy_rf_power_2_rssi(pkt_stat->rx_power, 1);
- pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2);
+ pkt_stat->rx_snr[RF_PATH_A] = phy_status->path_rxsnr[RF_PATH_A];
/* signal power reported by HW */
val_s8 = phy_status->cck_sig_qual_ofdm_pwdb_all >> 1;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice
2026-10-10 18:36 [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice Hungyu Lin
@ 2026-10-10 18:48 ` Luka Gejak
2026-10-10 18:49 ` Luka Gejak
2026-10-10 18:50 ` Luka Gejak
1 sibling, 1 reply; 4+ messages in thread
From: Luka Gejak @ 2026-10-10 18:48 UTC (permalink / raw)
To: Hungyu Lin, pkshih
Cc: linux-wireless, linux-kernel, fiona.klute, kvalo, Hungyu Lin
October 10, 2026 at 8:36 PM, "Hungyu Lin" <dennylin0707@gmail.com> wrote:
>
> query_phy_status_ofdm() divides the SNR report by two when filling
> pkt_stat->rx_snr, then shifts it again when updating dm_info->rx_snr.
> This halves the SNR used for diagnostics and average statistics.
>
> Store the raw report in pkt_stat->rx_snr and convert it only when
> updating dm_info->rx_snr, as the other chip drivers do.
>
> Fixes: 61a486bcd782 ("wifi: rtw88: Add rtw8703b.c")
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/net/wireless/realtek/rtw88/rtw8703b.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8703b.c b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> index 25456f0367b2..1920277d626f 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> @@ -959,7 +959,7 @@ static void query_phy_status_ofdm(struct rtw_dev *rtwdev, u8 *phy_raw,
> val_s8 = phy_status->path_agc[RF_PATH_A].gain & 0x3F;
> pkt_stat->rx_power[RF_PATH_A] = (val_s8 * 2) - 110;
> pkt_stat->rssi = rtw_phy_rf_power_2_rssi(pkt_stat->rx_power, 1);
> - pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2);
> + pkt_stat->rx_snr[RF_PATH_A] = phy_status->path_rxsnr[RF_PATH_A];
>
> /* signal power reported by HW */
> val_s8 = phy_status->cck_sig_qual_ofdm_pwdb_all >> 1;
Mind explaining why did you resend this?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice
2026-10-10 18:48 ` Luka Gejak
@ 2026-10-10 18:49 ` Luka Gejak
0 siblings, 0 replies; 4+ messages in thread
From: Luka Gejak @ 2026-10-10 18:49 UTC (permalink / raw)
To: Hungyu Lin, pkshih
Cc: linux-wireless, linux-kernel, fiona.klute, kvalo, Hungyu Lin
October 10, 2026 at 8:48 PM, "Luka Gejak" <luka.gejak@linux.dev> wrote:
>
> October 10, 2026 at 8:36 PM, "Hungyu Lin" <dennylin0707@gmail.com> wrote:
>
> >
> > query_phy_status_ofdm() divides the SNR report by two when filling
> > pkt_stat->rx_snr, then shifts it again when updating dm_info->rx_snr.
> > This halves the SNR used for diagnostics and average statistics.
> >
> > Store the raw report in pkt_stat->rx_snr and convert it only when
> > updating dm_info->rx_snr, as the other chip drivers do.
> >
> > Fixes: 61a486bcd782 ("wifi: rtw88: Add rtw8703b.c")
> > Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> > ---
> > drivers/net/wireless/realtek/rtw88/rtw8703b.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtw88/rtw8703b.c b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> > index 25456f0367b2..1920277d626f 100644
> > --- a/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> > @@ -959,7 +959,7 @@ static void query_phy_status_ofdm(struct rtw_dev *rtwdev, u8 *phy_raw,
> > val_s8 = phy_status->path_agc[RF_PATH_A].gain & 0x3F;
> > pkt_stat->rx_power[RF_PATH_A] = (val_s8 * 2) - 110;
> > pkt_stat->rssi = rtw_phy_rf_power_2_rssi(pkt_stat->rx_power, 1);
> > - pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2);
> > + pkt_stat->rx_snr[RF_PATH_A] = phy_status->path_rxsnr[RF_PATH_A];
> >
> > /* signal power reported by HW */
> > val_s8 = phy_status->cck_sig_qual_ofdm_pwdb_all >> 1;
> >
> Mind explaining why did you resend this?
>
Ignore this email I misread the driver name.
Sorry.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice
2026-10-10 18:36 [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice Hungyu Lin
2026-10-10 18:48 ` Luka Gejak
@ 2026-10-10 18:50 ` Luka Gejak
1 sibling, 0 replies; 4+ messages in thread
From: Luka Gejak @ 2026-10-10 18:50 UTC (permalink / raw)
To: Hungyu Lin, pkshih
Cc: linux-wireless, linux-kernel, fiona.klute, kvalo, Hungyu Lin
October 10, 2026 at 8:36 PM, "Hungyu Lin" <dennylin0707@gmail.com mailto:dennylin0707@gmail.com?to=%22Hungyu%20Lin%22%20%3Cdennylin0707%40gmail.com%3E > wrote:
>
> query_phy_status_ofdm() divides the SNR report by two when filling
> pkt_stat->rx_snr, then shifts it again when updating dm_info->rx_snr.
> This halves the SNR used for diagnostics and average statistics.
>
> Store the raw report in pkt_stat->rx_snr and convert it only when
> updating dm_info->rx_snr, as the other chip drivers do.
>
> Fixes: 61a486bcd782 ("wifi: rtw88: Add rtw8703b.c")
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/net/wireless/realtek/rtw88/rtw8703b.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8703b.c b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> index 25456f0367b2..1920277d626f 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8703b.c
> @@ -959,7 +959,7 @@ static void query_phy_status_ofdm(struct rtw_dev *rtwdev, u8 *phy_raw,
> val_s8 = phy_status->path_agc[RF_PATH_A].gain & 0x3F;
> pkt_stat->rx_power[RF_PATH_A] = (val_s8 * 2) - 110;
> pkt_stat->rssi = rtw_phy_rf_power_2_rssi(pkt_stat->rx_power, 1);
> - pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2);
> + pkt_stat->rx_snr[RF_PATH_A] = phy_status->path_rxsnr[RF_PATH_A];
>
> /* signal power reported by HW */
> val_s8 = phy_status->cck_sig_qual_ofdm_pwdb_all >> 1;
>
Looking good to me.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-10 18:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-10 18:36 [PATCH] wifi: rtw88: 8703b: avoid converting RX SNR twice Hungyu Lin
2026-10-10 18:48 ` Luka Gejak
2026-10-10 18:49 ` Luka Gejak
2026-10-10 18:50 ` Luka Gejak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®