* Re: [PATCH] tools/dma: fix building with O=
2026-10-11 22:33 ` [PATCH] tools/dma: fix building with O= Sasha Levin
@ 2026-10-13 2:09 ` Qinxin Xia
2026-10-13 11:42 ` Marek Szyprowski
1 sibling, 0 replies; 3+ messages in thread
From: Qinxin Xia @ 2026-10-13 2:09 UTC (permalink / raw)
To: Sasha Levin, Barry Song, Marek Szyprowski; +Cc: stable, iommu, linux-kernel
On 2026/10/12 06:33:31, Sasha Levin <sashal@kernel.org> wrote:
> With O= set, "all" depends on $(OUTPUT)dma_map_benchmark, but the only
> rule builds dma_map_benchmark in the source directory, and built-in
> rules are disabled:
>
> make: *** No rule to make target '<O>/dma_map_benchmark', needed by 'all'. Stop.
>
> Build $(OUTPUT)dma_map_benchmark.
>
> Fixes: f74ee32963f1b ("tools/dma: move dma_map_benchmark from selftests to tools/dma")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> tools/dma/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/dma/Makefile b/tools/dma/Makefile
> index e4abf37bf020c..0c239a6b9eae5 100644
> --- a/tools/dma/Makefile
> +++ b/tools/dma/Makefile
> @@ -38,8 +38,8 @@ prepare: $(OUTPUT)include/linux/map_benchmark.h
> FORCE:
>
> DMA_MAP_BENCHMARK = dma_map_benchmark
> -$(DMA_MAP_BENCHMARK): prepare FORCE
> - $(CC) $(CFLAGS) $(DMA_MAP_BENCHMARK).c -o $(DMA_MAP_BENCHMARK)
> +$(OUTPUT)$(DMA_MAP_BENCHMARK): prepare FORCE
> + $(CC) $(CFLAGS) $(DMA_MAP_BENCHMARK).c -o $@
>
> clean:
> rm -f $(ALL_PROGRAMS)
Acked-by: Qinxin Xia <xiaqinxin@huawei.com>
--
Thanks,
Qinxin
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tools/dma: fix building with O=
2026-10-11 22:33 ` [PATCH] tools/dma: fix building with O= Sasha Levin
2026-10-13 2:09 ` Qinxin Xia
@ 2026-10-13 11:42 ` Marek Szyprowski
1 sibling, 0 replies; 3+ messages in thread
From: Marek Szyprowski @ 2026-10-13 11:42 UTC (permalink / raw)
To: Sasha Levin, Barry Song, Qinxin Xia; +Cc: stable, iommu, linux-kernel
On 12.10.2026 00:33, Sasha Levin wrote:
> With O= set, "all" depends on $(OUTPUT)dma_map_benchmark, but the only
> rule builds dma_map_benchmark in the source directory, and built-in
> rules are disabled:
>
> make: *** No rule to make target '<O>/dma_map_benchmark', needed by 'all'. Stop.
>
> Build $(OUTPUT)dma_map_benchmark.
>
> Fixes: f74ee32963f1b ("tools/dma: move dma_map_benchmark from selftests to tools/dma")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Applied to dma-mapping-for-next. Thanks!
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 3+ messages in thread