From: Huang Wei <huangwei@kylinos.cn>
To: ilpo.jarvinen@linux.intel.com
Cc: mpearson-lenovo@squebb.ca, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, huangwei@kylinos.cn
Subject: [PATCH] Revert "platform/x86: thinkpad_acpi: Add X9-14 Gen 1 to non-standard thermal/fan quirk tables"
Date: Tue, 13 Oct 2026 15:07:40 +0800 [thread overview]
Message-ID: <20261013070740.789934-1-huangwei@kylinos.cn> (raw)
In-Reply-To: <20260918161539.2676619-1-huangwei@kylinos.cn>
This reverts commit bb0f3a5d6b9844b70ad696b9470762028f6d86ec.
Lenovo's firmware team has verified that the X9-14 Gen 1 uses EC
register offsets that are unique to this platform, rather than the
shared non-standard ECFW layout of the models already covered by the
quirk tables. Applying the generic quirk would make the driver read
the wrong registers and report bogus temperatures. Lenovo is working
on the correct solution based on an updated EC register specification.
Link: https://lore.kernel.org/all/000acb24-7aef-4718-89ea-0dffd1ab34d9@app.fastmail.com/
Signed-off-by: Huang Wei <huangwei@kylinos.cn>
---
drivers/platform/x86/lenovo/thinkpad_acpi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c
index 498139ac8f4b..6dd7c28fc0db 100644
--- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
+++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
@@ -6021,7 +6021,6 @@ static const struct tpacpi_quirk thermal_quirk_table[] __initconst = {
TPACPI_Q_LNV3('R', '0', 'T', true), /* 11e Gen5 GL*/
TPACPI_Q_LNV3('R', '1', 'D', true), /* 11e Gen5 GL-R*/
TPACPI_Q_LNV3('R', '0', 'V', true), /* 11e Gen5 KL-Y*/
- TPACPI_Q_LNV3('N', '4', 'D', true), /* X9-14 Gen 1 */
};
static enum thermal_access_mode thermal_read_mode;
@@ -8846,7 +8845,6 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = {
TPACPI_Q_LNV3('R', '0', 'T', TPACPI_FAN_NS), /* 11e Gen5 GL */
TPACPI_Q_LNV3('R', '1', 'D', TPACPI_FAN_NS), /* 11e Gen5 GL-R */
TPACPI_Q_LNV3('R', '0', 'V', TPACPI_FAN_NS), /* 11e Gen5 KL-Y */
- TPACPI_Q_LNV3('N', '4', 'D', TPACPI_FAN_NS), /* X9-14 Gen 1 */
TPACPI_Q_LNV('H', '3', TPACPI_FAN_NS), /* Edge E330 */
TPACPI_Q_LNV3('N', '1', 'O', TPACPI_FAN_NOFAN), /* X1 Tablet (2nd gen) */
TPACPI_Q_LNV3('R', '0', 'Q', TPACPI_FAN_DECRPM),/* L480 */
--
2.25.1
next prev parent reply other threads:[~2026-10-13 7:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 7:30 [PATCH] platform/x86: thinkpad_acpi: Add X9-14 Gen 1 to non-standard thermal/fan quirk tables Huang Wei
2026-09-18 15:15 ` Ilpo Järvinen
2026-09-18 16:15 ` [PATCH v2] " Huang Wei
2026-09-18 18:25 ` Ilpo Järvinen
2026-09-18 22:00 ` Mark Pearson
2026-09-30 12:20 ` Mark Pearson
2026-10-02 12:55 ` Mark Pearson
2026-10-12 3:41 ` Huang Wei
2026-10-12 11:58 ` Ilpo Järvinen
2026-10-13 7:07 ` Huang Wei [this message]
2026-10-13 17:14 ` [PATCH] Revert "platform/x86: thinkpad_acpi: Add X9-14 Gen 1 to non-standard thermal/fan quirk tables" Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013070740.789934-1-huangwei@kylinos.cn \
--to=huangwei@kylinos.cn \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®