Re: [PATCH] Revert "platform/x86: thinkpad_acpi: Add X9-14 Gen 1 to non-standard thermal/fan quirk tables"

["Mark Pearson" <mpearson-lenovo@squebb.ca>]

Thanks Huang

On Tue, Oct 13, 2026, at 3:07 AM, Huang Wei wrote:
> This reverts commit bb0f3a5d6b9844b70ad696b9470762028f6d86ec.
>
> Lenovo's firmware team has verified that the X9-14 Gen 1 uses EC
> register offsets that are unique to this platform, rather than the
> shared non-standard ECFW layout of the models already covered by the
> quirk tables. Applying the generic quirk would make the driver read
> the wrong registers and report bogus temperatures. Lenovo is working
> on the correct solution based on an updated EC register specification.
>

You're fast :) I was going to say we'll just post on top of your original patch now as it's been accepted. Didn't want to create extra work for you - but thanks for doing this.
I'll let the team know to get moving on the proper fix - there's been some back and forth with the FW team on the details.

Thanks
Mark

> Link: 
> https://lore.kernel.org/all/000acb24-7aef-4718-89ea-0dffd1ab34d9@app.fastmail.com/
> Signed-off-by: Huang Wei <huangwei@kylinos.cn>
> ---
>  drivers/platform/x86/lenovo/thinkpad_acpi.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c 
> b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> index 498139ac8f4b..6dd7c28fc0db 100644
> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> @@ -6021,7 +6021,6 @@ static const struct tpacpi_quirk 
> thermal_quirk_table[] __initconst = {
>  	TPACPI_Q_LNV3('R', '0', 'T', true),	/* 11e Gen5 GL*/
>  	TPACPI_Q_LNV3('R', '1', 'D', true),	/* 11e Gen5 GL-R*/
>  	TPACPI_Q_LNV3('R', '0', 'V', true),	/* 11e Gen5 KL-Y*/
> -	TPACPI_Q_LNV3('N', '4', 'D', true),	/* X9-14 Gen 1 */
>  };
>
>  static enum thermal_access_mode thermal_read_mode;
> @@ -8846,7 +8845,6 @@ static const struct tpacpi_quirk 
> fan_quirk_table[] __initconst = {
>  	TPACPI_Q_LNV3('R', '0', 'T', TPACPI_FAN_NS),	/* 11e Gen5 GL */
>  	TPACPI_Q_LNV3('R', '1', 'D', TPACPI_FAN_NS),	/* 11e Gen5 GL-R */
>  	TPACPI_Q_LNV3('R', '0', 'V', TPACPI_FAN_NS),	/* 11e Gen5 KL-Y */
> -	TPACPI_Q_LNV3('N', '4', 'D', TPACPI_FAN_NS),	/* X9-14 Gen 1 */
>  	TPACPI_Q_LNV('H', '3', TPACPI_FAN_NS),		/* Edge E330 */
>  	TPACPI_Q_LNV3('N', '1', 'O', TPACPI_FAN_NOFAN),	/* X1 Tablet (2nd 
> gen) */
>  	TPACPI_Q_LNV3('R', '0', 'Q', TPACPI_FAN_DECRPM),/* L480 */
>
> --
> 2.25.1