* [PATCH] MAINTAINERS: add missing virtio/vdpa/vduse/vhost headers
@ 2026-10-15 9:40 Eugenio Pérez
2026-10-15 9:44 ` Eugenio Perez Martin
2026-10-15 13:30 ` Stefano Garzarella
0 siblings, 2 replies; 3+ messages in thread
From: Eugenio Pérez @ 2026-10-15 9:40 UTC (permalink / raw)
To: mst
Cc: Stefano Garzarella, linux-kernel, Eugenio Pérez,
Laurent Vivier, virtualization, Jason Wang
Several headers related to virtio, vDPA, VDUSE and vhost were not
covered by any specific MAINTAINERS entry and fell through to the
catch-all THE REST section:
- include/linux/device-id/virtio.h: not matched by the existing
"include/linux/virtio*.h" glob, which only matches files directly
under include/linux/ and does not recurse into subdirectories.
- include/uapi/linux/vdpa.h: the in-kernel include/linux/vdpa.h was
listed under VIRTIO CORE but its UAPI companion was missing; the
"include/uapi/linux/virtio_*.h" pattern does not match it because
the filename lacks the "virtio_" prefix.
- include/uapi/linux/vduse.h: there is no dedicated VDUSE section in
MAINTAINERS; the driver lives under drivers/vdpa/ which is already
covered by VIRTIO CORE, so the UAPI header belongs there too.
- include/uapi/linux/vhost_types.h: the VIRTIO HOST (VHOST) section
explicitly lists include/uapi/linux/vhost.h but omits its companion
types header.
Assisted-by: claude-sonnet 4.6
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
MAINTAINERS | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f53047aa8d3c..9f85882f307e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -28903,9 +28903,12 @@ F: drivers/block/virtio_blk.c
F: drivers/crypto/virtio/
F: drivers/vdpa/
F: drivers/virtio/
+F: include/linux/device-id/virtio.h
F: include/linux/vdpa.h
F: include/linux/virtio*.h
F: include/linux/vringh.h
+F: include/uapi/linux/vdpa.h
+F: include/uapi/linux/vduse.h
F: include/uapi/linux/virtio_*.h
F: net/vmw_vsock/virtio*
F: tools/virtio/
@@ -28979,6 +28982,7 @@ F: drivers/vhost/
F: include/linux/sched/vhost_task.h
F: include/linux/vhost_iotlb.h
F: include/uapi/linux/vhost.h
+F: include/uapi/linux/vhost_types.h
F: kernel/vhost_task.c
VIRTIO HOST (VHOST-SCSI)
--
2.56.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MAINTAINERS: add missing virtio/vdpa/vduse/vhost headers
2026-10-15 9:40 [PATCH] MAINTAINERS: add missing virtio/vdpa/vduse/vhost headers Eugenio Pérez
@ 2026-10-15 9:44 ` Eugenio Perez Martin
2026-10-15 13:30 ` Stefano Garzarella
1 sibling, 0 replies; 3+ messages in thread
From: Eugenio Perez Martin @ 2026-10-15 9:44 UTC (permalink / raw)
To: mst
Cc: Stefano Garzarella, linux-kernel, Laurent Vivier, virtualization,
Jason Wang
On Thu, Oct 15, 2026 at 11:40 AM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> Several headers related to virtio, vDPA, VDUSE and vhost were not
> covered by any specific MAINTAINERS entry and fell through to the
> catch-all THE REST section:
>
> - include/linux/device-id/virtio.h: not matched by the existing
> "include/linux/virtio*.h" glob, which only matches files directly
> under include/linux/ and does not recurse into subdirectories.
>
> - include/uapi/linux/vdpa.h: the in-kernel include/linux/vdpa.h was
> listed under VIRTIO CORE but its UAPI companion was missing; the
> "include/uapi/linux/virtio_*.h" pattern does not match it because
> the filename lacks the "virtio_" prefix.
>
> - include/uapi/linux/vduse.h: there is no dedicated VDUSE section in
> MAINTAINERS; the driver lives under drivers/vdpa/ which is already
> covered by VIRTIO CORE, so the UAPI header belongs there too.
>
> - include/uapi/linux/vhost_types.h: the VIRTIO HOST (VHOST) section
> explicitly lists include/uapi/linux/vhost.h but omits its companion
> types header.
>
> Assisted-by: claude-sonnet 4.6
I forgot:
Suggested-by: Michael S. Tsirkin <mst@redhat.com>
Also, in case it is useful, the model looked for all the potentially
missed files.
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> MAINTAINERS | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f53047aa8d3c..9f85882f307e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -28903,9 +28903,12 @@ F: drivers/block/virtio_blk.c
> F: drivers/crypto/virtio/
> F: drivers/vdpa/
> F: drivers/virtio/
> +F: include/linux/device-id/virtio.h
> F: include/linux/vdpa.h
> F: include/linux/virtio*.h
> F: include/linux/vringh.h
> +F: include/uapi/linux/vdpa.h
> +F: include/uapi/linux/vduse.h
> F: include/uapi/linux/virtio_*.h
> F: net/vmw_vsock/virtio*
> F: tools/virtio/
> @@ -28979,6 +28982,7 @@ F: drivers/vhost/
> F: include/linux/sched/vhost_task.h
> F: include/linux/vhost_iotlb.h
> F: include/uapi/linux/vhost.h
> +F: include/uapi/linux/vhost_types.h
> F: kernel/vhost_task.c
>
> VIRTIO HOST (VHOST-SCSI)
> --
> 2.56.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MAINTAINERS: add missing virtio/vdpa/vduse/vhost headers
2026-10-15 9:40 [PATCH] MAINTAINERS: add missing virtio/vdpa/vduse/vhost headers Eugenio Pérez
2026-10-15 9:44 ` Eugenio Perez Martin
@ 2026-10-15 13:30 ` Stefano Garzarella
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2026-10-15 13:30 UTC (permalink / raw)
To: Eugenio Pérez
Cc: mst, linux-kernel, Laurent Vivier, virtualization, Jason Wang
On Thu, Oct 15, 2026 at 11:40:49AM +0200, Eugenio Pérez wrote:
>Several headers related to virtio, vDPA, VDUSE and vhost were not
>covered by any specific MAINTAINERS entry and fell through to the
>catch-all THE REST section:
>
>- include/linux/device-id/virtio.h: not matched by the existing
> "include/linux/virtio*.h" glob, which only matches files directly
> under include/linux/ and does not recurse into subdirectories.
>
>- include/uapi/linux/vdpa.h: the in-kernel include/linux/vdpa.h was
> listed under VIRTIO CORE but its UAPI companion was missing; the
> "include/uapi/linux/virtio_*.h" pattern does not match it because
> the filename lacks the "virtio_" prefix.
>
Maybe we should tell to the agent to avoid useless info in the commit
message, I mean it's pretty clear that "include/uapi/linux/virtio_*.h"
will not match include/uapi/linux/vdpa.h ...
>- include/uapi/linux/vduse.h: there is no dedicated VDUSE section in
> MAINTAINERS; the driver lives under drivers/vdpa/ which is already
> covered by VIRTIO CORE, so the UAPI header belongs there too.
>
>- include/uapi/linux/vhost_types.h: the VIRTIO HOST (VHOST) section
> explicitly lists include/uapi/linux/vhost.h but omits its companion
> types header.
>
>Assisted-by: claude-sonnet 4.6
nit: the suggested tag in Documentation/process/coding-assistants.rst is
Assisted-by: LLM [TOOL1] [TOOL2]
>Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
>---
> MAINTAINERS | 4 ++++
> 1 file changed, 4 insertions(+)
Anyway, the patch LGTM:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Maybe to be fixed in another patch, LLM here found also others files
related to virtio/vhost/vdpa uncovered:
Other virtio-related files not covered by any virtio/vhost/vdpa
MAINTAINERS entry:
- Documentation/ABI/testing/sysfs-fs-virtiofs
Current: no section (THE REST only)
Suggested: VIRTIO FILE SYSTEM
- Documentation/userspace-api/vduse.rst
Current: DOCUMENTATION only
Suggested: VIRTIO CORE (already lists sysfs-class-vduse)
- include/trace/events/vsock_virtio_transport_common.h
Current: TRACING only
Suggested: VIRTIO AND VHOST VSOCK DRIVER
(next to virtio_transport_common.c)
- drivers/nvdimm/virtio_pmem.h
Current: LIBNVDIMM only
Suggested: VIRTIO PMEM DRIVER (lists virtio_pmem.c and
nd_virtio.c, but not the header)
- Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
Current: GPIO + DT bindings
Suggested: VIRTIO GPIO DRIVER
- Documentation/devicetree/bindings/i2c/i2c-virtio.yaml
Current: I2C + DT bindings
Suggested: VIRTIO I2C DRIVER
- Documentation/networking/device_drivers/ethernet/amd/pds_vdpa.rst
Current: NETWORKING + DOCUMENTATION
Suggested: PDS DSC VIRTIO DATA PATH ACCELERATOR
(only lists drivers/vdpa/pds/)
- include/linux/mlx5/mlx5_ifc_vdpa.h
Current: MLX5 core/IB only
Suggested: possibly MELLANOX MLX5 VDPA DRIVER (debatable, it's an
mlx5 interface header)
I'll send a fix for the vsock events.
Thanks,
Stefano
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-15 13:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-15 9:40 [PATCH] MAINTAINERS: add missing virtio/vdpa/vduse/vhost headers Eugenio Pérez
2026-10-15 9:44 ` Eugenio Perez Martin
2026-10-15 13:30 ` Stefano Garzarella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®