From: chitranshmandhaniya@gmail.com
To: hansg@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Chitransh_Mandhaniya@dell.com
Subject: [PATCH v4 0/2] platform/x86: dell-uart-backlight: handle stray EC byte in responses
Date: Sat, 17 Oct 2026 13:07:02 +0530 [thread overview]
Message-ID: <20261017073704.606497-1-chitranshmandhaniya@gmail.com> (raw)
In-Reply-To: <20261004110333.5790-1-chitranshmandhaniya@gmail.com>
From: Chitransh Mandhaniya <Chitransh_Mandhaniya@dell.com>
On some Dell All-in-One machines the EC sporadically inserts a spurious
byte after the command echo in UART backlight response frames. This
causes a checksum mismatch and the driver returns -EIO to userspace.
Patch 1 is a preparatory refactor: extract the byte-level response
parsing into a dedicated dell_uart_bl_receive_data() helper with no
functional change.
Patch 2 adds single-attempt stray-byte recovery inside that helper.
When a checksum mismatch occurs on a frame longer than the minimum
size, the suspect byte is dropped, the buffer is shifted down, and
status remains -EBUSY so serdev re-delivers the real checksum byte
naturally.
Tested on Dell OptiPlex AIO 7410 65W (board 0TKWC4) where the EC
inserts a stray byte on every get-brightness response.
v3 -> v4:
- Perform resync inside dell_uart_bl_receive_data() rather than in
the wrapper; status stays -EBUSY so serdev re-delivers the
checksum byte without additional handling in the caller
v2 -> v3:
- Guard resync with resp_idx == resp_len to prevent memmove on a
truncated or out-of-range length field
v1 -> v2:
- Extract dell_uart_bl_receive_data() helper instead of using a
for-loop with a pass counter
- Split into two patches: refactor then feature
Chitransh Mandhaniya (2):
platform/x86: dell-uart-backlight: extract dell_uart_bl_receive_data()
helper
platform/x86: dell-uart-backlight: recover from stray EC response byte
.../platform/x86/dell/dell-uart-backlight.c | 52 +++++++++++++------
1 file changed, 37 insertions(+), 15 deletions(-)
--
2.43.0
next prev parent reply other threads:[~2026-10-17 7:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 11:03 [PATCH] platform/x86: dell-uart-backlight: recover from stray EC response byte chitranshmandhaniya
2026-10-14 11:50 ` Ilpo Järvinen
2026-10-15 7:43 ` [PATCH v2 0/2] " chitranshmandhaniya
2026-10-15 7:43 ` [PATCH v2 1/2] platform/x86: dell-uart-backlight: extract dell_uart_bl_receive_data() helper chitranshmandhaniya
2026-10-15 7:43 ` [PATCH v2 2/2] platform/x86: dell-uart-backlight: recover from stray EC response byte chitranshmandhaniya
2026-10-15 10:12 ` Ilpo Järvinen
2026-10-15 10:24 ` Ilpo Järvinen
2026-10-16 9:33 ` [PATCH v3 0/2] platform/x86: dell-uart-backlight: stray byte recovery and cleanup chitranshmandhaniya
2026-10-16 9:33 ` [PATCH v3 1/2] platform/x86: dell-uart-backlight: extract chitranshmandhaniya
2026-10-16 9:33 ` [PATCH v3 2/2] platform/x86: dell-uart-backlight: recover from stray chitranshmandhaniya
2026-10-16 10:07 ` Ilpo Järvinen
2026-10-17 7:37 ` chitranshmandhaniya [this message]
2026-10-17 7:37 ` [PATCH v4 1/2] platform/x86: dell-uart-backlight: extract dell_uart_bl_receive_data() helper chitranshmandhaniya
2026-10-17 7:37 ` [PATCH v4 2/2] platform/x86: dell-uart-backlight: recover from stray EC response byte chitranshmandhaniya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261017073704.606497-1-chitranshmandhaniya@gmail.com \
--to=chitranshmandhaniya@gmail.com \
--cc=Chitransh_Mandhaniya@dell.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®