mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Nikhil Gautam <nikhilgtr@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	Matt Ranostay <matt@ranostay.sg>
Subject: Re: [PATCH 1/1] iio: atlas-ezo: Fix humidity channel read support
Date: Sun, 18 Oct 2026 00:34:24 +0100	[thread overview]
Message-ID: <20261018003424.5fc050a8@jic23-hlaptop> (raw)
In-Reply-To: <20261018003129.533effef@jic23-hlaptop>

On Sun, 18 Oct 2026 00:31:29 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Tue, 13 Oct 2026 22:15:23 +0530
> Nikhil Gautam <nikhilgtr@gmail.com> wrote:
> 
> > Hi Joshua, Andy,
> > 
> > Thanks for the review and feedback.
> > 
> > I checked the Git history and found that the channel type check was 
> > already present
> > in commit dc3ebfc ("iio: chemical: atlas-ezo-sensor: add humidity sensor 
> > support").
> > It was not removed when humidity sensor support was introduced, and
> > I couldn't find any commit message explaining the original intent of the 
> > check.
> > 
> > Regarding the potential I2C read issue reported by Sashiko,
> > I'll investigate it and address it in a separate patch series.
> > 
> > I'll also omit the cover letter for future single-patch submissions.  
> 
> Matt normally gets back reasonably quickly so +CC but I'll
> assume this is just one of those last minute editing errors and
> apply the fix in the meantime.
> 
> So applied to the fxies-togreg branch of iio.git and marked for stable.
fixes-togreg that is.

I also added the missing fixes tag to point to the introduction of
the humidity sensor.

J
> 
> Thanks,
> 
> Jonathan
> 
> > 
> > Thanks,
> > Nikhil
> > 
> > On 13-10-2026 02:15 am, Andy Shevchenko wrote:  
> > > On Mon, Oct 12, 2026 at 05:15:53PM +0530, Nikhil Gautam wrote:    
> > >> The atlas_ezo_read_raw() function rejects channels that are not of
> > >> type IIO_CONCENTRATION, preventing the relative humidity channel
> > >> from reading raw and scale values.
> > >>
> > >> Remove the early channel type check to allow both concentration
> > >> and relative humidity channels to reach the mask-specific handling.    
> > > Have you checked the Git history on this change? Anything interesting there?
> > >    
> >   
> 
> 


  reply	other threads:[~2026-10-17 23:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 11:45 [PATCH 0/1] " Nikhil Gautam
2026-10-12 11:45 ` [PATCH 1/1] " Nikhil Gautam
2026-10-12 13:56   ` Joshua Crofts
2026-10-12 20:45   ` Andy Shevchenko
2026-10-13 16:45     ` Nikhil Gautam
2026-10-17 23:31       ` Jonathan Cameron
2026-10-17 23:34         ` Jonathan Cameron [this message]
2026-10-18  2:28         ` Matt Ranostay
2026-10-18 18:02           ` Jonathan Cameron
2026-10-12 13:57 ` [PATCH 0/1] " Joshua Crofts
2026-10-12 20:43 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261018003424.5fc050a8@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@ranostay.sg \
    --cc=nikhilgtr@gmail.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®