Re: [PATCH 1/1] iio: atlas-ezo: Fix humidity channel read support

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 18 Oct 2026 02:28:01 +0000
Matt Ranostay <matt@ranostay.sg> wrote:

> On Sunday, October 18th, 2026 at 07:31, Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > On Tue, 13 Oct 2026 22:15:23 +0530
> > Nikhil Gautam <nikhilgtr@gmail.com> wrote:
> >   
> > > Hi Joshua, Andy,
> > >
> > > Thanks for the review and feedback.
> > >
> > > I checked the Git history and found that the channel type check was
> > > already present
> > > in commit dc3ebfc ("iio: chemical: atlas-ezo-sensor: add humidity sensor
> > > support").
> > > It was not removed when humidity sensor support was introduced, and
> > > I couldn't find any commit message explaining the original intent of the
> > > check.
> > >
> > > Regarding the potential I2C read issue reported by Sashiko,
> > > I'll investigate it and address it in a separate patch series.
> > >
> > > I'll also omit the cover letter for future single-patch submissions.  
> > 
> > Matt normally gets back reasonably quickly so +CC but I'll
> > assume this is just one of those last minute editing errors and
> > apply the fix in the meantime.  
> 
> Yeah this was probably an oversight on my part. Since the humidity sensor support came later, and don't think I actually ever had this EVO sensor.
> So the patch LGTM.
> 
> Reviewed-by: Matt Ranostay <matt@ranostay.sg>
Thanks and tag added.

J
> 
> > 
> > So applied to the fxies-togreg branch of iio.git and marked for stable.
> > 
> > Thanks,
> > 
> > Jonathan
> >   
> > >
> > > Thanks,
> > > Nikhil
> > >
> > > On 13-10-2026 02:15 am, Andy Shevchenko wrote:  
> > > > On Mon, Oct 12, 2026 at 05:15:53PM +0530, Nikhil Gautam wrote:  
> > > >> The atlas_ezo_read_raw() function rejects channels that are not of
> > > >> type IIO_CONCENTRATION, preventing the relative humidity channel
> > > >> from reading raw and scale values.
> > > >>
> > > >> Remove the early channel type check to allow both concentration
> > > >> and relative humidity channels to reach the mask-specific handling.  
> > > > Have you checked the Git history on this change? Anything interesting there?
> > > >  
> > >  
> > 
> >