mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: <lpieralisi@kernel.org>, <kwilczynski@kernel.org>,
	<mani@kernel.org>, <bhelgaas@google.com>,
	<linux-pci@vger.kernel.org>
Cc: <robh@kernel.org>, <thierry.reding@kernel.org>,
	<jonathanh@nvidia.com>, <kishon@kernel.org>,
	<Frank.Li@kernel.org>, <vidyas@nvidia.com>, <cassel@kernel.org>,
	<den@valinux.co.jp>, <marco.crivellari@suse.com>,
	<andriy.shevchenko@linux.intel.com>,
	<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<mmaddireddy@nvidia.com>
Subject: [PATCH v2 08/10] PCI: tegra194: Guard Endpoint PLL-off error path
Date: Wed, 21 Oct 2026 11:43:47 +0530	[thread overview]
Message-ID: <20261021061349.1265704-9-mmaddireddy@nvidia.com> (raw)
In-Reply-To: <20261021061349.1265704-1-mmaddireddy@nvidia.com>

The Endpoint PERST# deassert path initializes the external-refclk PLL only
when enable_ext_refclk is set, but the error unwind always sent the PLL-off
request.

Guard the PLL-off request with enable_ext_refclk so Tegra234 Endpoint
configurations that did not enable the PLL do not send a spurious BPMP
PLL-off command.

Fixes: a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
---
Changes V1 -> V2: None

 drivers/pci/controller/dwc/pcie-tegra194.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 0e6224b6751d..de14a23f9a4d 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -1973,7 +1973,8 @@ static void pex_ep_event_pex_rst_deassert(struct tegra_pcie_dw *pcie)
 fail_core_apb_rst:
 	clk_disable_unprepare(pcie->core_clk);
 fail_core_clk_enable:
-	tegra_pcie_bpmp_set_pll_state(pcie, false);
+	if (pcie->enable_ext_refclk)
+		tegra_pcie_bpmp_set_pll_state(pcie, false);
 fail_pll_init:
 	tegra_pcie_bpmp_set_ctrl_state(pcie, false);
 fail_set_ctrl_state:
-- 
2.34.1


  parent reply	other threads:[~2026-10-21  6:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21  6:13 [PATCH v2 00/10] PCI: tegra194: Fix EP and Root Port corner cases Manikanta Maddireddy
2026-10-21  6:13 ` [PATCH v2 01/10] PCI: tegra194: Propagate REFCLK select GPIO errors Manikanta Maddireddy
2026-10-21 15:14   ` Frank Li
2026-10-21  6:13 ` [PATCH v2 02/10] PCI: tegra194: Check core reset deassertion Manikanta Maddireddy
2026-10-21 15:16   ` Frank Li
2026-10-21  6:13 ` [PATCH v2 03/10] PCI: tegra194: Fix Endpoint PERST# IRQ suspend race Manikanta Maddireddy
2026-10-21 15:19   ` Frank Li
2026-10-21  6:13 ` [PATCH v2 04/10] PCI: tegra194: Do not skip no-link Root Port remove cleanup Manikanta Maddireddy
2026-10-21 15:22   ` Frank Li
2026-10-21  6:13 ` [PATCH v2 05/10] PCI: tegra194: Check for 16 GT/s capability before programming Manikanta Maddireddy
2026-10-21 15:24   ` Frank Li
2026-10-21  6:13 ` [PATCH v2 06/10] PCI: tegra194: Check for L1SS " Manikanta Maddireddy
2026-10-21 15:28   ` Frank Li
2026-10-21  6:13 ` [PATCH v2 07/10] PCI: tegra194: Always disable Tegra234 Endpoint L1.2 Manikanta Maddireddy
2026-10-21 15:32   ` Frank Li
2026-10-21  6:13 ` Manikanta Maddireddy [this message]
2026-10-21 15:36   ` [PATCH v2 08/10] PCI: tegra194: Guard Endpoint PLL-off error path Frank Li
2026-10-21  6:13 ` [PATCH v2 09/10] PCI: tegra194: Balance core monitor clock on failures Manikanta Maddireddy
2026-10-21 15:43   ` Frank Li
2026-10-21  6:13 ` [PATCH v2 10/10] PCI: tegra194: Reject zero MSI interrupt number Manikanta Maddireddy
2026-10-21 15:44   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021061349.1265704-9-mmaddireddy@nvidia.com \
    --to=mmaddireddy@nvidia.com \
    --cc=Frank.Li@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=den@valinux.co.jp \
    --cc=jonathanh@nvidia.com \
    --cc=kishon@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=robh@kernel.org \
    --cc=thierry.reding@kernel.org \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®