mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vlad Poenaru <vlad.wing@gmail.com>
To: Boqun Feng <boqun@kernel.org>, netdev@vger.kernel.org
Cc: Bart Van Assche <bvanassche@acm.org>,
	Eric Dumazet <edumazet@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	Waiman Long <longman@redhat.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Simon Horman <horms@kernel.org>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Jiri Pirko <jiri@resnulli.us>,
	Davide Caratti <dcaratti@redhat.com>,
	Breno Leitao <leitao@debian.org>,
	Nilay Shroff <nilay@linux.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] net/sched: don't wait for RCU when destroying qdisc lockdep keys
Date: Wed, 21 Oct 2026 05:00:46 -0700	[thread overview]
Message-ID: <20261021120046.3279601-1-vlad.wing@gmail.com> (raw)
In-Reply-To: <atehw5Cn5Ev7Z68i@tardis.local>

On Tue, Oct 20, 2026 at 10:15:47AM -0700, Boqun Feng wrote:
> Sounds like a solid plan to me. You can make it behind
> CONFIG_LOCKDEP_DEBUG.

Done, under CONFIG_DEBUG_LOCKDEP, as a fallback.

> But this means lockdep needs to do its own allocation for the hash
> nodes? Where does the memory come from, a slab or something? If so, I
> think we should probably avoid that. But I like this idea more since it
> won't introduce another API. So please do explore this idea as well,
> thank you!

No slab. The nodes live in a static array with an in-use bitmap, like
lockdep's classes, list entries and chains, sized by a new
CONFIG_LOCKDEP_DYNAMIC_KEYS_BITS. Unregistering hands the node to the
existing delayed_free machinery, so a slot is only reused after a grace
period, and lockdep_unregister_key() no longer waits at all.
is_dynamic_key() only compares key addresses stored in lockdep's own
memory. I posted it as an RFC against tip/locking/core:

https://lore.kernel.org/all/20261021115621.3194947-1-vlad.wing@gmail.com/

With that, this series is not needed. Given Jakub's note it is on hold
anyway; I will only come back to it if the RFC approach does not work
out.

Thanks,
Vlad

  reply	other threads:[~2026-10-21 12:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 17:02 Vlad Poenaru
2026-10-19 17:02 ` [PATCH net-next 1/2] lockdep: Introduce lockdep_unregister_key_nosync() Vlad Poenaru
2026-10-19 17:38   ` Eric Dumazet
2026-10-19 17:02 ` [PATCH net-next 2/2] net/sched: Don't wait for RCU when unregistering the qdisc lockdep key Vlad Poenaru
2026-10-19 17:37   ` Eric Dumazet
2026-10-19 19:20 ` [PATCH net-next 0/2] net/sched: don't wait for RCU when destroying qdisc lockdep keys Boqun Feng
2026-10-20 12:53   ` Vlad Poenaru
2026-10-20 17:15     ` Boqun Feng
2026-10-21 12:00       ` Vlad Poenaru [this message]
2026-10-20 17:26   ` Bart Van Assche
2026-10-20 18:12     ` Boqun Feng
2026-10-20 20:21       ` Bart Van Assche
2026-10-20 20:32         ` Boqun Feng
2026-10-21  1:53 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021120046.3279601-1-vlad.wing@gmail.com \
    --to=vlad.wing@gmail.com \
    --cc=boqun@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nilay@linux.ibm.com \
    --cc=pabeni@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®