* [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support
@ 2026-10-22 9:16 Karthik S
0 siblings, 0 replies; 4+ messages in thread
From: Karthik S @ 2026-10-22 9:16 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: linux-arm-msm, linux-sound, devicetree, linux-kernel, Karthik S
Add SNDRV_PCM_FMTBIT_S32_LE to the supported formats for both capture
and playback hardware descriptors, and handle SNDRV_PCM_FORMAT_S32_LE
in q6apm_dai_hw_params() to set bits_per_sample to 32.
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
---
sound/soc/qcom/qdsp6/q6apm-dai.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-dai.c
index 033197bdd870..ec9ae2276361 100644
--- a/sound/soc/qcom/qdsp6/q6apm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6apm-dai.c
@@ -93,7 +93,8 @@ static const struct snd_pcm_hardware q6apm_dai_hardware_capture = {
SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME |
SNDRV_PCM_INFO_NO_REWINDS | SNDRV_PCM_INFO_SYNC_APPLPTR |
SNDRV_PCM_INFO_BATCH),
- .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE),
+ .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE |
+ SNDRV_PCM_FMTBIT_S32_LE),
.rates = SNDRV_PCM_RATE_8000_48000,
.rate_min = 8000,
.rate_max = 48000,
@@ -113,7 +114,8 @@ static const struct snd_pcm_hardware q6apm_dai_hardware_playback = {
SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME |
SNDRV_PCM_INFO_NO_REWINDS | SNDRV_PCM_INFO_SYNC_APPLPTR |
SNDRV_PCM_INFO_BATCH),
- .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE),
+ .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE |
+ SNDRV_PCM_FMTBIT_S32_LE),
.rates = SNDRV_PCM_RATE_8000_192000,
.rate_min = 8000,
.rate_max = 192000,
@@ -522,6 +524,9 @@ static int q6apm_dai_hw_params(struct snd_soc_component *component,
case SNDRV_PCM_FORMAT_S24_LE:
prtd->bits_per_sample = 24;
break;
+ case SNDRV_PCM_FORMAT_S32_LE:
+ prtd->bits_per_sample = 32;
+ break;
default:
return -EINVAL;
}
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v1 0/5] ASoC: qcom: Add Shikra IQS LT9611UXD EVK audio support
@ 2026-10-22 9:43 Karthik S
2026-10-22 9:43 ` [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support Karthik S
0 siblings, 1 reply; 4+ messages in thread
From: Karthik S @ 2026-10-22 9:43 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, linux-arm-msm, devicetree, linux-kernel, Karthik S
This series adds audio support for the Shikra IQS EVK board variant
that uses the LT9611UXD HDMI bridge as an I2S audio codec instead of
the MAX98091 codec used on the base Shikra IQS EVK.
The Shikra IQS platform uses modem-DSP based audio processing. The
base IQS variant uses a third-party MAX98091 codec. This series adds
support for a board subtype where the LT9611UXD HDMI bridge takes the
place of the MAX98091 on the primary I2S bus, allowing HDMI audio
output without the on-board codec.
Changes included in this series:
- Patch 1/5: Add the shikra-iqs-lt9611uxd-sndcard compatible to the
DT binding
- Patch 2/5: Add the DT overlay for the LT9611UXD EVK variant, with a
label fix to shikra-iqs-evk.dts and Makefile entry
- Patch 3/5: Extend q6apm frontend DAI to support 32-bit sample format
- Patch 4/5: Conditionally skip S16_LE fixup for MI2S and DisplayPort
DAIs so they can negotiate format freely
- Patch 5/5: Add shikra-iqs-lt9611uxd-evk compatible to the sc8280xp
machine driver
Dependencies:
- https://lore.kernel.org/all/20260910-shikra-machine-v2-v2-0-9bf6bad589d8@oss.qualcomm.com/
Shikra IQS base machine driver support (precon)
- https://lore.kernel.org/all/20260910231642.1794948-9-mohammad.rafi.shaik@oss.qualcomm.com/
LT9611UXD DAI/codec driver support
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
---
Karthik S (5):
ASoC: dt-bindings: qcom,sm8250: Add shikra-iqs-lt9611uxd-evk sound card
arm64: dts: qcom: shikra-iqs: Add LT9611UXD HDMI audio overlay
ASoC: qcom: q6apm-dai: Add 32-bit sample format support
ASoC: qcom: sc8280xp: Conditionally set S16_LE format in hw_params fixup
ASoC: qcom: sc8280xp: Add shikra-iqs-lt9611uxd-evk compatible support
.../devicetree/bindings/sound/qcom,sm8250.yaml | 43 ++++++++++++++++++++++
arch/arm64/boot/dts/qcom/Makefile | 4 ++
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 2 +-
.../boot/dts/qcom/shikra-iqs-lt9611uxd-evk.dtso | 36 ++++++++++++++++++
sound/soc/qcom/qdsp6/q6apm-dai.c | 9 ++++-
sound/soc/qcom/sc8280xp.c | 22 ++++++++++-
6 files changed, 112 insertions(+), 4 deletions(-)
create mode 100644 arch/arm64/boot/dts/qcom/shikra-iqs-lt9611uxd-evk.dtso
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support
2026-10-22 9:43 [PATCH v1 0/5] ASoC: qcom: Add Shikra IQS LT9611UXD EVK audio support Karthik S
@ 2026-10-22 9:43 ` Karthik S
2026-10-27 8:32 ` Prasad Kumpatla
0 siblings, 1 reply; 4+ messages in thread
From: Karthik S @ 2026-10-22 9:43 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, linux-arm-msm, devicetree, linux-kernel, Karthik S
Add SNDRV_PCM_FMTBIT_S32_LE to the supported formats for both capture
and playback hardware descriptors, and handle SNDRV_PCM_FORMAT_S32_LE
in q6apm_dai_hw_params() to set bits_per_sample to 32.
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
---
sound/soc/qcom/qdsp6/q6apm-dai.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-dai.c
index 033197bdd870..ec9ae2276361 100644
--- a/sound/soc/qcom/qdsp6/q6apm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6apm-dai.c
@@ -93,7 +93,8 @@ static const struct snd_pcm_hardware q6apm_dai_hardware_capture = {
SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME |
SNDRV_PCM_INFO_NO_REWINDS | SNDRV_PCM_INFO_SYNC_APPLPTR |
SNDRV_PCM_INFO_BATCH),
- .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE),
+ .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE |
+ SNDRV_PCM_FMTBIT_S32_LE),
.rates = SNDRV_PCM_RATE_8000_48000,
.rate_min = 8000,
.rate_max = 48000,
@@ -113,7 +114,8 @@ static const struct snd_pcm_hardware q6apm_dai_hardware_playback = {
SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME |
SNDRV_PCM_INFO_NO_REWINDS | SNDRV_PCM_INFO_SYNC_APPLPTR |
SNDRV_PCM_INFO_BATCH),
- .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE),
+ .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE |
+ SNDRV_PCM_FMTBIT_S32_LE),
.rates = SNDRV_PCM_RATE_8000_192000,
.rate_min = 8000,
.rate_max = 192000,
@@ -522,6 +524,9 @@ static int q6apm_dai_hw_params(struct snd_soc_component *component,
case SNDRV_PCM_FORMAT_S24_LE:
prtd->bits_per_sample = 24;
break;
+ case SNDRV_PCM_FORMAT_S32_LE:
+ prtd->bits_per_sample = 32;
+ break;
default:
return -EINVAL;
}
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support
2026-10-22 9:43 ` [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support Karthik S
@ 2026-10-27 8:32 ` Prasad Kumpatla
0 siblings, 0 replies; 4+ messages in thread
From: Prasad Kumpatla @ 2026-10-27 8:32 UTC (permalink / raw)
To: Karthik S, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: linux-sound, linux-arm-msm, devicetree, linux-kernel
On 10/22/2026 3:13 PM, Karthik S wrote:
> Add SNDRV_PCM_FMTBIT_S32_LE to the supported formats for both capture
> and playback hardware descriptors, and handle SNDRV_PCM_FORMAT_S32_LE
> in q6apm_dai_hw_params() to set bits_per_sample to 32.
>
> Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
> ---
> sound/soc/qcom/qdsp6/q6apm-dai.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
LGTM.
Reviewed-by: Prasad Kumpatla<prasad.kumpatla@oss.qualcomm.com>
Thanks,
Prasad
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 0/5] ASoC: qcom: Add Shikra IQS LT9611UXD EVK audio support
@ 2026-10-22 7:42 Karthik S
2026-10-22 7:42 ` [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support Karthik S
0 siblings, 1 reply; 4+ messages in thread
From: Karthik S @ 2026-10-22 7:42 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: linux-arm-msm, linux-sound, devicetree, linux-kernel, Karthik S
This series adds audio support for the Shikra IQS EVK board variant
that uses the LT9611UXD HDMI bridge as an I2S audio codec instead of
the MAX98091 codec used on the base Shikra IQS EVK.
The Shikra IQS platform uses modem-DSP based audio processing. The
base IQS variant uses a third-party MAX98091 codec. This series adds
support for a board subtype where the LT9611UXD HDMI bridge takes the
place of the MAX98091 on the primary I2S bus, allowing HDMI audio
output without the on-board codec.
Changes included in this series:
- Patch 1/5: Add the shikra-iqs-lt9611uxd-sndcard compatible to the
DT binding
- Patch 2/5: Add the DT overlay for the LT9611UXD EVK variant, with a
label fix to shikra-iqs-evk.dts and Makefile entry
- Patch 3/5: Extend q6apm frontend DAI to support 32-bit sample format
- Patch 4/5: Conditionally skip S16_LE fixup for MI2S and DisplayPort
DAIs so they can negotiate format freely
- Patch 5/5: Add shikra-iqs-lt9611uxd-evk compatible to the sc8280xp
machine driver
Dependencies:
- https://lore.kernel.org/all/20260910-shikra-machine-v2-v2-0-9bf6bad589d8@oss.qualcomm.com/
Shikra IQS base machine driver support (precon)
- https://lore.kernel.org/all/20260910231642.1794948-9-mohammad.rafi.shaik@oss.qualcomm.com/
LT9611UXD DAI/codec driver support
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
---
Karthik S (5):
ASoC: dt-bindings: qcom,sm8250: Add shikra-iqs-lt9611uxd-evk sound card
arm64: dts: qcom: shikra-iqs: Add LT9611UXD HDMI audio overlay
ASoC: qcom: q6apm-dai: Add 32-bit sample format support
ASoC: qcom: sc8280xp: Conditionally set S16_LE format in hw_params fixup
ASoC: qcom: sc8280xp: Add shikra-iqs-lt9611uxd-evk compatible support
.../devicetree/bindings/sound/qcom,sm8250.yaml | 43 ++++++++++++++++++++++
arch/arm64/boot/dts/qcom/Makefile | 4 ++
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 2 +-
.../boot/dts/qcom/shikra-iqs-lt9611uxd-evk.dtso | 36 ++++++++++++++++++
sound/soc/qcom/qdsp6/q6apm-dai.c | 9 ++++-
sound/soc/qcom/sc8280xp.c | 22 ++++++++++-
6 files changed, 112 insertions(+), 4 deletions(-)
create mode 100644 arch/arm64/boot/dts/qcom/shikra-iqs-lt9611uxd-evk.dtso
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support
2026-10-22 7:42 [PATCH v1 0/5] ASoC: qcom: Add Shikra IQS LT9611UXD EVK audio support Karthik S
@ 2026-10-22 7:42 ` Karthik S
0 siblings, 0 replies; 4+ messages in thread
From: Karthik S @ 2026-10-22 7:42 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Jaroslav Kysela, Takashi Iwai
Cc: linux-arm-msm, linux-sound, devicetree, linux-kernel, Karthik S
Add SNDRV_PCM_FMTBIT_S32_LE to the supported formats for both capture
and playback hardware descriptors, and handle SNDRV_PCM_FORMAT_S32_LE
in q6apm_dai_hw_params() to set bits_per_sample to 32.
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
---
sound/soc/qcom/qdsp6/q6apm-dai.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-dai.c
index 033197bdd870..ec9ae2276361 100644
--- a/sound/soc/qcom/qdsp6/q6apm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6apm-dai.c
@@ -93,7 +93,8 @@ static const struct snd_pcm_hardware q6apm_dai_hardware_capture = {
SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME |
SNDRV_PCM_INFO_NO_REWINDS | SNDRV_PCM_INFO_SYNC_APPLPTR |
SNDRV_PCM_INFO_BATCH),
- .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE),
+ .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE |
+ SNDRV_PCM_FMTBIT_S32_LE),
.rates = SNDRV_PCM_RATE_8000_48000,
.rate_min = 8000,
.rate_max = 48000,
@@ -113,7 +114,8 @@ static const struct snd_pcm_hardware q6apm_dai_hardware_playback = {
SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME |
SNDRV_PCM_INFO_NO_REWINDS | SNDRV_PCM_INFO_SYNC_APPLPTR |
SNDRV_PCM_INFO_BATCH),
- .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE),
+ .formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE |
+ SNDRV_PCM_FMTBIT_S32_LE),
.rates = SNDRV_PCM_RATE_8000_192000,
.rate_min = 8000,
.rate_max = 192000,
@@ -522,6 +524,9 @@ static int q6apm_dai_hw_params(struct snd_soc_component *component,
case SNDRV_PCM_FORMAT_S24_LE:
prtd->bits_per_sample = 24;
break;
+ case SNDRV_PCM_FORMAT_S32_LE:
+ prtd->bits_per_sample = 32;
+ break;
default:
return -EINVAL;
}
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-27 8:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-22 9:16 [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support Karthik S
-- strict thread matches above, loose matches on Subject: below --
2026-10-22 9:43 [PATCH v1 0/5] ASoC: qcom: Add Shikra IQS LT9611UXD EVK audio support Karthik S
2026-10-22 9:43 ` [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support Karthik S
2026-10-27 8:32 ` Prasad Kumpatla
2026-10-22 7:42 [PATCH v1 0/5] ASoC: qcom: Add Shikra IQS LT9611UXD EVK audio support Karthik S
2026-10-22 7:42 ` [PATCH v1 3/5] ASoC: qcom: q6apm-dai: Add 32-bit sample format support Karthik S
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®