From: Breno Rodrigues Alves <breno3011alves@gmail.com>
To: linux@armlinux.org.uk
Cc: James.Bottomley@HansenPartnership.com, mkp@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Breno Rodrigues Alves <breno3011alves@gmail.com>
Subject: [PATCH v2 0/1] scsi: arm: Convert acornscsi-io.S to C
Date: Thu, 22 Oct 2026 15:52:23 -0300 [thread overview]
Message-ID: <20261022185224.60700-1-breno3011alves@gmail.com> (raw)
In-Reply-To: <20261022183658.58090-1-breno3011alves@gmail.com>
v2 addresses two issues raised by the sashiko bot:
- PTR_ALIGN() rounds up, but the assembly's "bic r0, r0, #3"
rounds down. Use PTR_ALIGN_DOWN() to match, otherwise an odd
on-card offset shifts the entire transfer by one 16-bit halfword
and can walk past the 4 KiB card window.
- In __acornscsi_out(), the trailing byte loop advanced by 2 bytes
into the unused upper half of the current card word. Advance by
a full 32-bit word (card++) so the trailing byte lands in the
low half of the next card word, which is where the hardware
actually samples it.
No functional change for even-length transfers. The odd-length
behaviour is now correct for both directions.
Breno (1):
scsi: arm: Convert acornscsi-io.S to C
drivers/scsi/arm/acornscsi-io.S | 116 ------------
drivers/scsi/arm/acornscsi-io.c | 168 ++++++++++++++++++++++
drivers/scsi/arm/acornscsi-io.h | 15 +++
drivers/scsi/arm/acornscsi.c | 3 +-
4 files changed, 184 insertions(+), 137 deletions(-)
next prev parent reply other threads:[~2026-10-22 18:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 18:36 [PATCH " Breno Rodrigues Alves
2026-10-22 18:36 ` [PATCH] " Breno Rodrigues Alves
2026-10-22 18:52 ` Breno Rodrigues Alves [this message]
2026-10-22 18:52 ` [PATCH v2] " Breno Rodrigues Alves
2026-10-22 19:22 ` Bart Van Assche
2026-10-22 20:30 ` Breno Rodrigues Alves
2026-10-22 21:02 ` Breno Rodrigues Alves
2026-10-22 20:30 ` [PATCH v3] " Breno Rodrigues Alves
2026-10-22 20:49 ` Bart Van Assche
2026-10-22 21:02 ` [PATCH v4] " Breno Rodrigues Alves
2026-10-22 21:36 ` Bart Van Assche
2026-10-22 21:44 ` Jonathan Corbet
2026-10-22 21:48 ` Breno Rodrigues Alves
2026-10-22 22:15 ` Jonathan Corbet
2026-10-22 22:28 ` Breno Rodrigues Alves
2026-10-22 22:46 ` Jonathan Corbet
2026-10-22 23:00 ` Breno Rodrigues Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022185224.60700-1-breno3011alves@gmail.com \
--to=breno3011alves@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mkp@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®