Re: [PATCH v4] scsi: arm: Convert acornscsi-io.S to C

[Jonathan Corbet <corbet@lwn.net>]

Breno Rodrigues Alves <breno3011alves@gmail.com> writes:

> What I did NOT test:
>
>  - Real hardware.  I do not have an Acorn RiscPC or the SCSI expansion
>    card.  The unit test proves equivalence with the original assembly
>    semantics, but it cannot prove that the semantics match the actual
>    hardware - only that the C version does the same thing the assembly
>    did.
>
>  - Odd transfer lengths through acornscsi.c.  All current callers pass
>    even lengths, so the trailing-byte path is only exercised by the
>    unit test, not by the driver end-to-end.
>
>  - Interrupt handling under load.  This is unchanged by the patch (the
>    IRQ path is untouched), so I did not add specific coverage.
>
> If there is a specific test or configuration you would like me to run,
> please let me know.

I guess what I *really* want to know is why you are messing with a
driver for hardware you don't have - for a computer which was
discontinued in 1998 - and translating a file that has not seen a
significant change in the entire Git era?  What benefit does this bring
to anybody?

You seem to be on a real mission to do these translations, but they are
not valuable for their own sake.  The kernel does not lack for churn as
it is.

jon