Re: [PATCH v4] scsi: arm: Convert acornscsi-io.S to C

[Jonathan Corbet <corbet@lwn.net>]

Breno Rodrigues Alves <breno3011alves@gmail.com> writes:

> You are also right about the broader point: "assembly to C" on its own
> is not a justification.  The kernel's assembly is there for reasons, and
> translating it for its own sake is churn that reviewers have to pay for.
> I have been approaching this as a translation exercise, and that is not
> the right frame.  I will not propose further conversions of that kind
> without a concrete functional benefit - something that fixes a bug that
> can actually be hit, or enables a change that cannot be done in assembly.

Note that conversion to C can be justified if it eases the maintenance
of the file in question.  In this case, there's not really been any need
for maintenance, so (in my mind) little need for translation.

> Bart's Reviewed-by: stands on the technical merits of the change as a
> change (the C code is equivalent to the assembly for even lengths and
> correct for odd ones).  Your concern is a different question - whether
> the change should exist at all.  Both are valid, and the decision
> belongs to the SCSI maintainers, not to me.

Bart's word outweighs mine here, just to be clear.

jon