From: Breno Rodrigues Alves <breno3011alves@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Breno Rodrigues Alves <breno3011alves@gmail.com>
Subject: Re: [PATCH] staging: axis-fifo: Fix three real issues
Date: Fri, 23 Oct 2026 05:52:00 -0300 [thread overview]
Message-ID: <20261023085200.5206-1-breno3011alves@gmail.com> (raw)
In-Reply-To: <2026102337-headroom-shun-9d45@gregkh>
Hi Greg,
You are right, and I apologize for the noise. No tool told me this -
it was my own reasoning. I had the (outdated) impression that passing
an ERR_PTR parent from debugfs_create_dir() to debugfs_create_file()
would trigger a WARN in the debugfs core. That was true years ago, but
modern debugfs handles ERR_PTR parents gracefully, and I should have
verified the claim on a CONFIG_DEBUG_FS=n kernel before sending the
patch.
The other two changes are independent of that assumption:
- the -EINVAL -> -ENOBUFS change in axis_fifo_read(), which changes
the errno returned when the user buffer is smaller than the
available data;
- the removal of the unused 'struct resource *r_mem' local.
If either of those is worth keeping, I can resend with just those two.
If the whole patch looks like churn, please let me know and I will drop
it.
Sorry again,
Breno
next prev parent reply other threads:[~2026-10-23 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 21:53 Breno Rodrigues Alves
2026-10-23 6:08 ` Greg Kroah-Hartman
2026-10-23 8:52 ` Breno Rodrigues Alves [this message]
2026-10-23 9:27 ` Dan Carpenter
2026-10-23 10:39 ` [PATCH v2] staging: axis-fifo: remove unused r_mem local variable Breno Rodrigues Alves
2026-10-23 10:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023085200.5206-1-breno3011alves@gmail.com \
--to=breno3011alves@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®