From: Dan Carpenter <error27@gmail.com>
To: Breno Rodrigues Alves <breno3011alves@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: axis-fifo: remove unused r_mem local variable
Date: Fri, 23 Oct 2026 13:44:02 +0300 [thread overview]
Message-ID: <ats6crcniknWB9ry@stanley.mountain> (raw)
In-Reply-To: <20261023103943.20995-1-breno3011alves@gmail.com>
On Fri, Oct 23, 2026 at 07:39:43AM -0300, Breno Rodrigues Alves wrote:
> Remove 'struct resource *r_mem' from axis_fifo_probe(). It is filled
> in by devm_platform_get_and_ioremap_resource() but never read; pass
> NULL instead.
>
> This is v2 of a three-change series. The debugfs_create_dir() check
> was dropped because debugfs has handled ERR_PTR parents gracefully
> since 2019 (thanks Greg and Dan for the correction). The
> -EINVAL -> -ENOBUFS change was dropped as well, after Dan Carpenter
> noted that -EINVAL is the common errno for this path and that he
> would leave the choice to the author.
This kind of meta commentary goes below the --- cut off line
>
> Signed-off-by: Breno Rodrigues Alves <breno3011alves@gmail.com>
> ---
^^^
here.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
As always wait until tomorrow to send v3.
regards,
dan carpenter
prev parent reply other threads:[~2026-10-23 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 21:53 [PATCH] staging: axis-fifo: Fix three real issues Breno Rodrigues Alves
2026-10-23 6:08 ` Greg Kroah-Hartman
2026-10-23 8:52 ` Breno Rodrigues Alves
2026-10-23 9:27 ` Dan Carpenter
2026-10-23 10:39 ` [PATCH v2] staging: axis-fifo: remove unused r_mem local variable Breno Rodrigues Alves
2026-10-23 10:44 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ats6crcniknWB9ry@stanley.mountain \
--to=error27@gmail.com \
--cc=breno3011alves@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®